Displaying 20 results from an estimated 67 matches for "virtio_f_bad_feature".
2014 Dec 11
0
[PATCH RFC v6 03/20] virtio: feature bit manipulation helpers
...IODevice *vdev)
dev->host_features[0] = virtio_bus_get_vdev_features(&dev->bus,
dev->host_features[0]);
- dev->host_features[0] |= 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY;
- dev->host_features[0] |= 0x1 << VIRTIO_F_BAD_FEATURE;
+ virtio_add_feature(&dev->host_features[0], VIRTIO_F_NOTIFY_ON_EMPTY);
+ virtio_add_feature(&dev->host_features[0], VIRTIO_F_BAD_FEATURE);
css_generate_sch_crws(sch->cssid, sch->ssid, sch->schid,
parent->hotplugged, 1);
diff --git...
2014 Dec 11
0
[PATCH RFC v6 03/20] virtio: feature bit manipulation helpers
...IODevice *vdev)
dev->host_features[0] = virtio_bus_get_vdev_features(&dev->bus,
dev->host_features[0]);
- dev->host_features[0] |= 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY;
- dev->host_features[0] |= 0x1 << VIRTIO_F_BAD_FEATURE;
+ virtio_add_feature(&dev->host_features[0], VIRTIO_F_NOTIFY_ON_EMPTY);
+ virtio_add_feature(&dev->host_features[0], VIRTIO_F_BAD_FEATURE);
css_generate_sch_crws(sch->cssid, sch->ssid, sch->schid,
parent->hotplugged, 1);
diff --git...
2015 Jan 22
2
[Qemu-devel] [PATCH RFC v6 05/20] virtio: support more feature bits
...diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
> index f6c0379..08141c7 100644
> --- a/include/hw/virtio/virtio.h
> +++ b/include/hw/virtio/virtio.h
> @@ -55,6 +55,12 @@
> /* A guest should never accept this. It implies negotiation is broken. */
> #define VIRTIO_F_BAD_FEATURE 30
>
> +/* v1.0 compliant. */
> +#define VIRTIO_F_VERSION_1 32
This is already in the kernel header, isn't it?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _arou...
2015 Jan 22
2
[Qemu-devel] [PATCH RFC v6 05/20] virtio: support more feature bits
...diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
> index f6c0379..08141c7 100644
> --- a/include/hw/virtio/virtio.h
> +++ b/include/hw/virtio/virtio.h
> @@ -55,6 +55,12 @@
> /* A guest should never accept this. It implies negotiation is broken. */
> #define VIRTIO_F_BAD_FEATURE 30
>
> +/* v1.0 compliant. */
> +#define VIRTIO_F_VERSION_1 32
This is already in the kernel header, isn't it?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _arou...
2015 May 12
1
[Qemu-devel] [PATCH RFC 1/7] virtio: relax feature check
...t;
> > After we move host_features, put them into an optional vmstate
> > subsection?
> >
> > I think with the recent patchsets, most of the interesting stuff is
> > already not handled by the transport anymore. There's only
> > VIRTIO_F_NOTIFY_ON_EMPTY and VIRTIO_F_BAD_FEATURE left (set by pci and
> > ccw).
notify on empty is likely safe to set for everyone.
bad feature should be pci specific, it's a mistake that
we have it in ccw. it's there to detect very old buggy guests.
in fact ccw ignores this bit completely.
For PCI, I think VIRTIO_F_BAD_FEATURE i...
2015 May 12
1
[Qemu-devel] [PATCH RFC 1/7] virtio: relax feature check
...t;
> > After we move host_features, put them into an optional vmstate
> > subsection?
> >
> > I think with the recent patchsets, most of the interesting stuff is
> > already not handled by the transport anymore. There's only
> > VIRTIO_F_NOTIFY_ON_EMPTY and VIRTIO_F_BAD_FEATURE left (set by pci and
> > ccw).
notify on empty is likely safe to set for everyone.
bad feature should be pci specific, it's a mistake that
we have it in ccw. it's there to detect very old buggy guests.
in fact ccw ignores this bit completely.
For PCI, I think VIRTIO_F_BAD_FEATURE i...
2015 May 12
2
[Qemu-devel] [PATCH RFC 1/7] virtio: relax feature check
...t features is none set.
>
> Thoughts? Any takers?
>
After we move host_features, put them into an optional vmstate
subsection?
I think with the recent patchsets, most of the interesting stuff is
already not handled by the transport anymore. There's only
VIRTIO_F_NOTIFY_ON_EMPTY and VIRTIO_F_BAD_FEATURE left (set by pci and
ccw).
2015 May 12
2
[Qemu-devel] [PATCH RFC 1/7] virtio: relax feature check
...t features is none set.
>
> Thoughts? Any takers?
>
After we move host_features, put them into an optional vmstate
subsection?
I think with the recent patchsets, most of the interesting stuff is
already not handled by the transport anymore. There's only
VIRTIO_F_NOTIFY_ON_EMPTY and VIRTIO_F_BAD_FEATURE left (set by pci and
ccw).
2015 Jan 29
2
[Qemu-devel] [PATCH RFC v6 05/20] virtio: support more feature bits
.../virtio.h
> > > index f6c0379..08141c7 100644
> > > --- a/include/hw/virtio/virtio.h
> > > +++ b/include/hw/virtio/virtio.h
> > > @@ -55,6 +55,12 @@
> > > /* A guest should never accept this. It implies negotiation is broken. */
> > > #define VIRTIO_F_BAD_FEATURE 30
> > >
> > > +/* v1.0 compliant. */
> > > +#define VIRTIO_F_VERSION_1 32
> >
> > This is already in the kernel header, isn't it?
>
> Yes. But nearly all files include this header but not the kernel
> header.
Can't you cha...
2015 Jan 29
2
[Qemu-devel] [PATCH RFC v6 05/20] virtio: support more feature bits
.../virtio.h
> > > index f6c0379..08141c7 100644
> > > --- a/include/hw/virtio/virtio.h
> > > +++ b/include/hw/virtio/virtio.h
> > > @@ -55,6 +55,12 @@
> > > /* A guest should never accept this. It implies negotiation is broken. */
> > > #define VIRTIO_F_BAD_FEATURE 30
> > >
> > > +/* v1.0 compliant. */
> > > +#define VIRTIO_F_VERSION_1 32
> >
> > This is already in the kernel header, isn't it?
>
> Yes. But nearly all files include this header but not the kernel
> header.
Can't you cha...
2014 Oct 24
5
[PATCH RFC 00/11] qemu: towards virtio-1 host support
...+839,16 @@ static int virtio_ccw_device_init(VirtioCcwDevice *dev, VirtIODevice *vdev)
dev->revision = -1;
/* Set default feature bits that are offered by the host. */
+ dev->host_features[0] = 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY;
+ dev->host_features[0] |= 0x1 << VIRTIO_F_BAD_FEATURE;
+
+ dev->host_features[1] = 1 << (VIRTIO_F_VERSION_1 - 32);
+
for (i = 0; i < ARRAY_SIZE(dev->host_features); i++) {
dev->host_features[i] =
virtio_bus_get_vdev_features(&dev->bus, i, dev->host_features[i]);
}
- dev->host_featu...
2014 Oct 24
5
[PATCH RFC 00/11] qemu: towards virtio-1 host support
...+839,16 @@ static int virtio_ccw_device_init(VirtioCcwDevice *dev, VirtIODevice *vdev)
dev->revision = -1;
/* Set default feature bits that are offered by the host. */
+ dev->host_features[0] = 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY;
+ dev->host_features[0] |= 0x1 << VIRTIO_F_BAD_FEATURE;
+
+ dev->host_features[1] = 1 << (VIRTIO_F_VERSION_1 - 32);
+
for (i = 0; i < ARRAY_SIZE(dev->host_features); i++) {
dev->host_features[i] =
virtio_bus_get_vdev_features(&dev->bus, i, dev->host_features[i]);
}
- dev->host_featu...
2009 Aug 10
1
[PATCH] qemu/virtio: move features to an inline function
...virtio_ioport_read(VirtIOPCIProxy *proxy, uint32_t addr)
switch (addr) {
case VIRTIO_PCI_HOST_FEATURES:
ret = vdev->get_features(vdev);
- ret |= (1 << VIRTIO_F_NOTIFY_ON_EMPTY);
- ret |= (1 << VIRTIO_RING_F_INDIRECT_DESC);
- ret |= (1 << VIRTIO_F_BAD_FEATURE);
break;
case VIRTIO_PCI_GUEST_FEATURES:
ret = vdev->features;
diff --git a/hw/virtio.h b/hw/virtio.h
index aa55677..de620a7 100644
--- a/hw/virtio.h
+++ b/hw/virtio.h
@@ -166,4 +166,14 @@ VirtIODevice *virtio_net_init(DeviceState *dev);
VirtIODevice *virtio_console_init(...
2009 Aug 10
1
[PATCH] qemu/virtio: move features to an inline function
...virtio_ioport_read(VirtIOPCIProxy *proxy, uint32_t addr)
switch (addr) {
case VIRTIO_PCI_HOST_FEATURES:
ret = vdev->get_features(vdev);
- ret |= (1 << VIRTIO_F_NOTIFY_ON_EMPTY);
- ret |= (1 << VIRTIO_RING_F_INDIRECT_DESC);
- ret |= (1 << VIRTIO_F_BAD_FEATURE);
break;
case VIRTIO_PCI_GUEST_FEATURES:
ret = vdev->features;
diff --git a/hw/virtio.h b/hw/virtio.h
index aa55677..de620a7 100644
--- a/hw/virtio.h
+++ b/hw/virtio.h
@@ -166,4 +166,14 @@ VirtIODevice *virtio_net_init(DeviceState *dev);
VirtIODevice *virtio_console_init(...
2009 Nov 02
1
[PATCHv4 1/6] qemu/virtio: move features to an inline function
...virtio_ioport_read(VirtIOPCIProxy *proxy, uint32_t addr)
switch (addr) {
case VIRTIO_PCI_HOST_FEATURES:
ret = vdev->get_features(vdev);
- ret |= (1 << VIRTIO_F_NOTIFY_ON_EMPTY);
- ret |= (1 << VIRTIO_RING_F_INDIRECT_DESC);
- ret |= (1 << VIRTIO_F_BAD_FEATURE);
break;
case VIRTIO_PCI_GUEST_FEATURES:
ret = vdev->features;
diff --git a/hw/virtio.h b/hw/virtio.h
index 0f9be7d..799e608 100644
--- a/hw/virtio.h
+++ b/hw/virtio.h
@@ -167,4 +167,14 @@ VirtIODevice *virtio_net_init(DeviceState *dev);
VirtIODevice *virtio_console_init(...
2009 Nov 02
1
[PATCHv4 1/6] qemu/virtio: move features to an inline function
...virtio_ioport_read(VirtIOPCIProxy *proxy, uint32_t addr)
switch (addr) {
case VIRTIO_PCI_HOST_FEATURES:
ret = vdev->get_features(vdev);
- ret |= (1 << VIRTIO_F_NOTIFY_ON_EMPTY);
- ret |= (1 << VIRTIO_RING_F_INDIRECT_DESC);
- ret |= (1 << VIRTIO_F_BAD_FEATURE);
break;
case VIRTIO_PCI_GUEST_FEATURES:
ret = vdev->features;
diff --git a/hw/virtio.h b/hw/virtio.h
index 0f9be7d..799e608 100644
--- a/hw/virtio.h
+++ b/hw/virtio.h
@@ -167,4 +167,14 @@ VirtIODevice *virtio_net_init(DeviceState *dev);
VirtIODevice *virtio_console_init(...
2015 Jan 29
1
[Qemu-devel] [PATCH RFC v6 05/20] virtio: support more feature bits
...0644
> > > > > --- a/include/hw/virtio/virtio.h
> > > > > +++ b/include/hw/virtio/virtio.h
> > > > > @@ -55,6 +55,12 @@
> > > > > /* A guest should never accept this. It implies negotiation is broken. */
> > > > > #define VIRTIO_F_BAD_FEATURE 30
> > > > >
> > > > > +/* v1.0 compliant. */
> > > > > +#define VIRTIO_F_VERSION_1 32
> > > >
> > > > This is already in the kernel header, isn't it?
> >
> > >
> > > Yes. But nearly...
2015 Jan 29
1
[Qemu-devel] [PATCH RFC v6 05/20] virtio: support more feature bits
...0644
> > > > > --- a/include/hw/virtio/virtio.h
> > > > > +++ b/include/hw/virtio/virtio.h
> > > > > @@ -55,6 +55,12 @@
> > > > > /* A guest should never accept this. It implies negotiation is broken. */
> > > > > #define VIRTIO_F_BAD_FEATURE 30
> > > > >
> > > > > +/* v1.0 compliant. */
> > > > > +#define VIRTIO_F_VERSION_1 32
> > > >
> > > > This is already in the kernel header, isn't it?
> >
> > >
> > > Yes. But nearly...
2014 Oct 28
0
[PATCH RFC 00/11] qemu: towards virtio-1 host support
...tio_ccw_device_init(VirtioCcwDevice *dev, VirtIODevice *vdev)
> dev->revision = -1;
>
> /* Set default feature bits that are offered by the host. */
> + dev->host_features[0] = 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY;
> + dev->host_features[0] |= 0x1 << VIRTIO_F_BAD_FEATURE;
> +
> + dev->host_features[1] = 1 << (VIRTIO_F_VERSION_1 - 32);
> +
> for (i = 0; i < ARRAY_SIZE(dev->host_features); i++) {
> dev->host_features[i] =
> virtio_bus_get_vdev_features(&dev->bus, i, dev->host_features[i]);
&g...
2013 Jul 08
2
[PATCH] virtio-spec: add field for scsi command size
"Michael S. Tsirkin" <mst at redhat.com> writes:
> On Thu, Jul 04, 2013 at 10:49:42AM +0300, Michael S. Tsirkin wrote:
>> > case).
>> >
>> > Regrettably, initial driver implementations used simple layouts
>> > and devices came to rely on it, despite this specification
>> > wording. It is thus recommended that drivers be conservative