Displaying 20 results from an estimated 295 matches for "virtio_f_any_layout".
2013 Jul 08
3
[PATCH] virtio-net: put virtio net header inline with data
...most packets seem to have enough head room
we can use for this purpose.
Since existing hypervisors require that header
is the first s/g element, we need a feature bit
for this.
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
Note: this needs to be applied on top of patch
defining VIRTIO_F_ANY_LAYOUT - bit to be
selected by Rusty.
The following patch should work for any definition of
VIRTIO_F_ANY_LAYOUT - I used bit 31 for testing.
Rusty, could you please pick a valid bit for VIRTIO_F_ANY_LAYOUT
and squeeze this patch into 3.11?
drivers/net/virtio_net.c | 42 ++++++++++++++++++++++++++...
2013 Jul 08
3
[PATCH] virtio-net: put virtio net header inline with data
...most packets seem to have enough head room
we can use for this purpose.
Since existing hypervisors require that header
is the first s/g element, we need a feature bit
for this.
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
Note: this needs to be applied on top of patch
defining VIRTIO_F_ANY_LAYOUT - bit to be
selected by Rusty.
The following patch should work for any definition of
VIRTIO_F_ANY_LAYOUT - I used bit 31 for testing.
Rusty, could you please pick a valid bit for VIRTIO_F_ANY_LAYOUT
and squeeze this patch into 3.11?
drivers/net/virtio_net.c | 42 ++++++++++++++++++++++++++...
2013 Jul 09
3
[PATCH] virtio-net: put virtio net header inline with data
...existing hypervisors require that header
> > is the first s/g element, we need a feature bit
> > for this.
> >
> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
> > ---
> >
> > Note: this needs to be applied on top of patch
> > defining VIRTIO_F_ANY_LAYOUT - bit to be
> > selected by Rusty.
> >
> > The following patch should work for any definition of
> > VIRTIO_F_ANY_LAYOUT - I used bit 31 for testing.
> > Rusty, could you please pick a valid bit for VIRTIO_F_ANY_LAYOUT
> > and squeeze this patch into 3.11?
>...
2013 Jul 09
3
[PATCH] virtio-net: put virtio net header inline with data
...existing hypervisors require that header
> > is the first s/g element, we need a feature bit
> > for this.
> >
> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
> > ---
> >
> > Note: this needs to be applied on top of patch
> > defining VIRTIO_F_ANY_LAYOUT - bit to be
> > selected by Rusty.
> >
> > The following patch should work for any definition of
> > VIRTIO_F_ANY_LAYOUT - I used bit 31 for testing.
> > Rusty, could you please pick a valid bit for VIRTIO_F_ANY_LAYOUT
> > and squeeze this patch into 3.11?
>...
2014 Dec 11
3
[PATCH RFC v6 04/20] virtio: add feature checking helpers
...fb 100644
> --- a/hw/scsi/virtio-scsi.c
> +++ b/hw/scsi/virtio-scsi.c
> @@ -144,7 +144,7 @@ static int virtio_scsi_parse_req(VirtIOSCSIReq *req,
> *
> * TODO: always disable this workaround for virtio 1.0 devices.
> */
> - if ((vdev->guest_features & VIRTIO_F_ANY_LAYOUT) == 0) {
> + if (!virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT)) {
Wait ... this does not only look like a clean-up, but also like a
bug-fix to me, since it should have been "(1 << VIRTIO_F_ANY_LAYOUT)"
instead of "VIRTIO_F_ANY_LAYOUT" in the original code instead?...
2014 Dec 11
3
[PATCH RFC v6 04/20] virtio: add feature checking helpers
...fb 100644
> --- a/hw/scsi/virtio-scsi.c
> +++ b/hw/scsi/virtio-scsi.c
> @@ -144,7 +144,7 @@ static int virtio_scsi_parse_req(VirtIOSCSIReq *req,
> *
> * TODO: always disable this workaround for virtio 1.0 devices.
> */
> - if ((vdev->guest_features & VIRTIO_F_ANY_LAYOUT) == 0) {
> + if (!virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT)) {
Wait ... this does not only look like a clean-up, but also like a
bug-fix to me, since it should have been "(1 << VIRTIO_F_ANY_LAYOUT)"
instead of "VIRTIO_F_ANY_LAYOUT" in the original code instead?...
2013 Jul 08
2
[PATCH] virtio-spec: add field for scsi command size
...sed simple layouts
>> > and devices came to rely on it, despite this specification
>> > wording. It is thus recommended that drivers be conservative in
>> > their assumptions, unless specific device features indicate that
>> > general layout is permitted using VIRTIO_F_ANY_LAYOUT. In
>> > addition, some implementations may have large-but-reasonable
>> > restrictions on total descriptor size (such as based on IOV_MAX
>> > in the host OS). This has not been a problem in practice: little
>> > sympathy will be given to drivers which create un...
2013 Jul 08
2
[PATCH] virtio-spec: add field for scsi command size
...sed simple layouts
>> > and devices came to rely on it, despite this specification
>> > wording. It is thus recommended that drivers be conservative in
>> > their assumptions, unless specific device features indicate that
>> > general layout is permitted using VIRTIO_F_ANY_LAYOUT. In
>> > addition, some implementations may have large-but-reasonable
>> > restrictions on total descriptor size (such as based on IOV_MAX
>> > in the host OS). This has not been a problem in practice: little
>> > sympathy will be given to drivers which create un...
2013 Jul 11
1
[PATCH] virtio-net: put virtio net header inline with data
...existing hypervisors require that header
> > is the first s/g element, we need a feature bit
> > for this.
> >
> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
> > ---
> >
> > Note: this needs to be applied on top of patch
> > defining VIRTIO_F_ANY_LAYOUT - bit to be
> > selected by Rusty.
> >
> > The following patch should work for any definition of
> > VIRTIO_F_ANY_LAYOUT - I used bit 31 for testing.
> > Rusty, could you please pick a valid bit for VIRTIO_F_ANY_LAYOUT
> > and squeeze this patch into 3.11?
>...
2013 Jul 11
1
[PATCH] virtio-net: put virtio net header inline with data
...existing hypervisors require that header
> > is the first s/g element, we need a feature bit
> > for this.
> >
> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
> > ---
> >
> > Note: this needs to be applied on top of patch
> > defining VIRTIO_F_ANY_LAYOUT - bit to be
> > selected by Rusty.
> >
> > The following patch should work for any definition of
> > VIRTIO_F_ANY_LAYOUT - I used bit 31 for testing.
> > Rusty, could you please pick a valid bit for VIRTIO_F_ANY_LAYOUT
> > and squeeze this patch into 3.11?
>...
2013 Jul 10
1
[PATCH] virtio-net: put virtio net header inline with data
...t s/g element, we need a feature bit
> >> > for this.
> >> >
> >> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
> >> > ---
> >> >
> >> > Note: this needs to be applied on top of patch
> >> > defining VIRTIO_F_ANY_LAYOUT - bit to be
> >> > selected by Rusty.
> >> >
> >> > The following patch should work for any definition of
> >> > VIRTIO_F_ANY_LAYOUT - I used bit 31 for testing.
> >> > Rusty, could you please pick a valid bit for VIRTIO_F_ANY_LAYOUT
>...
2013 Jul 10
1
[PATCH] virtio-net: put virtio net header inline with data
...t s/g element, we need a feature bit
> >> > for this.
> >> >
> >> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
> >> > ---
> >> >
> >> > Note: this needs to be applied on top of patch
> >> > defining VIRTIO_F_ANY_LAYOUT - bit to be
> >> > selected by Rusty.
> >> >
> >> > The following patch should work for any definition of
> >> > VIRTIO_F_ANY_LAYOUT - I used bit 31 for testing.
> >> > Rusty, could you please pick a valid bit for VIRTIO_F_ANY_LAYOUT
>...
2016 Nov 04
3
[PATCH] virtio-net: drop legacy features in virtio 1 mode
Virtio 1.0 spec says VIRTIO_F_ANY_LAYOUT and VIRTIO_NET_F_GSO are
legacy-only feature bits. Do not negotiate them in virtio 1 mode. Note
this is a spec violation so we need to backport it to stable/downstream
kernels.
Cc: stable at vger.kernel.org
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
drivers/net/virtio_net.c...
2016 Nov 04
3
[PATCH] virtio-net: drop legacy features in virtio 1 mode
Virtio 1.0 spec says VIRTIO_F_ANY_LAYOUT and VIRTIO_NET_F_GSO are
legacy-only feature bits. Do not negotiate them in virtio 1 mode. Note
this is a spec violation so we need to backport it to stable/downstream
kernels.
Cc: stable at vger.kernel.org
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
drivers/net/virtio_net.c...
2013 Jul 04
2
[PATCH] virtio-spec: add field for scsi command size
...still negotiated per device though.
> > virtio-scsi devices in QEMU would not negotiate that feature.
>
> That's a good point; I tend to think of them as tied to the transport
> but there's nothing specifying that, nor any implementation requiring
> it.
>
> OK, so VIRTIO_F_ANY_LAYOUT it is?
>
> Cheers,
> Rusty.
>
> Message Framing
>
> The original intent of the specification was that message framing
> (the particular layout of descriptors) be independent of the
> contents of the buffers. For example, a network transmit buffer
> consists of a...
2013 Jul 04
2
[PATCH] virtio-spec: add field for scsi command size
...still negotiated per device though.
> > virtio-scsi devices in QEMU would not negotiate that feature.
>
> That's a good point; I tend to think of them as tied to the transport
> but there's nothing specifying that, nor any implementation requiring
> it.
>
> OK, so VIRTIO_F_ANY_LAYOUT it is?
>
> Cheers,
> Rusty.
>
> Message Framing
>
> The original intent of the specification was that message framing
> (the particular layout of descriptors) be independent of the
> contents of the buffers. For example, a network transmit buffer
> consists of a...
2015 Jul 15
4
[PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1
...t/virtio_net.c b/drivers/net/virtio_net.c
index 63c7810..7fbca37 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1828,7 +1828,8 @@ static int virtnet_probe(struct virtio_device *vdev)
else
vi->hdr_len = sizeof(struct virtio_net_hdr);
- if (virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT))
+ if (virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT) ||
+ virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
vi->any_header_sg = true;
if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ))
--
MST
2015 Jul 15
4
[PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1
...t/virtio_net.c b/drivers/net/virtio_net.c
index 63c7810..7fbca37 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1828,7 +1828,8 @@ static int virtnet_probe(struct virtio_device *vdev)
else
vi->hdr_len = sizeof(struct virtio_net_hdr);
- if (virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT))
+ if (virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT) ||
+ virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
vi->any_header_sg = true;
if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ))
--
MST
2014 Dec 11
0
[PATCH RFC v6 04/20] virtio: add feature checking helpers
...irtio-scsi.c
> > +++ b/hw/scsi/virtio-scsi.c
> > @@ -144,7 +144,7 @@ static int virtio_scsi_parse_req(VirtIOSCSIReq *req,
> > *
> > * TODO: always disable this workaround for virtio 1.0 devices.
> > */
> > - if ((vdev->guest_features & VIRTIO_F_ANY_LAYOUT) == 0) {
> > + if (!virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT)) {
>
> Wait ... this does not only look like a clean-up, but also like a
> bug-fix to me, since it should have been "(1 << VIRTIO_F_ANY_LAYOUT)"
> instead of "VIRTIO_F_ANY_LAYOUT" in th...
2014 Dec 11
0
[PATCH RFC v6 04/20] virtio: add feature checking helpers
...irtio-scsi.c
> > +++ b/hw/scsi/virtio-scsi.c
> > @@ -144,7 +144,7 @@ static int virtio_scsi_parse_req(VirtIOSCSIReq *req,
> > *
> > * TODO: always disable this workaround for virtio 1.0 devices.
> > */
> > - if ((vdev->guest_features & VIRTIO_F_ANY_LAYOUT) == 0) {
> > + if (!virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT)) {
>
> Wait ... this does not only look like a clean-up, but also like a
> bug-fix to me, since it should have been "(1 << VIRTIO_F_ANY_LAYOUT)"
> instead of "VIRTIO_F_ANY_LAYOUT" in th...