search for: virtio_disable_cb

virtio_disable_cb is currently a nop for split ring with event index. This is because it used to be always called from a callback when we know device won't trigger more events until we update the index. However, now that we run with interrupts enabled a lot we also poll without a callback so that is different:...

...nce.com> wrote: > > > > > > > > > > > > > > > > From: "huangjie.albert" <huangjie.albert at bytedance.com> > > > > > > > > > > > > > > > > fix commit 8d622d21d248 ("virtio: fix up virtio_disable_cb") > > > > > > > > > > > > > > > > if we disable the napi_tx. when we triger a tx interrupt, the > > > > > > > > > > > > > > typo should be "trigger" > > > > > > > > >...

...> > > On Tue, Mar 21, 2023 at 5:00?PM Albert Huang > > <huangjie.albert at bytedance.com> wrote: > > > > > > From: "huangjie.albert" <huangjie.albert at bytedance.com> > > > > > > fix commit 8d622d21d248 ("virtio: fix up virtio_disable_cb") > > > > > > if we disable the napi_tx. when we triger a tx interrupt, the > > > > typo should be "trigger" > > > > OK, thanks for this. I will correct it in the next version > > > > vq->event_triggered will be set to true. It...

...not have to care about it returning false (recheck). Now that we actually disable the cb we have to do test the return value and do the actual recheck. Michael S. Tsirkin (4): virtio_net: move tx vq operation under tx queue lock virtio_net: move txq wakeups under tx q lock virtio: fix up virtio_disable_cb virtio_net: disable cb aggressively drivers/net/virtio_net.c | 49 ++++++++++++++++++++++++++++-------- drivers/virtio/virtio_ring.c | 26 ++++++++++++++++++- 2 files changed, 64 insertions(+), 11 deletions(-) -- MST

...not have to care about it returning false (recheck). Now that we actually disable the cb we have to do test the return value and do the actual recheck. Michael S. Tsirkin (4): virtio_net: move tx vq operation under tx queue lock virtio_net: move txq wakeups under tx q lock virtio: fix up virtio_disable_cb virtio_net: disable cb aggressively drivers/net/virtio_net.c | 49 ++++++++++++++++++++++++++++-------- drivers/virtio/virtio_ring.c | 26 ++++++++++++++++++- 2 files changed, 64 insertions(+), 11 deletions(-) -- MST

...: > iperf3 tcp stream: > vm1 -----------------> vm2 > vm2 just receives tcp data stream from vm1, and sends the ack to vm1, > there are many tx interrupts in vm2. > but without event_triggered there are just a few tx interrupts. > > Fixes: 8d622d21d248 ("virtio: fix up virtio_disable_cb") > Signed-off-by: Albert Huang <huangjie.albert at bytedance.com> > Message-Id: <20230321085953.24949-1-huangjie.albert at bytedance.com> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/virtio/virtio_ring.c | 6 ++++-- > 1 file chan...

...: > iperf3 tcp stream: > vm1 -----------------> vm2 > vm2 just receives tcp data stream from vm1, and sends the ack to vm1, > there are many tx interrupts in vm2. > but without event_triggered there are just a few tx interrupts. > > Fixes: 8d622d21d248 ("virtio: fix up virtio_disable_cb") > Signed-off-by: Albert Huang <huangjie.albert at bytedance.com> > Message-Id: <20230321085953.24949-1-huangjie.albert at bytedance.com> what is this exactly? > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/virtio/virtio_ring.c | 6...

On Tue, Mar 21, 2023 at 5:00?PM Albert Huang <huangjie.albert at bytedance.com> wrote: > > From: "huangjie.albert" <huangjie.albert at bytedance.com> > > fix commit 8d622d21d248 ("virtio: fix up virtio_disable_cb") > > if we disable the napi_tx. when we triger a tx interrupt, the typo should be "trigger" > vq->event_triggered will be set to true. It will no longer be > set to false. Unless we explicitly call virtqueue_enable_cb_delayed > or virtqueue_enable_cb_prepare >...