search for: virtio_crypto_ablkcipher_setkey

On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: > On Mon, Dec 12, 2016 at 06:25:12AM +0000, Gonglei (Arei) wrote: > > Hi, Michael & Herbert > > > > Because the virtio-crypto device emulation had been in QEMU 2.8, > > would you please merge the virtio-crypto driver for 4.10 if no other > > comments? If so, Miachel pls ack and/or review the patch,

On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: > On Mon, Dec 12, 2016 at 06:25:12AM +0000, Gonglei (Arei) wrote: > > Hi, Michael & Herbert > > > > Because the virtio-crypto device emulation had been in QEMU 2.8, > > would you please merge the virtio-crypto driver for 4.10 if no other > > comments? If so, Miachel pls ack and/or review the patch,

...t; > Objections to me merging this? I'm preparing my tree right now. Got this when testing the most recent version on s390x [ 20.391074] test 0 (128 bit key, 16 byte blocks): [ 20.391078] BUG: using smp_processor_id() in preemptible [00000000] code: insmod/97 [ 20.391082] caller is virtio_crypto_ablkcipher_setkey+0x44/0x198 [ 20.391085] CPU: 0 PID: 97 Comm: insmod Not tainted 4.9.0-02683-gb62a1ab #46 [ 20.391088] Hardware name: IBM 2964 NC9 704 (KVM) [ 20.391405] Stack: [ 20.391407] 000000000c0eb6d0 000000000c0eb760 0000000000000003 0000000000000000 [...

..._crypto_alg_skcipher_close_session(ctx, 1); return ret; } return 0; bad_key: - crypto_tfm_set_flags(ctx->tfm, CRYPTO_TFM_RES_BAD_KEY_LEN); + crypto_skcipher_set_flags(ctx->tfm, CRYPTO_TFM_RES_BAD_KEY_LEN); return -EINVAL; } /* Note: kernel crypto API realization */ -static int virtio_crypto_ablkcipher_setkey(struct crypto_ablkcipher *tfm, +static int virtio_crypto_skcipher_setkey(struct crypto_skcipher *tfm, const uint8_t *key, unsigned int keylen) { - struct virtio_crypto_ablkcipher_ctx *ctx = crypto_ablkcipher_ctx(tfm); + struct virtio_crypto_skcipher_ctx *ctx = crypto_skcipher_ctx(tfm...

..._crypto_alg_skcipher_close_session(ctx, 1); return ret; } return 0; bad_key: - crypto_tfm_set_flags(ctx->tfm, CRYPTO_TFM_RES_BAD_KEY_LEN); + crypto_skcipher_set_flags(ctx->tfm, CRYPTO_TFM_RES_BAD_KEY_LEN); return -EINVAL; } /* Note: kernel crypto API realization */ -static int virtio_crypto_ablkcipher_setkey(struct crypto_ablkcipher *tfm, +static int virtio_crypto_skcipher_setkey(struct crypto_skcipher *tfm, const uint8_t *key, unsigned int keylen) { - struct virtio_crypto_ablkcipher_ctx *ctx = crypto_ablkcipher_ctx(tfm); + struct virtio_crypto_skcipher_ctx *ctx = crypto_skcipher_ctx(tfm...

...upport for virtio crypto device. If you diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c index c2374df..970d0ca 100644 --- a/drivers/crypto/virtio/virtio_crypto_algs.c +++ b/drivers/crypto/virtio/virtio_crypto_algs.c @@ -288,8 +288,7 @@ static int virtio_crypto_ablkcipher_setkey(struct crypto_ablkcipher *tfm, static int __virtio_crypto_ablkcipher_do_req(struct virtio_crypto_request *vc_req, struct ablkcipher_request *req, - struct data_queue *data_vq, - __u8 op) + struct data_queue *data_vq) { struct crypto_ablkcipher *tfm = crypto_ablkcipher_reqtfm(req); unsi...

...upport for virtio crypto device. If you diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c index c2374df..970d0ca 100644 --- a/drivers/crypto/virtio/virtio_crypto_algs.c +++ b/drivers/crypto/virtio/virtio_crypto_algs.c @@ -288,8 +288,7 @@ static int virtio_crypto_ablkcipher_setkey(struct crypto_ablkcipher *tfm, static int __virtio_crypto_ablkcipher_do_req(struct virtio_crypto_request *vc_req, struct ablkcipher_request *req, - struct data_queue *data_vq, - __u8 op) + struct data_queue *data_vq) { struct crypto_ablkcipher *tfm = crypto_ablkcipher_reqtfm(req); unsi...

...crypto.ko for consistency. [Stefan] - don't call virtcrypto_dev_stop() on failure path. [Stefan] - don't add two empty lines. [Michael] - fix possible race by add spin_lock in virtio_crypto_alg_ablkcipher_init_session() [Michael and Halil] - drop virtcrypto_devmgr_get_first() calling in virtio_crypto_ablkcipher_setkey. [Michael] - drop superfluous assigned value for virtio_crypto_algs[i].cra_flags in virtio_crypto_algs_register(). [Stefan] - decrease virtio_crypto_active_devs if calling crypto_register_algs() failed. [Stefan] - fix some typos here and there. [Stefan] - fix missing table_lock usage in virt...

...crypto.ko for consistency. [Stefan] - don't call virtcrypto_dev_stop() on failure path. [Stefan] - don't add two empty lines. [Michael] - fix possible race by add spin_lock in virtio_crypto_alg_ablkcipher_init_session() [Michael and Halil] - drop virtcrypto_devmgr_get_first() calling in virtio_crypto_ablkcipher_setkey. [Michael] - drop superfluous assigned value for virtio_crypto_algs[i].cra_flags in virtio_crypto_algs_register(). [Stefan] - decrease virtio_crypto_active_devs if calling crypto_register_algs() failed. [Stefan] - fix some typos here and there. [Stefan] - fix missing table_lock usage in virt...

...crypto.ko for consistency. [Stefan] - don't call virtcrypto_dev_stop() on failure path. [Stefan] - don't add two empty lines. [Michael] - fix possible race by add spin_lock in virtio_crypto_alg_ablkcipher_init_session() [Michael and Halil] - drop virtcrypto_devmgr_get_first() calling in virtio_crypto_ablkcipher_setkey. [Michael] - drop superfluous assigned value for virtio_crypto_algs[i].cra_flags in virtio_crypto_algs_register(). [Stefan] - decrease virtio_crypto_active_devs if calling crypto_register_algs() failed. [Stefan] - fix some typos here and there. [Stefan] - fix missing table_lock usage in virt...

...crypto.ko for consistency. [Stefan] - don't call virtcrypto_dev_stop() on failure path. [Stefan] - don't add two empty lines. [Michael] - fix possible race by add spin_lock in virtio_crypto_alg_ablkcipher_init_session() [Michael and Halil] - drop virtcrypto_devmgr_get_first() calling in virtio_crypto_ablkcipher_setkey. [Michael] - drop superfluous assigned value for virtio_crypto_algs[i].cra_flags in virtio_crypto_algs_register(). [Stefan] - decrease virtio_crypto_active_devs if calling crypto_register_algs() failed. [Stefan] - fix some typos here and there. [Stefan] - fix missing table_lock usage in virt...

...crypto.ko for consistency. [Stefan] - don't call virtcrypto_dev_stop() on failure path. [Stefan] - don't add two empty lines. [Michael] - fix possible race by add spin_lock in virtio_crypto_alg_ablkcipher_init_session() [Michael and Halil] - drop virtcrypto_devmgr_get_first() calling in virtio_crypto_ablkcipher_setkey. [Michael] - drop superfluous assigned value for virtio_crypto_algs[i].cra_flags in virtio_crypto_algs_register(). [Stefan] - decrease virtio_crypto_active_devs if calling crypto_register_algs() failed. [Stefan] - fix some typos here and there. [Stefan] - fix missing table_lock usage in virt...

...crypto.ko for consistency. [Stefan] - don't call virtcrypto_dev_stop() on failure path. [Stefan] - don't add two empty lines. [Michael] - fix possible race by add spin_lock in virtio_crypto_alg_ablkcipher_init_session() [Michael and Halil] - drop virtcrypto_devmgr_get_first() calling in virtio_crypto_ablkcipher_setkey. [Michael] - drop superfluous assigned value for virtio_crypto_algs[i].cra_flags in virtio_crypto_algs_register(). [Stefan] - decrease virtio_crypto_active_devs if calling crypto_register_algs() failed. [Stefan] - fix some typos here and there. [Stefan] - fix missing table_lock usage in virt...

...crypto.ko for consistency. [Stefan] - don't call virtcrypto_dev_stop() on failure path. [Stefan] - don't add two empty lines. [Michael] - fix possible race by add spin_lock in virtio_crypto_alg_ablkcipher_init_session() [Michael and Halil] - drop virtcrypto_devmgr_get_first() calling in virtio_crypto_ablkcipher_setkey. [Michael] - drop superfluous assigned value for virtio_crypto_algs[i].cra_flags in virtio_crypto_algs_register(). [Stefan] - decrease virtio_crypto_active_devs if calling crypto_register_algs() failed. [Stefan] - fix some typos here and there. [Stefan] - fix missing table_lock usage in virt...

...crypto.ko for consistency. [Stefan] - don't call virtcrypto_dev_stop() on failure path. [Stefan] - don't add two empty lines. [Michael] - fix possible race by add spin_lock in virtio_crypto_alg_ablkcipher_init_session() [Michael and Halil] - drop virtcrypto_devmgr_get_first() calling in virtio_crypto_ablkcipher_setkey. [Michael] - drop superfluous assigned value for virtio_crypto_algs[i].cra_flags in virtio_crypto_algs_register(). [Stefan] - decrease virtio_crypto_active_devs if calling crypto_register_algs() failed. [Stefan] - fix some typos here and there. [Stefan] - fix missing table_lock usage in virt...

...crypto.ko for consistency. [Stefan] - don't call virtcrypto_dev_stop() on failure path. [Stefan] - don't add two empty lines. [Michael] - fix possible race by add spin_lock in virtio_crypto_alg_ablkcipher_init_session() [Michael and Halil] - drop virtcrypto_devmgr_get_first() calling in virtio_crypto_ablkcipher_setkey. [Michael] - drop superfluous assigned value for virtio_crypto_algs[i].cra_flags in virtio_crypto_algs_register(). [Stefan] - decrease virtio_crypto_active_devs if calling crypto_register_algs() failed. [Stefan] - fix some typos here and there. [Stefan] - fix missing table_lock usage in virt...

...crypto.ko for consistency. [Stefan] - don't call virtcrypto_dev_stop() on failure path. [Stefan] - don't add two empty lines. [Michael] - fix possible race by add spin_lock in virtio_crypto_alg_ablkcipher_init_session() [Michael and Halil] - drop virtcrypto_devmgr_get_first() calling in virtio_crypto_ablkcipher_setkey. [Michael] - drop superfluous assigned value for virtio_crypto_algs[i].cra_flags in virtio_crypto_algs_register(). [Stefan] - decrease virtio_crypto_active_devs if calling crypto_register_algs() failed. [Stefan] - fix some typos here and there. [Stefan] - fix missing table_lock usage in virt...

...gt; + virtio_crypto_alg_ablkcipher_close_session(ctx, 1); > + return ret; > + } > + return 0; > + > +bad_key: > + crypto_tfm_set_flags(ctx->tfm, CRYPTO_TFM_RES_BAD_KEY_LEN); > + return -EINVAL; > +} > + > +/* Note: kernel crypto API realization */ > +static int virtio_crypto_ablkcipher_setkey(struct crypto_ablkcipher *tfm, > + const uint8_t *key, > + unsigned int keylen) > +{ > + struct virtio_crypto_ablkcipher_ctx *ctx = crypto_ablkcipher_ctx(tfm); > + int ret; > + > + spin_lock(&ctx->lock); > + > + if (!ctx->vcrypto) { > + /* New key...

...gt; + virtio_crypto_alg_ablkcipher_close_session(ctx, 1); > + return ret; > + } > + return 0; > + > +bad_key: > + crypto_tfm_set_flags(ctx->tfm, CRYPTO_TFM_RES_BAD_KEY_LEN); > + return -EINVAL; > +} > + > +/* Note: kernel crypto API realization */ > +static int virtio_crypto_ablkcipher_setkey(struct crypto_ablkcipher *tfm, > + const uint8_t *key, > + unsigned int keylen) > +{ > + struct virtio_crypto_ablkcipher_ctx *ctx = crypto_ablkcipher_ctx(tfm); > + int ret; > + > + spin_lock(&ctx->lock); > + > + if (!ctx->vcrypto) { > + /* New key...

...gt; + virtio_crypto_alg_ablkcipher_close_session(ctx, 1); > + return ret; > + } > + return 0; > + > +bad_key: > + crypto_tfm_set_flags(ctx->tfm, CRYPTO_TFM_RES_BAD_KEY_LEN); > + return -EINVAL; > +} > + > +/* Note: kernel crypto API realization */ > +static int virtio_crypto_ablkcipher_setkey(struct crypto_ablkcipher *tfm, > + const uint8_t *key, > + unsigned int keylen) > +{ > + struct virtio_crypto_ablkcipher_ctx *ctx = crypto_ablkcipher_ctx(tfm); > + int ret; > + > + spin_lock(&ctx->lock); > + > + if (!ctx->vcrypto) { > + /* New key...