search for: virtio_cread

...90 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c @@ -1530,21 +1530,21 @@ static void virtio_mem_refresh_config(struct virtio_mem *vm) uint64_t new_plugged_size, usable_region_size, end_addr; /* the plugged_size is just a reflection of what _we_ did previously */ - virtio_cread(vm->vdev, struct virtio_mem_config, plugged_size, - &new_plugged_size); + virtio_cread_le(vm->vdev, struct virtio_mem_config, plugged_size, + &new_plugged_size); if (WARN_ON_ONCE(new_plugged_size != vm->plugged_size)) vm->plugged_size = new_plugged_size; /* calc...

...b/drivers/crypto/virtio/virtio_crypto_core.c index c8a962c62663..aeecce27fe8f 100644 --- a/drivers/crypto/virtio/virtio_crypto_core.c +++ b/drivers/crypto/virtio/virtio_crypto_core.c @@ -204,8 +204,8 @@ static int virtcrypto_update_status(struct virtio_crypto *vcrypto) u32 status; int err; - virtio_cread(vcrypto->vdev, - struct virtio_crypto_config, status, &status); + virtio_cread_le(vcrypto->vdev, + struct virtio_crypto_config, status, &status); /* * Unknown status bits would be a host error and the driver @@ -323,31 +323,31 @@ static int virtcrypto_probe(struct virtio_...

...dev at lists.oasis-open.org [mailto:virtio-dev at lists.oasis-open.org] > > On Behalf Of Michael S. Tsirkin > > Sent: Sunday, November 27, 2016 11:33 AM > > To: Gonglei (Arei) > > Subject: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian functions for > > virtio_cread/write# family > > > > On Tue, Nov 22, 2016 at 04:10:22PM +0800, Gonglei wrote: > > > Virtio modern devices are always little edian, let's introduce > > > the LE functions for read/write configuration space for > > > virtio modern devices, which avoid comp...

...dev at lists.oasis-open.org [mailto:virtio-dev at lists.oasis-open.org] > > On Behalf Of Michael S. Tsirkin > > Sent: Sunday, November 27, 2016 11:33 AM > > To: Gonglei (Arei) > > Subject: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian functions for > > virtio_cread/write# family > > > > On Tue, Nov 22, 2016 at 04:10:22PM +0800, Gonglei wrote: > > > Virtio modern devices are always little edian, let's introduce > > > the LE functions for read/write configuration space for > > > virtio modern devices, which avoid comp...

...are you kicking here? > > Hmm, it is pointless indeed. > > > > + if (select == VIRTIO_INPUT_CFG_EV_BITS) > > > + set_bit(subsel, vi->idev->evbit); > > > + for (bit = 0; bit < bitcount; bit++) { > > > + if ((bit % 8) == 0) > > > + virtio_cread(vi->vdev, struct virtio_input_config, > > > + u.bitmap[bit/8], &cfg); > > > > coding style violations above. you need spaces around ops like / and *. > > Please run checkpatch.pl > > > > > + if (cfg & (1 << (bit % 8))) > >...

...are you kicking here? > > Hmm, it is pointless indeed. > > > > + if (select == VIRTIO_INPUT_CFG_EV_BITS) > > > + set_bit(subsel, vi->idev->evbit); > > > + for (bit = 0; bit < bitcount; bit++) { > > > + if ((bit % 8) == 0) > > > + virtio_cread(vi->vdev, struct virtio_input_config, > > > + u.bitmap[bit/8], &cfg); > > > > coding style violations above. you need spaces around ops like / and *. > > Please run checkpatch.pl > > > > > + if (cfg & (1 << (bit % 8))) > >...

...tio_input.c +++ b/drivers/virtio/virtio_input.c @@ -113,9 +113,9 @@ static u8 virtinput_cfg_select(struct virtio_input *vi, { u8 size; - virtio_cwrite(vi->vdev, struct virtio_input_config, select, &select); - virtio_cwrite(vi->vdev, struct virtio_input_config, subsel, &subsel); - virtio_cread(vi->vdev, struct virtio_input_config, size, &size); + virtio_cwrite_le(vi->vdev, struct virtio_input_config, select, &select); + virtio_cwrite_le(vi->vdev, struct virtio_input_config, subsel, &subsel); + virtio_cread_le(vi->vdev, struct virtio_input_config, size, &size);...

...p it in a helper like virtio_input_bitmap_copy or > > virtio_bitmap_or. > > Can do that, sure. Well, the function where this is in already cares about the bitmap copy only. Can add a comment though. > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > virtio_cread will do byteswaps differently without VERSION_1. > > Just don't go there. > > Changed that for v2, for the config space structs. They have normal u32 > in there now. virtio_cread() wants it this way. I liked the __le32 in the config space structs more though, so I've wade...

...p it in a helper like virtio_input_bitmap_copy or > > virtio_bitmap_or. > > Can do that, sure. Well, the function where this is in already cares about the bitmap copy only. Can add a comment though. > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > virtio_cread will do byteswaps differently without VERSION_1. > > Just don't go there. > > Changed that for v2, for the config space structs. They have normal u32 > in there now. virtio_cread() wants it this way. I liked the __le32 in the config space structs more though, so I've wade...

...rg [mailto:virtio-dev at lists.oasis-open.org] > > > On Behalf Of Michael S. Tsirkin > > > Sent: Sunday, November 27, 2016 11:33 AM > > > To: Gonglei (Arei) > > > Subject: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian functions for > > > virtio_cread/write# family > > > > > > On Tue, Nov 22, 2016 at 04:10:22PM +0800, Gonglei wrote: > > > > Virtio modern devices are always little edian, let's introduce > > > > the LE functions for read/write configuration space for > > > > virtio modern...

...include/linux/virtio_config.h > index 26c155b..de05707 100644 > --- a/include/linux/virtio_config.h > +++ b/include/linux/virtio_config.h > @@ -414,4 +414,49 @@ static inline void virtio_cwrite64(struct virtio_device *vdev, > _r; \ > }) > > +static inline __le16 virtio_cread16_le(struct virtio_device *vdev, > + unsigned int offset) > +{ > + __le16 ret; > + > + vdev->config->get(vdev, offset, &ret, sizeof(ret)); > + return ret; > +} > + > +static inline void virtio_cwrite16_le(struct virtio_device *vdev, > + unsigned int...

...include/linux/virtio_config.h > index 26c155b..de05707 100644 > --- a/include/linux/virtio_config.h > +++ b/include/linux/virtio_config.h > @@ -414,4 +414,49 @@ static inline void virtio_cwrite64(struct virtio_device *vdev, > _r; \ > }) > > +static inline __le16 virtio_cread16_le(struct virtio_device *vdev, > + unsigned int offset) > +{ > + __le16 ret; > + > + vdev->config->get(vdev, offset, &ret, sizeof(ret)); > + return ret; > +} > + > +static inline void virtio_cwrite16_le(struct virtio_device *vdev, > + unsigned int...

...e----- > From: virtio-dev at lists.oasis-open.org [mailto:virtio-dev at lists.oasis-open.org] > On Behalf Of Michael S. Tsirkin > Sent: Sunday, November 27, 2016 11:33 AM > To: Gonglei (Arei) > Subject: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian functions for > virtio_cread/write# family > > On Tue, Nov 22, 2016 at 04:10:22PM +0800, Gonglei wrote: > > Virtio modern devices are always little edian, let's introduce > > the LE functions for read/write configuration space for > > virtio modern devices, which avoid complaint by Sparse when >...

...tus(vi, type, code, value); +} + +static size_t virtinput_cfg_select(struct virtio_input *vi, + u8 select, u8 subsel) +{ + u8 size; + + virtio_cwrite(vi->vdev, struct virtio_input_config, select, &select); + virtio_cwrite(vi->vdev, struct virtio_input_config, subsel, &subsel); + virtio_cread(vi->vdev, struct virtio_input_config, size, &size); + return size; +} + +static void virtinput_cfg_bits(struct virtio_input *vi, int select, int subsel, + unsigned long *bits, unsigned int bitcount) +{ + unsigned int bit; + size_t bytes; + u8 *virtio_bits; + + bytes = virtinput_cfg_...

...tus(vi, type, code, value); +} + +static size_t virtinput_cfg_select(struct virtio_input *vi, + u8 select, u8 subsel) +{ + u8 size; + + virtio_cwrite(vi->vdev, struct virtio_input_config, select, &select); + virtio_cwrite(vi->vdev, struct virtio_input_config, subsel, &subsel); + virtio_cread(vi->vdev, struct virtio_input_config, size, &size); + return size; +} + +static void virtinput_cfg_bits(struct virtio_input *vi, int select, int subsel, + unsigned long *bits, unsigned int bitcount) +{ + unsigned int bit; + size_t bytes; + u8 *virtio_bits; + + bytes = virtinput_cfg_...

...itops. > At least, this needs a comment explaining what the function does, > and maybe wrap it in a helper like virtio_input_bitmap_copy or > virtio_bitmap_or. Can do that, sure. > > > > + size = virtinput_cfg_select(vi, VIRTIO_INPUT_CFG_ABS_INFO, abs); > > > > + virtio_cread(vi->vdev, struct virtio_input_config, u.abs.min, &mi); > > > > + virtio_cread(vi->vdev, struct virtio_input_config, u.abs.max, &ma); > > > > + virtio_cread(vi->vdev, struct virtio_input_config, u.abs.fuzz, &fu); > > > > + virtio_cread(vi->...

...itops. > At least, this needs a comment explaining what the function does, > and maybe wrap it in a helper like virtio_input_bitmap_copy or > virtio_bitmap_or. Can do that, sure. > > > > + size = virtinput_cfg_select(vi, VIRTIO_INPUT_CFG_ABS_INFO, abs); > > > > + virtio_cread(vi->vdev, struct virtio_input_config, u.abs.min, &mi); > > > > + virtio_cread(vi->vdev, struct virtio_input_config, u.abs.max, &ma); > > > > + virtio_cread(vi->vdev, struct virtio_input_config, u.abs.fuzz, &fu); > > > > + virtio_cread(vi->...

...truct virtio_input *vi, > > + u8 select, u8 subsel) > > +{ > > + u8 size; > > + > > + virtio_cwrite(vi->vdev, struct virtio_input_config, select, &select); > > + virtio_cwrite(vi->vdev, struct virtio_input_config, subsel, &subsel); > > + virtio_cread(vi->vdev, struct virtio_input_config, size, &size); > > + return size; > > +} > > + > > +static void virtinput_cfg_bits(struct virtio_input *vi, int select, int subsel, > > + unsigned long *bits, unsigned int bitcount) > > +{ > > + unsigned...

...truct virtio_input *vi, > > + u8 select, u8 subsel) > > +{ > > + u8 size; > > + > > + virtio_cwrite(vi->vdev, struct virtio_input_config, select, &select); > > + virtio_cwrite(vi->vdev, struct virtio_input_config, subsel, &subsel); > > + virtio_cread(vi->vdev, struct virtio_input_config, size, &size); > > + return size; > > +} > > + > > +static void virtinput_cfg_bits(struct virtio_input *vi, int select, int subsel, > > + unsigned long *bits, unsigned int bitcount) > > +{ > > + unsigned...

On 2020/8/5 ??7:45, Michael S. Tsirkin wrote: >>> #define virtio_cread(vdev, structname, member, ptr) \ >>> do { \ >>> might_sleep(); \ >>> /* Must match the member's type, and be integer */ \ >>> - if (!typecheck(typeof((((structname*)0)->member)), *(ptr))) \ >>> + if (!__virtio_typeche...