search for: virtio_console_port_remov

Hello, This series reworks the ABI to allow port discovery (only) via the control queue and enable multiport again. In addition, it adds support for non-blocking write() support, which means no spinning. This works fine with the recent patches that are on qemu-devel. Also included is removal of hvc_remove() as removing one such console port causes other console ports (registered with hvc) to

Hello, This series reworks the ABI to allow port discovery (only) via the control queue and enable multiport again. In addition, it adds support for non-blocking write() support, which means no spinning. This works fine with the recent patches that are on qemu-devel. Also included is removal of hvc_remove() as removing one such console port causes other console ports (registered with hvc) to

...>dev, - "Error %d creating sysfs device attributes\n", - err); - } else { - /* - * Generate a udev event so that appropriate - * symlinks can be created based on udev - * rules. - */ - kobject_uevent(&port->dev->kobj, KOBJ_CHANGE); - } - break; - case VIRTIO_CONSOLE_PORT_REMOVE: - /* - * Hot unplug the port. We don't decrement nr_ports - * since we don't want to deal with extra complexities - * of using the lowest-available port id: We can just - * pick up the nr_ports number as the id and not have - * userspace send it to us. This helps us in two -...

...>dev, - "Error %d creating sysfs device attributes\n", - err); - } else { - /* - * Generate a udev event so that appropriate - * symlinks can be created based on udev - * rules. - */ - kobject_uevent(&port->dev->kobj, KOBJ_CHANGE); - } - break; - case VIRTIO_CONSOLE_PORT_REMOVE: - /* - * Hot unplug the port. We don't decrement nr_ports - * since we don't want to deal with extra complexities - * of using the lowest-available port id: We can just - * pick up the nr_ports number as the id and not have - * userspace send it to us. This helps us in two -...

...out Plain Layout +\change_deleted 0 1271400377 + #define VIRTIO_CONSOLE_PORT_OPEN 3 \end_layout \begin_layout Plain Layout +\change_deleted 0 1271400377 + #define VIRTIO_CONSOLE_PORT_NAME 4 \end_layout \begin_layout Plain Layout +\change_deleted 0 1271400377 + #define VIRTIO_CONSOLE_PORT_REMOVE 5 +\change_inserted 0 1271400378 + +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1271400814 + +#define VIRTIO_CONSOLE_DEVICE_READY 0 +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1271400820 + +#define VIRTIO_CONSOLE_PORT_ADD 1 +\end_layout + +...

...out Plain Layout +\change_deleted 0 1271400377 + #define VIRTIO_CONSOLE_PORT_OPEN 3 \end_layout \begin_layout Plain Layout +\change_deleted 0 1271400377 + #define VIRTIO_CONSOLE_PORT_NAME 4 \end_layout \begin_layout Plain Layout +\change_deleted 0 1271400377 + #define VIRTIO_CONSOLE_PORT_REMOVE 5 +\change_inserted 0 1271400378 + +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1271400814 + +#define VIRTIO_CONSOLE_DEVICE_READY 0 +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1271400820 + +#define VIRTIO_CONSOLE_PORT_ADD 1 +\end_layout + +...

...n", + "Request for adding port with " + "out-of-bound id %u, max. supported id: %u\n", cpkt->id, portdev->config.max_nr_ports - 1); break; } - add_port(portdev, cpkt->id); + add_port(portdev, virtio32_to_cpu(vdev, cpkt->id)); break; case VIRTIO_CONSOLE_PORT_REMOVE: unplug_port(port); @@ -1670,7 +1674,7 @@ static void handle_control_message(struct ports_device *portdev, break; } case VIRTIO_CONSOLE_PORT_OPEN: - port->host_connected = cpkt->value; + port->host_connected = virtio16_to_cpu(vdev, cpkt->value); wake_up_interruptible(&am...

...n", + "Request for adding port with " + "out-of-bound id %u, max. supported id: %u\n", cpkt->id, portdev->config.max_nr_ports - 1); break; } - add_port(portdev, cpkt->id); + add_port(portdev, virtio32_to_cpu(vdev, cpkt->id)); break; case VIRTIO_CONSOLE_PORT_REMOVE: unplug_port(port); @@ -1670,7 +1674,7 @@ static void handle_control_message(struct ports_device *portdev, break; } case VIRTIO_CONSOLE_PORT_OPEN: - port->host_connected = cpkt->value; + port->host_connected = virtio16_to_cpu(vdev, cpkt->value); wake_up_interruptible(&am...

Hello, This patchset is still based on Linus' tree but I'll rebase when Rusty sends out the disable multiport patches. This series reworks the ABI to allow port discovery (only) via the control queue. In addition, it adds support for non-blocking write() support, which means no spinning. This works fine with the recent patches that are on qemu-devel. Also included is removal of

Hello, This patchset is still based on Linus' tree but I'll rebase when Rusty sends out the disable multiport patches. This series reworks the ABI to allow port discovery (only) via the control queue. In addition, it adds support for non-blocking write() support, which means no spinning. This works fine with the recent patches that are on qemu-devel. Also included is removal of

Hello, These patches fix a couple of small issues: - generate a kobject change event so that udev is woken up on name changes - fix a crash after hot-unplug of the first console port and a subsequent config update But majorly, it reworks how ports are discovered: instead of numbering the ports individually in the host and the guest by just incrementing a number, we now switch to a

Hello, These patches fix a couple of small issues: - generate a kobject change event so that udev is woken up on name changes - fix a crash after hot-unplug of the first console port and a subsequent config update But majorly, it reworks how ports are discovered: instead of numbering the ports individually in the host and the guest by just incrementing a number, we now switch to a

...Plain Layout + +\change_inserted 0 1263991870 + +#define VIRTIO_CONSOLE_PORT_OPEN 3 +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1263991870 + +#define VIRTIO_CONSOLE_PORT_NAME 4 +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1263991870 + +#define VIRTIO_CONSOLE_PORT_REMOVE 5 +\change_unchanged + +\end_layout + +\end_inset + + \end_layout \begin_layout Chapter*

...Plain Layout + +\change_inserted 0 1263991870 + +#define VIRTIO_CONSOLE_PORT_OPEN 3 +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1263991870 + +#define VIRTIO_CONSOLE_PORT_NAME 4 +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1263991870 + +#define VIRTIO_CONSOLE_PORT_REMOVE 5 +\change_unchanged + +\end_layout + +\end_inset + + \end_layout \begin_layout Chapter*

Hey Rusty, These are the patches that rework a few bits to make hot-unplug while ports are open not crash apps (or kernels). The problem is when hot-unplug is performed when a port is open, the cdev struct is kept around by the file pointers and when the app later does a 'close', things go boom-boom. This patch series makes sure port as well as device hot-unplug is now safe to perform

Hey Rusty, These are the patches that rework a few bits to make hot-unplug while ports are open not crash apps (or kernels). The problem is when hot-unplug is performed when a port is open, the cdev struct is kept around by the file pointers and when the app later does a 'close', things go boom-boom. This patch series makes sure port as well as device hot-unplug is now safe to perform