search for: virtio_console_device_ready

Hello, This patchset is still based on Linus' tree but I'll rebase when Rusty sends out the disable multiport patches. This series reworks the ABI to allow port discovery (only) via the control queue. In addition, it adds support for non-blocking write() support, which means no spinning. This works fine with the recent patches that are on qemu-devel. Also included is removal of

Hello, This patchset is still based on Linus' tree but I'll rebase when Rusty sends out the disable multiport patches. This series reworks the ABI to allow port discovery (only) via the control queue. In addition, it adds support for non-blocking write() support, which means no spinning. This works fine with the recent patches that are on qemu-devel. Also included is removal of

...if (!nr_added_bufs) { + err = fill_queue(portdev->c_ivq, &portdev->c_ivq_lock); + if (err < 0) { dev_err(&vdev->dev, "Error allocating buffers for control queue\n"); /* @@ -2077,7 +2071,7 @@ static int virtcons_probe(struct virtio_device *vdev) VIRTIO_CONSOLE_DEVICE_READY, 0); /* Device was functional: we need full cleanup. */ virtcons_remove(vdev); - return -ENOMEM; + return err; } } else { /* -- 2.23.0

...if (!nr_added_bufs) { + err = fill_queue(portdev->c_ivq, &portdev->c_ivq_lock); + if (err < 0) { dev_err(&vdev->dev, "Error allocating buffers for control queue\n"); /* @@ -2077,7 +2071,7 @@ static int virtcons_probe(struct virtio_device *vdev) VIRTIO_CONSOLE_DEVICE_READY, 0); /* Device was functional: we need full cleanup. */ virtcons_remove(vdev); - return -ENOMEM; + return err; } } else { /* -- 2.23.0

...if (!nr_added_bufs) { + err = fill_queue(portdev->c_ivq, &portdev->c_ivq_lock); + if (err < 0) { dev_err(&vdev->dev, "Error allocating buffers for control queue\n"); /* @@ -2077,7 +2075,7 @@ static int virtcons_probe(struct virtio_device *vdev) VIRTIO_CONSOLE_DEVICE_READY, 0); /* Device was functional: we need full cleanup. */ virtcons_remove(vdev); - return -ENOMEM; + return err; } } else { /* -- 2.23.0

...if (!nr_added_bufs) { + err = fill_queue(portdev->c_ivq, &portdev->c_ivq_lock); + if (err < 0) { dev_err(&vdev->dev, "Error allocating buffers for control queue\n"); /* @@ -2077,7 +2075,7 @@ static int virtcons_probe(struct virtio_device *vdev) VIRTIO_CONSOLE_DEVICE_READY, 0); /* Device was functional: we need full cleanup. */ virtcons_remove(vdev); - return -ENOMEM; + return err; } } else { /* -- 2.23.0

Hello, This series reworks the ABI to allow port discovery (only) via the control queue and enable multiport again. In addition, it adds support for non-blocking write() support, which means no spinning. This works fine with the recent patches that are on qemu-devel. Also included is removal of hvc_remove() as removing one such console port causes other console ports (registered with hvc) to

Hello, This series reworks the ABI to allow port discovery (only) via the control queue and enable multiport again. In addition, it adds support for non-blocking write() support, which means no spinning. This works fine with the recent patches that are on qemu-devel. Also included is removal of hvc_remove() as removing one such console port causes other console ports (registered with hvc) to

...v, 0); } - /* - * For backward compatibility: if we're running on an older - * host, we always want to create a console port. - */ - add_port(portdev, 0); - - /* Start using the new console output. */ - early_put_chars = NULL; - __send_control_msg(portdev, VIRTIO_CONSOLE_BAD_ID, VIRTIO_CONSOLE_DEVICE_READY, 1); return 0; -- 1.6.2.5

...v, 0); } - /* - * For backward compatibility: if we're running on an older - * host, we always want to create a console port. - */ - add_port(portdev, 0); - - /* Start using the new console output. */ - early_put_chars = NULL; - __send_control_msg(portdev, VIRTIO_CONSOLE_BAD_ID, VIRTIO_CONSOLE_DEVICE_READY, 1); return 0; -- 1.6.2.5

...= fill_queue(portdev->c_ivq, &portdev->c_ivq_lock); > + if (err < 0) { > dev_err(&vdev->dev, > "Error allocating buffers for control queue\n"); > /* > @@ -2077,7 +2071,7 @@ static int virtcons_probe(struct virtio_device *vdev) > VIRTIO_CONSOLE_DEVICE_READY, 0); > /* Device was functional: we need full cleanup. */ > virtcons_remove(vdev); > - return -ENOMEM; > + return err; > } > } else { > /* > -- > 2.23.0

...ue(portdev->c_ivq, &portdev->c_ivq_lock); > + if (err < 0) { > dev_err(&vdev->dev, > "Error allocating buffers for control > queue\n"); > /* > @@ -2077,7 +2075,7 @@ static int virtcons_probe(struct virtio_device > *vdev) > VIRTIO_CONSOLE_DEVICE_READY, > 0); > /* Device was functional: we need full cleanup. > */ > virtcons_remove(vdev); > - return -ENOMEM; > + return err; > } > } else { > /*

...d 0 1271400377 + #define VIRTIO_CONSOLE_PORT_NAME 4 \end_layout \begin_layout Plain Layout +\change_deleted 0 1271400377 + #define VIRTIO_CONSOLE_PORT_REMOVE 5 +\change_inserted 0 1271400378 + +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1271400814 + +#define VIRTIO_CONSOLE_DEVICE_READY 0 +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1271400820 + +#define VIRTIO_CONSOLE_PORT_ADD 1 +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1271400823 + +#define VIRTIO_CONSOLE_PORT_REMOVE 2 +\end_layout + +\begin_layout Plain Layout + +\chan...

...d 0 1271400377 + #define VIRTIO_CONSOLE_PORT_NAME 4 \end_layout \begin_layout Plain Layout +\change_deleted 0 1271400377 + #define VIRTIO_CONSOLE_PORT_REMOVE 5 +\change_inserted 0 1271400378 + +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1271400814 + +#define VIRTIO_CONSOLE_DEVICE_READY 0 +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1271400820 + +#define VIRTIO_CONSOLE_PORT_ADD 1 +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1271400823 + +#define VIRTIO_CONSOLE_PORT_REMOVE 2 +\end_layout + +\begin_layout Plain Layout + +\chan...

..._ivq_lock); > > + if (err < 0) { > > dev_err(&vdev->dev, > > "Error allocating buffers for control > > queue\n"); > > /* > > @@ -2077,7 +2075,7 @@ static int virtcons_probe(struct virtio_device > > *vdev) > > VIRTIO_CONSOLE_DEVICE_READY, > > 0); > > /* Device was functional: we need full cleanup. > > */ > > virtcons_remove(vdev); > > - return -ENOMEM; > > + return err; > > } > > } else { > > /*

Turns out virtio console tries to take a buffer out of an active vq. Works by sheer luck, and is explicitly forbidden by spec. And while going over it I saw that error handling is also broken - failure is easy to trigger if I force allocations to fail. Lightly tested. Michael S. Tsirkin (6): virtio_console: don't tie bufs to a vq virtio: add ability to iterate over vqs virtio_console:

Turns out virtio console tries to take a buffer out of an active vq. Works by sheer luck, and is explicitly forbidden by spec. And while going over it I saw that error handling is also broken - failure is easy to trigger if I force allocations to fail. Lightly tested. Michael S. Tsirkin (6): virtio_console: don't tie bufs to a vq virtio: add ability to iterate over vqs virtio_console:

..., &portdev->c_ivq_lock); > > + if (err < 0) { > > dev_err(&vdev->dev, > > "Error allocating buffers for control queue\n"); > > /* > > @@ -2077,7 +2071,7 @@ static int virtcons_probe(struct virtio_device *vdev) > > VIRTIO_CONSOLE_DEVICE_READY, 0); > > /* Device was functional: we need full cleanup. */ > > virtcons_remove(vdev); > > - return -ENOMEM; > > + return err; > > } > > } else { > > /* > > -- > > 2.23.0

..., &portdev->c_ivq_lock); > > + if (err < 0) { > > dev_err(&vdev->dev, > > "Error allocating buffers for control queue\n"); > > /* > > @@ -2077,7 +2071,7 @@ static int virtcons_probe(struct virtio_device *vdev) > > VIRTIO_CONSOLE_DEVICE_READY, 0); > > /* Device was functional: we need full cleanup. */ > > virtcons_remove(vdev); > > - return -ENOMEM; > > + return err; > > } > > } else { > > /* > > -- > > 2.23.0

Hey Rusty, These are the patches that rework a few bits to make hot-unplug while ports are open not crash apps (or kernels). The problem is when hot-unplug is performed when a port is open, the cdev struct is kept around by the file pointers and when the app later does a 'close', things go boom-boom. This patch series makes sure port as well as device hot-unplug is now safe to perform