search for: virtio_config_s_needs_reset

On Fri, Oct 13, 2017 at 11:51:40AM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn <willemb at google.com> > > Implement the reset communication request defined in the VIRTIO 1.0 > specification and introduces in Linux in commit c00bbcf862896 ("virtio: > add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). > > Use the virtnet_reset function introduced in commit 2de2f7f40ef9 > ("virtio_net: XDP support for adjust_head"). That was removed in > commit 4941d472bf95 ("virtio-net: do not reset during XDP set"), > because no longer used. Bring it...

...9, 2017 at 04:07:58PM -0400, Willem de Bruijn wrote: >> From: Willem de Bruijn <willemb at google.com> >> >> Implement the reset communication request defined in the VIRTIO 1.0 >> specification and introduces in Linux in commit c00bbcf862896 ("virtio: >> add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). >> >> Since that patch, the virtio-net driver has added a virtnet_reset >> function that implements the requested behavior through calls to the >> power management freeze and restore functions. >> >> That function has recently been rever...

...9, 2017 at 04:07:58PM -0400, Willem de Bruijn wrote: >> From: Willem de Bruijn <willemb at google.com> >> >> Implement the reset communication request defined in the VIRTIO 1.0 >> specification and introduces in Linux in commit c00bbcf862896 ("virtio: >> add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). >> >> Since that patch, the virtio-net driver has added a virtnet_reset >> function that implements the requested behavior through calls to the >> power management freeze and restore functions. >> >> That function has recently been rever...

From: Willem de Bruijn <willemb at google.com> Implement the reset communication request defined in the VIRTIO 1.0 specification and introduces in Linux in commit c00bbcf862896 ("virtio: add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). Use the virtnet_reset function introduced in commit 2de2f7f40ef9 ("virtio_net: XDP support for adjust_head"). That was removed in commit 4941d472bf95 ("virtio-net: do not reset during XDP set"), because no longer used. Bring it back, minus the xdp spec...

From: Willem de Bruijn <willemb at google.com> Implement the reset communication request defined in the VIRTIO 1.0 specification and introduces in Linux in commit c00bbcf862896 ("virtio: add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). Use the virtnet_reset function introduced in commit 2de2f7f40ef9 ("virtio_net: XDP support for adjust_head"). That was removed in commit 4941d472bf95 ("virtio-net: do not reset during XDP set"), because no longer used. Bring it back, minus the xdp spec...

On 20/04/2015 19:36, Michael S. Tsirkin wrote: > At the implementation level, there's one big issue you seem to have > missed: DMA to invalid memory addresses causes a crash in memory core. > I'm not sure whether it makes sense to recover from virtio core bugs > when we can't recover from device bugs. What do you mean exactly? DMA to invalid memory addresses causes

On 20/04/2015 22:34, Michael S. Tsirkin wrote: > On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: >> >> >> On 20/04/2015 19:36, Michael S. Tsirkin wrote: >>> At the implementation level, there's one big issue you seem to have >>> missed: DMA to invalid memory addresses causes a crash in memory core. >>> I'm not sure whether it

On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: > >> +static int virtnet_reset(struct virtnet_info *vi) > >> +{ > >> + struct virtio_device *dev = vi->vdev; > >> + int ret; > >> + > >> + virtio_config_disable(dev); > >> + dev->failed = dev->config->get_status(dev) &

On 2017?10?17? 06:34, Willem de Bruijn wrote: > On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin <mst at redhat.com> wrote: >> On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de Bruijn wrote: >>> On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: >>>> On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote:

On Mon, 04/20 19:36, Michael S. Tsirkin wrote: > On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: > > Currently, virtio code chooses to kill QEMU if the guest passes any invalid > > data with vring. > > That has drawbacks such as losing unsaved data (e.g. when > > guest user is writing a very long email), or possible denial of service in > > a nested vm

On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de Bruijn wrote: > On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: > >> >> +static int virtnet_reset(struct virtnet_info *vi) > >> >> +{ > >> >> + struct virtio_device *dev =

On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: > > > On 20/04/2015 19:36, Michael S. Tsirkin wrote: > > At the implementation level, there's one big issue you seem to have > > missed: DMA to invalid memory addresses causes a crash in memory core. > > I'm not sure whether it makes sense to recover from virtio core bugs > > when we can't

On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: > > > On 20/04/2015 19:36, Michael S. Tsirkin wrote: > > At the implementation level, there's one big issue you seem to have > > missed: DMA to invalid memory addresses causes a crash in memory core. > > I'm not sure whether it makes sense to recover from virtio core bugs > > when we can't

On Mon, Oct 16, 2017 at 11:44 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Tue, Oct 17, 2017 at 11:05:07AM +0800, Jason Wang wrote: >> >> >> On 2017?10?17? 06:34, Willem de Bruijn wrote: >> > On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin <mst at redhat.com> wrote: >> > > On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de

On Tue, 04/21 07:22, Michael S. Tsirkin wrote: > On Tue, Apr 21, 2015 at 10:37:00AM +0800, Fam Zheng wrote: > > On Mon, 04/20 19:36, Michael S. Tsirkin wrote: > > > On Fri, Apr 17, 2015 at 03:59:15PM +0800, Fam Zheng wrote: > > > > Currently, virtio code chooses to kill QEMU if the guest passes any invalid > > > > data with vring. > > > > That

>> +static int virtnet_reset(struct virtnet_info *vi) >> +{ >> + struct virtio_device *dev = vi->vdev; >> + int ret; >> + >> + virtio_config_disable(dev); >> + dev->failed = dev->config->get_status(dev) & VIRTIO_CONFIG_S_FAILED; >> + virtnet_freeze_down(dev, true); >> + remove_vq_common(vi); >> +

>> +static int virtnet_reset(struct virtnet_info *vi) >> +{ >> + struct virtio_device *dev = vi->vdev; >> + int ret; >> + >> + virtio_config_disable(dev); >> + dev->failed = dev->config->get_status(dev) & VIRTIO_CONFIG_S_FAILED; >> + virtnet_freeze_down(dev, true); >> + remove_vq_common(vi); >> +

On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: >> >> +static int virtnet_reset(struct virtnet_info *vi) >> >> +{ >> >> + struct virtio_device *dev = vi->vdev; >> >> + int ret; >> >> + >> >> +

On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: >> >> +static int virtnet_reset(struct virtnet_info *vi) >> >> +{ >> >> + struct virtio_device *dev = vi->vdev; >> >> + int ret; >> >> + >> >> +

On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Mon, Oct 16, 2017 at 12:04:57PM -0400, Willem de Bruijn wrote: >> On Mon, Oct 16, 2017 at 11:31 AM, Michael S. Tsirkin <mst at redhat.com> wrote: >> > On Mon, Oct 16, 2017 at 11:03:18AM -0400, Willem de Bruijn wrote: >> >> >> +static int virtnet_reset(struct