search for: virtio_config_op

On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: > From: Bhumika Goyal <bhumirks at gmail.com> > > Declare virtio_config_ops structure as const as it is only stored in the > config field of a virtio_device structure. This field is of type const, so > virtio_config_ops structures having this property can be declared const. > Done using Coccinelle: > > @r1 disable optional_qualifier@ > identifier i; &gt...

On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: > From: Bhumika Goyal <bhumirks at gmail.com> > > Declare virtio_config_ops structure as const as it is only stored in the > config field of a virtio_device structure. This field is of type const, so > virtio_config_ops structures having this property can be declared const. > Done using Coccinelle: > > @r1 disable optional_qualifier@ > identifier i; &gt...

Declare virtio_config_ops structure as const as it is only stored in the config field of a virtio_device structure. This field is of type const, so virtio_config_ops structures having this property can be declared const. Done using Coccinelle: @r1 disable optional_qualifier@ identifier i; position p; @@ static struct virt...

Declare virtio_config_ops structure as const as it is only stored in the config field of a virtio_device structure. This field is of type const, so virtio_config_ops structures having this property can be declared const. Done using Coccinelle: @r1 disable optional_qualifier@ identifier i; position p; @@ static struct virt...

...:58:34PM +0530, Bhumika Goyal wrote: > On Mon, Jan 16, 2017 at 7:59 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: > >> From: Bhumika Goyal <bhumirks at gmail.com> > >> > >> Declare virtio_config_ops structure as const as it is only stored in the > >> config field of a virtio_device structure. This field is of type const, so > >> virtio_config_ops structures having this property can be declared const. > >> Done using Coccinelle: > >> > >> @r1 disabl...

...:58:34PM +0530, Bhumika Goyal wrote: > On Mon, Jan 16, 2017 at 7:59 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: > >> From: Bhumika Goyal <bhumirks at gmail.com> > >> > >> Declare virtio_config_ops structure as const as it is only stored in the > >> config field of a virtio_device structure. This field is of type const, so > >> virtio_config_ops structures having this property can be declared const. > >> Done using Coccinelle: > >> > >> @r1 disabl...

From: Bhumika Goyal <bhumirks at gmail.com> Declare virtio_config_ops structure as const as it is only stored in the config field of a virtio_device structure. This field is of type const, so virtio_config_ops structures having this property can be declared const. Done using Coccinelle: @r1 disable optional_qualifier@ identifier i; position p; @@ static struct virt...

On Mon, Jan 16, 2017 at 7:59 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: >> From: Bhumika Goyal <bhumirks at gmail.com> >> >> Declare virtio_config_ops structure as const as it is only stored in the >> config field of a virtio_device structure. This field is of type const, so >> virtio_config_ops structures having this property can be declared const. >> Done using Coccinelle: >> >> @r1 disable optional_qualifier@ &gt...

From: Rick Jones <rick.jones2 at hp.com> Add a new .bus_name to virtio_config_ops then modify virtio_net to call through to it in an ethtool .get_drvinfo routine to report bus_info in ethtool -i output which is consistent with other emulated NICs and the output of lspci. Signed-off-by: Rick Jones <rick.jones2 at hp.com> --- The changes to drivers/lguest/lguest_devic...

From: Rick Jones <rick.jones2 at hp.com> Add a new .bus_name to virtio_config_ops then modify virtio_net to call through to it in an ethtool .get_drvinfo routine to report bus_info in ethtool -i output which is consistent with other emulated NICs and the output of lspci. Signed-off-by: Rick Jones <rick.jones2 at hp.com> --- The changes to drivers/lguest/lguest_devic...

From: Rick Jones <rick.jones2 at hp.com> Add a new .bus_name to virtio_config_ops then modify virtio_net to call through to it in an ethtool .get_drvinfo routine to report bus_info in ethtool -i output which is consistent with other emulated NICs and the output of lspci. Signed-off-by: Rick Jones <rick.jones2 at hp.com> --- The changes to drivers/lguest/lguest_devic...

From: Rick Jones <rick.jones2 at hp.com> Add a new .bus_name to virtio_config_ops then modify virtio_net to call through to it in an ethtool .get_drvinfo routine to report bus_info in ethtool -i output which is consistent with other emulated NICs and the output of lspci. Signed-off-by: Rick Jones <rick.jones2 at hp.com> --- The changes to drivers/lguest/lguest_devic...

...-D__CHECK_ENDIAN__ from cflags (2016-12-16 00:13:43 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git tags/virtio-s390-20170116 for you to fetch changes up to 364cf19a474501cf157f1d09895ebab71e603c77: virtio/s390: virtio: constify virtio_config_ops structures (2017-01-16 12:26:07 +0100) ---------------------------------------------------------------- - ringtest fixes to make it work on s390 - support new READ_STATUS command - minor cleanups ---------------------------------------------------------------- Bhumika Goyal (1): virtio/s390:...

...-D__CHECK_ENDIAN__ from cflags (2016-12-16 00:13:43 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git tags/virtio-s390-20170116 for you to fetch changes up to 364cf19a474501cf157f1d09895ebab71e603c77: virtio/s390: virtio: constify virtio_config_ops structures (2017-01-16 12:26:07 +0100) ---------------------------------------------------------------- - ringtest fixes to make it work on s390 - support new READ_STATUS command - minor cleanups ---------------------------------------------------------------- Bhumika Goyal (1): virtio/s390:...

...it became clear that it is not obvious that some of the virtio operations (e.g. reading or writing the config space) cannot be done from an atomic context for all transports. At least try to document that, and also fix some inconsistencies I noticed along the way. Cornelia Huck (2): virtio: fix virtio_config_ops description virtio: document virtio_config_ops restrictions include/linux/virtio_config.h | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) -- 2.17.2

...it became clear that it is not obvious that some of the virtio operations (e.g. reading or writing the config space) cannot be done from an atomic context for all transports. At least try to document that, and also fix some inconsistencies I noticed along the way. Cornelia Huck (2): virtio: fix virtio_config_ops description virtio: document virtio_config_ops restrictions include/linux/virtio_config.h | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) -- 2.17.2

...5 insertions(+) > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h > index 7087ef946ba7..987b6491b946 100644 > --- a/include/linux/virtio_config.h > +++ b/include/linux/virtio_config.h > @@ -12,6 +12,11 @@ struct irq_affinity; > > /** > * virtio_config_ops - operations for configuring a virtio device > + * Note: Do not assume that a transport implements all of the operations > + * getting/setting a value as a simple read/write! Generally speaking, > + * any of @get/@set, @get_status/@set_status, or @get_features/ > + *...

...x/virtio_config.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h index 7087ef946ba7..987b6491b946 100644 --- a/include/linux/virtio_config.h +++ b/include/linux/virtio_config.h @@ -12,6 +12,11 @@ struct irq_affinity; /** * virtio_config_ops - operations for configuring a virtio device + * Note: Do not assume that a transport implements all of the operations + * getting/setting a value as a simple read/write! Generally speaking, + * any of @get/@set, @get_status/@set_status, or @get_features/ + * @finalize_features a...

...it a/include/linux/virtio_config.h b/include/linux/virtio_config.h > > index 7087ef946ba7..987b6491b946 100644 > > --- a/include/linux/virtio_config.h > > +++ b/include/linux/virtio_config.h > > @@ -12,6 +12,11 @@ struct irq_affinity; > > > > /** > > * virtio_config_ops - operations for configuring a virtio device > > + * Note: Do not assume that a transport implements all of the operations > > + * getting/setting a value as a simple read/write! Generally speaking, > > + * any of @get/@set, @get_status/@set_status, or @get_features/...

...); void virtio_pci_legacy_remove(struct virtio_pci_device *); diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index 2ab6aee..f7362c5 100644 --- a/drivers/virtio/virtio_pci_legacy.c +++ b/drivers/virtio/virtio_pci_legacy.c @@ -190,6 +190,7 @@ static const struct virtio_config_ops virtio_pci_config_ops = { .finalize_features = vp_finalize_features, .bus_name = vp_bus_name, .set_vq_affinity = vp_set_vq_affinity, + .get_vq_affinity = vp_get_vq_affinity, }; /* the PCI probing function */ diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_mode...