Displaying 20 results from an estimated 20 matches for "virtio_ccw_handle_set_vq".
2015 Jan 20
2
[PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call
...+ if (!ccw.cda) {
> + ret = -EFAULT;
> + break;
> + }
> + cpu_physical_memory_read(ccw.cda, &revinfo, len);
> + if (dev->revision >= 0 ||
> + revinfo.revision > virtio_ccw_rev_max(dev)) {
In the next patch virtio_ccw_handle_set_vq() uses big-endian memory
access functions to load a struct from guest memory.
Here you just copy the struct in without byteswaps.
Are the byteswaps missing here? (I guess this normally runs big-endian
guests on big-endian hosts so it's not noticable.)
Stefan
-------------- next part -------...
2015 Jan 20
2
[PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call
...+ if (!ccw.cda) {
> + ret = -EFAULT;
> + break;
> + }
> + cpu_physical_memory_read(ccw.cda, &revinfo, len);
> + if (dev->revision >= 0 ||
> + revinfo.revision > virtio_ccw_rev_max(dev)) {
In the next patch virtio_ccw_handle_set_vq() uses big-endian memory
access functions to load a struct from guest memory.
Here you just copy the struct in without byteswaps.
Are the byteswaps missing here? (I guess this normally runs big-endian
guests on big-endian hosts so it's not noticable.)
Stefan
-------------- next part -------...
2015 Jan 21
1
[Qemu-devel] [PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call
...gt; + break;
> > > + }
> > > + cpu_physical_memory_read(ccw.cda, &revinfo, len);
> > > + if (dev->revision >= 0 ||
> > > + revinfo.revision > virtio_ccw_rev_max(dev)) {
> >
> > In the next patch virtio_ccw_handle_set_vq() uses big-endian memory
> > access functions to load a struct from guest memory.
> >
> > Here you just copy the struct in without byteswaps.
> >
> > Are the byteswaps missing here? (I guess this normally runs big-endian
> > guests on big-endian hosts so it...
2015 Jan 21
1
[Qemu-devel] [PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call
...gt; + break;
> > > + }
> > > + cpu_physical_memory_read(ccw.cda, &revinfo, len);
> > > + if (dev->revision >= 0 ||
> > > + revinfo.revision > virtio_ccw_rev_max(dev)) {
> >
> > In the next patch virtio_ccw_handle_set_vq() uses big-endian memory
> > access functions to load a struct from guest memory.
> >
> > Here you just copy the struct in without byteswaps.
> >
> > Are the byteswaps missing here? (I guess this normally runs big-endian
> > guests on big-endian hosts so it...
2014 Dec 11
0
[PATCH RFC v6 11/20] s390x/virtio-ccw: support virtio-1 set_vq format
...virtio_queue_set_vector(vdev, index, 0);
} else {
/* Fail if we don't have a big enough queue. */
@@ -303,10 +319,66 @@ static int virtio_ccw_set_vqs(SubchDev *sch, uint64_t addr, uint32_t align,
return 0;
}
-static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
+static int virtio_ccw_handle_set_vq(SubchDev *sch, CCW1 ccw, bool check_len,
+ bool is_legacy)
{
int ret;
VqInfoBlock info;
+ VqInfoBlockLegacy linfo;
+ size_t info_len = is_legacy ? sizeof(linfo) : sizeof(info);
+
+ if (check_len) {
+ if (ccw.count != info_len) {
+...
2014 Dec 11
0
[PATCH RFC v6 11/20] s390x/virtio-ccw: support virtio-1 set_vq format
...virtio_queue_set_vector(vdev, index, 0);
} else {
/* Fail if we don't have a big enough queue. */
@@ -303,10 +319,66 @@ static int virtio_ccw_set_vqs(SubchDev *sch, uint64_t addr, uint32_t align,
return 0;
}
-static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
+static int virtio_ccw_handle_set_vq(SubchDev *sch, CCW1 ccw, bool check_len,
+ bool is_legacy)
{
int ret;
VqInfoBlock info;
+ VqInfoBlockLegacy linfo;
+ size_t info_len = is_legacy ? sizeof(linfo) : sizeof(info);
+
+ if (check_len) {
+ if (ccw.count != info_len) {
+...
2015 Jan 21
0
[PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call
...ret = -EFAULT;
> > + break;
> > + }
> > + cpu_physical_memory_read(ccw.cda, &revinfo, len);
> > + if (dev->revision >= 0 ||
> > + revinfo.revision > virtio_ccw_rev_max(dev)) {
>
> In the next patch virtio_ccw_handle_set_vq() uses big-endian memory
> access functions to load a struct from guest memory.
>
> Here you just copy the struct in without byteswaps.
>
> Are the byteswaps missing here? (I guess this normally runs big-endian
> guests on big-endian hosts so it's not noticable.)
Indeed, t...
2015 Jan 21
0
[PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call
...ret = -EFAULT;
> > + break;
> > + }
> > + cpu_physical_memory_read(ccw.cda, &revinfo, len);
> > + if (dev->revision >= 0 ||
> > + revinfo.revision > virtio_ccw_rev_max(dev)) {
>
> In the next patch virtio_ccw_handle_set_vq() uses big-endian memory
> access functions to load a struct from guest memory.
>
> Here you just copy the struct in without byteswaps.
>
> Are the byteswaps missing here? (I guess this normally runs big-endian
> guests on big-endian hosts so it's not noticable.)
Indeed, t...
2014 Nov 25
15
[PATCH RFC v2 00/12] qemu: towards virtio-1 host support
Hi,
here's the next version of my virtio-1 qemu patchset. Using virtio-1
virtio-blk and virtio-net devices with a guest kernel built from
<1416829787-14252-1-git-send-email-mst at redhat.com> still seems to
work for the virtio-ccw transport.
Changes from v1:
- rebased against current master
- don't advertise VERSION_1 for all devices, make devices switch it on
individually
2014 Nov 25
15
[PATCH RFC v2 00/12] qemu: towards virtio-1 host support
Hi,
here's the next version of my virtio-1 qemu patchset. Using virtio-1
virtio-blk and virtio-net devices with a guest kernel built from
<1416829787-14252-1-git-send-email-mst at redhat.com> still seems to
work for the virtio-ccw transport.
Changes from v1:
- rebased against current master
- don't advertise VERSION_1 for all devices, make devices switch it on
individually
2014 Nov 26
15
[PATCH RFC v3 00/12] qemu: towards virtio-1 host support
Next version of virtio-1 patches for qemu.
Only change from v2 is splitting out the vring accessors into a
separate header file - should hopefully fix the build issues.
Cornelia Huck (9):
virtio: cull virtio_bus_set_vdev_features
virtio: support more feature bits
s390x/virtio-ccw: fix check for WRITE_FEAT
virtio: introduce legacy virtio devices
virtio: allow virtio-1 queue layout
2014 Nov 26
15
[PATCH RFC v3 00/12] qemu: towards virtio-1 host support
Next version of virtio-1 patches for qemu.
Only change from v2 is splitting out the vring accessors into a
separate header file - should hopefully fix the build issues.
Cornelia Huck (9):
virtio: cull virtio_bus_set_vdev_features
virtio: support more feature bits
s390x/virtio-ccw: fix check for WRITE_FEAT
virtio: introduce legacy virtio devices
virtio: allow virtio-1 queue layout
2014 Nov 27
22
[PATCH RFC v4 00/16] qemu: towards virtio-1 host support
Yet another version of the virtio-1 support patches.
This one has seen some (very) light testing with the virtio-1 guest
support patches currently on vhost-next.
Changes from v3:
- Add support for FEATURES_OK. We refuse to set features after the
driver has set this in the status field, and we allow to fail
setting the status if the features are inconsistent.
- Add missing virtio-1 changes
2014 Nov 27
22
[PATCH RFC v4 00/16] qemu: towards virtio-1 host support
Yet another version of the virtio-1 support patches.
This one has seen some (very) light testing with the virtio-1 guest
support patches currently on vhost-next.
Changes from v3:
- Add support for FEATURES_OK. We refuse to set features after the
driver has set this in the status field, and we allow to fail
setting the status if the features are inconsistent.
- Add missing virtio-1 changes
2014 Oct 07
18
[PATCH RFC 00/11] qemu: towards virtio-1 host support
This patchset aims to get us some way to implement virtio-1 compliant
and transitional devices in qemu. Branch available at
git://github.com/cohuck/qemu virtio-1
I've mainly focused on:
- endianness handling
- extended feature bits
- virtio-ccw new/changed commands
Thanks go to Thomas for some preliminary work in this area.
I've been able to start guests both with and without the
2014 Oct 07
18
[PATCH RFC 00/11] qemu: towards virtio-1 host support
This patchset aims to get us some way to implement virtio-1 compliant
and transitional devices in qemu. Branch available at
git://github.com/cohuck/qemu virtio-1
I've mainly focused on:
- endianness handling
- extended feature bits
- virtio-ccw new/changed commands
Thanks go to Thomas for some preliminary work in this area.
I've been able to start guests both with and without the
2014 Dec 11
45
[PATCH RFC v6 00/20] qemu: towards virtio-1 host support
And yet another iteration of virtio-1 support in qemu, tested with the
latest virtio kernel patches. Find it at
git://github.com/cohuck/qemu virtio-1
Changes from v5:
- fixed stupid bug in "virtio: support more feature bits": we need to
define a proper prop backend for 64 bit wide handling...
- don't negotiate revision 1 unless VERSION_1 is offered
- use 64 bit wide features
2014 Dec 11
45
[PATCH RFC v6 00/20] qemu: towards virtio-1 host support
And yet another iteration of virtio-1 support in qemu, tested with the
latest virtio kernel patches. Find it at
git://github.com/cohuck/qemu virtio-1
Changes from v5:
- fixed stupid bug in "virtio: support more feature bits": we need to
define a proper prop backend for 64 bit wide handling...
- don't negotiate revision 1 unless VERSION_1 is offered
- use 64 bit wide features
2014 Dec 02
24
[PATCH RFC v5 00/19] qemu: towards virtio-1 host support
Another iteration of virtio-1 patches for qemu, as always available on
git://github.com/cohuck/qemu virtio-1
This one seems to work together with the current vhost-next patches
(well, I can ping :)
Changes from v4:
- add helpers for feature bit manipulation and checking
- use 64 bit feature bits instead of 32 bit arrays
- infrastructure to allow devices to offer different sets of feature
bits
2014 Dec 02
24
[PATCH RFC v5 00/19] qemu: towards virtio-1 host support
Another iteration of virtio-1 patches for qemu, as always available on
git://github.com/cohuck/qemu virtio-1
This one seems to work together with the current vhost-next patches
(well, I can ping :)
Changes from v4:
- add helpers for feature bit manipulation and checking
- use 64 bit feature bits instead of 32 bit arrays
- infrastructure to allow devices to offer different sets of feature
bits