search for: virtio_balloon_f_guest_tells_host

...LENT_DEFLATE is the optimization feature that VIRTIO_BALLOON_F_MUST_TELL_HOST was meant to be. What I'm interested in, is drivers that can _optionally_ use silent deflation (as an optimization). These should not get a fake balloon! With the new feature bit, these drivers should propose both VIRTIO_BALLOON_F_GUEST_TELLS_HOST and VIRTIO_BALLOON_F_SILENT_DEFLATE. The driver can then use silent deflation if and only if the host has negotiated VIRTIO_BALLOON_F_SILENT_DEFLATE too. Like this: diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index bd3ae32..05fe948 100644 --- a/drivers/virtio/...

..._BALLOON_F_MUST_TELL_HOST was meant to be. >> >> What I'm interested in, is drivers that can _optionally_ use silent >> deflation (as an optimization). These should not get a fake balloon! >> >> With the new feature bit, these drivers should propose both >> VIRTIO_BALLOON_F_GUEST_TELLS_HOST and VIRTIO_BALLOON_F_SILENT_DEFLATE. >> The driver can then use silent deflation if and only if the host >> has negotiated VIRTIO_BALLOON_F_SILENT_DEFLATE too. Like this: >> >> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c >> index b...

...t; feature that VIRTIO_BALLOON_F_MUST_TELL_HOST was meant to be. > > What I'm interested in, is drivers that can _optionally_ use silent > deflation (as an optimization). These should not get a fake balloon! > > With the new feature bit, these drivers should propose both > VIRTIO_BALLOON_F_GUEST_TELLS_HOST and VIRTIO_BALLOON_F_SILENT_DEFLATE. > The driver can then use silent deflation if and only if the host > has negotiated VIRTIO_BALLOON_F_SILENT_DEFLATE too. Like this: > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index bd3ae32..05fe948 100...

...meant to be. > >> > >> What I'm interested in, is drivers that can _optionally_ use silent > >> deflation (as an optimization). These should not get a fake balloon! > >> > >> With the new feature bit, these drivers should propose both > >> VIRTIO_BALLOON_F_GUEST_TELLS_HOST and VIRTIO_BALLOON_F_SILENT_DEFLATE. > >> The driver can then use silent deflation if and only if the host > >> has negotiated VIRTIO_BALLOON_F_SILENT_DEFLATE too. Like this: > >> > >> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloo...

...gt;>> >>>> What I'm interested in, is drivers that can _optionally_ use silent >>>> deflation (as an optimization). These should not get a fake balloon! >>>> >>>> With the new feature bit, these drivers should propose both >>>> VIRTIO_BALLOON_F_GUEST_TELLS_HOST and VIRTIO_BALLOON_F_SILENT_DEFLATE. >>>> The driver can then use silent deflation if and only if the host >>>> has negotiated VIRTIO_BALLOON_F_SILENT_DEFLATE too. Like this: >>>> >>>> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/v...

...driver that does not negotiate VIRTIO_BALLOON_F_MUST_TELL_HOST is also using pages before telling the host. Thus, even though the feature used to be just for communication from the host, known drivers are really using it to communicate was in the other direction, as if the feature was named "VIRTIO_BALLOON_F_GUEST_TELLS_HOST". Adjust the spec to conform, and add a new feature bit for the host to tell the drivers if silent deflation is actually supported. With this new feature bit, the host can distinguish all three cases: will never do silent deflation, will do silent deflation if available, will always do silen...

...driver that does not negotiate VIRTIO_BALLOON_F_MUST_TELL_HOST is also using pages before telling the host. Thus, even though the feature used to be just for communication from the host, known drivers are really using it to communicate was in the other direction, as if the feature was named "VIRTIO_BALLOON_F_GUEST_TELLS_HOST". Adjust the spec to conform, and add a new feature bit for the host to tell the drivers if silent deflation is actually supported. With this new feature bit, the host can distinguish all three cases: will never do silent deflation, will do silent deflation if available, will always do silen...

...>> What I'm interested in, is drivers that can _optionally_ use silent > >>>> deflation (as an optimization). These should not get a fake balloon! > >>>> > >>>> With the new feature bit, these drivers should propose both > >>>> VIRTIO_BALLOON_F_GUEST_TELLS_HOST and VIRTIO_BALLOON_F_SILENT_DEFLATE. > >>>> The driver can then use silent deflation if and only if the host > >>>> has negotiated VIRTIO_BALLOON_F_SILENT_DEFLATE too. Like this: > >>>> > >>>> diff --git a/drivers/virtio/virtio_balloon....

Il 28/05/2013 13:44, Michael S. Tsirkin ha scritto: > negotiated in spec means "present and acked by guest". > We can try and replace "negotiated" by "present and acked by guest" > everywhere - think it will be clearer? No, I understand what negotiated means. But in this case, "negotiated" is not the word that you want. >>>> Now