search for: virtio_9p_config

...ERWISE) ARISING IN ANY WAY * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. */ -#include <linux/types.h> +#include <linux/virtio_types.h> #include <linux/virtio_ids.h> #include <linux/virtio_config.h> @@ -36,7 +36,7 @@ struct virtio_9p_config { /* length of the tag name */ - __u16 tag_len; + __virtio16 tag_len; /* non-NULL terminated tag name */ __u8 tag[0]; } __attribute__((packed)); -- MST

...ERWISE) ARISING IN ANY WAY * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. */ -#include <linux/types.h> +#include <linux/virtio_types.h> #include <linux/virtio_ids.h> #include <linux/virtio_config.h> @@ -36,7 +36,7 @@ struct virtio_9p_config { /* length of the tag name */ - __u16 tag_len; + __virtio16 tag_len; /* non-NULL terminated tag name */ __u8 tag[0]; } __attribute__((packed)); -- MST

...+\end_inset + +configuration +\begin_inset space ~ +\end_inset + +layout Both fields of this configuration are available only if VIRTIO_9P_MOUNT_T +AG was negotiated: +\begin_inset listings +inline false +status open + +\begin_layout Plain Layout + +\change_inserted -1728740334 1365527046 + +struct virtio_9p_config { +\end_layout + +\begin_layout Plain Layout + +\change_inserted -1728740334 1365527050 + + /* length of the tag name */ +\end_layout + +\begin_layout Plain Layout + +\change_inserted -1728740334 1365527055 + + __u16 tag_len; +\end_layout + +\begin_layout Plain Layout + +\change_inserted -172874033...

...+\end_inset + +configuration +\begin_inset space ~ +\end_inset + +layout Both fields of this configuration are available only if VIRTIO_9P_MOUNT_T +AG was negotiated: +\begin_inset listings +inline false +status open + +\begin_layout Plain Layout + +\change_inserted -1728740334 1365527046 + +struct virtio_9p_config { +\end_layout + +\begin_layout Plain Layout + +\change_inserted -1728740334 1365527050 + + /* length of the tag name */ +\end_layout + +\begin_layout Plain Layout + +\change_inserted -1728740334 1365527055 + + __u16 tag_len; +\end_layout + +\begin_layout Plain Layout + +\change_inserted -172874033...

Aiming these for coming merge window. Nothing should change, but get ready for a non-guest-endian config transports, and > 32 features bits. Final one is just an overdue consolidation. Cheers, Rusty. Rusty Russell (7): virtio_config: introduce size-based accessors. virtio: use size-based config accessors. virtio_config: helpers for non-converting accessors. virtio_config: make

Aiming these for coming merge window. Nothing should change, but get ready for a non-guest-endian config transports, and > 32 features bits. Final one is just an overdue consolidation. Cheers, Rusty. Rusty Russell (7): virtio_config: introduce size-based accessors. virtio: use size-based config accessors. virtio_config: helpers for non-converting accessors. virtio_config: make

...Rest of PCI config space */ u32 bar_size[6]; } __attribute__((packed)); diff --git a/include/kvm/virtio-9p.h b/include/kvm/virtio-9p.h index 19ffe50..2f7e25a 100644 --- a/include/kvm/virtio-9p.h +++ b/include/kvm/virtio-9p.h @@ -46,7 +46,7 @@ struct p9_dev { struct rb_root fids; struct virtio_9p_config *config; - u32 features; + u64 features; /* virtio queue */ struct virt_queue vqs[NUM_VIRT_QUEUES]; diff --git a/include/kvm/virtio-pci.h b/include/kvm/virtio-pci-modern.h similarity index 69% copy from include/kvm/virtio-pci.h copy to include/kvm/virtio-pci-modern.h index b70cadd..f07085...

...Rest of PCI config space */ u32 bar_size[6]; } __attribute__((packed)); diff --git a/include/kvm/virtio-9p.h b/include/kvm/virtio-9p.h index 19ffe50..2f7e25a 100644 --- a/include/kvm/virtio-9p.h +++ b/include/kvm/virtio-9p.h @@ -46,7 +46,7 @@ struct p9_dev { struct rb_root fids; struct virtio_9p_config *config; - u32 features; + u64 features; /* virtio queue */ struct virt_queue vqs[NUM_VIRT_QUEUES]; diff --git a/include/kvm/virtio-pci.h b/include/kvm/virtio-pci-modern.h similarity index 69% copy from include/kvm/virtio-pci.h copy to include/kvm/virtio-pci-modern.h index b70cadd..f07085...

I've renewed this again, with some comments from HPA. I've tried to keep the new patches separate, so you can see the changes since we last discussed this (and so it's easy to back it out if we decide it's insane). I haven't even looked at the QEMU side so this is completely untested. Comments gratefully received! Rusty. Michael S Tsirkin (1): pci: add pci_iomap_range

I've renewed this again, with some comments from HPA. I've tried to keep the new patches separate, so you can see the changes since we last discussed this (and so it's easy to back it out if we decide it's insane). I haven't even looked at the QEMU side so this is completely untested. Comments gratefully received! Rusty. Michael S Tsirkin (1): pci: add pci_iomap_range

Config space endian-ness is currently a mess: fields are not tagged with the correct endian-ness so it's easy to make mistakes like instanciating config space in native endian-ness. The following patches adding sparse tagging are currently in my tree. Lightly tested. As a follow-up, I plan to add new APIs that handle modern config space in a more efficient way (bypassing the version check).