search for: virtio_1

...Gonglei wrote: > > > Virtio modern devices are always little edian, let's introduce > > > the LE functions for read/write configuration space for > > > virtio modern devices, which avoid complaint by Sparse when > > > we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices. > > > > > > Signed-off-by: Gonglei <arei.gonglei at huawei.com> > > > --- > > > include/linux/virtio_config.h | 45 > > +++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 45 insertions(+) > > > > > >...

...Gonglei wrote: > > > Virtio modern devices are always little edian, let's introduce > > > the LE functions for read/write configuration space for > > > virtio modern devices, which avoid complaint by Sparse when > > > we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices. > > > > > > Signed-off-by: Gonglei <arei.gonglei at huawei.com> > > > --- > > > include/linux/virtio_config.h | 45 > > +++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 45 insertions(+) > > > > > >...

...Tue, Nov 22, 2016 at 04:10:22PM +0800, Gonglei wrote: > Virtio modern devices are always little edian, let's introduce > the LE functions for read/write configuration space for > virtio modern devices, which avoid complaint by Sparse when > we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices. > > Signed-off-by: Gonglei <arei.gonglei at huawei.com> > --- > include/linux/virtio_config.h | 45 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h &g...

...Tue, Nov 22, 2016 at 04:10:22PM +0800, Gonglei wrote: > Virtio modern devices are always little edian, let's introduce > the LE functions for read/write configuration space for > virtio modern devices, which avoid complaint by Sparse when > we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices. > > Signed-off-by: Gonglei <arei.gonglei at huawei.com> > --- > include/linux/virtio_config.h | 45 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h &g...

...sses, assigning functions to them depending on user?s needs. [...] 4.2.2.2 Driver Requirements: MMIO Device Register Layout The driver MUST ignore a device with DeviceID 0x0, but MUST NOT report any error." > > + } > > Need to also > 1. validate that feature bit VIRTIO_1 is set > 2. validate that ID is not for a legacy device > > otherwise device specific drivers might get invoked > on future devices (e.g. when we update balloon for 1.0) > and they not do the right thing. I'm not following you, but I admit I haven't though this prob...

...sses, assigning functions to them depending on user?s needs. [...] 4.2.2.2 Driver Requirements: MMIO Device Register Layout The driver MUST ignore a device with DeviceID 0x0, but MUST NOT report any error." > > + } > > Need to also > 1. validate that feature bit VIRTIO_1 is set > 2. validate that ID is not for a legacy device > > otherwise device specific drivers might get invoked > on future devices (e.g. when we update balloon for 1.0) > and they not do the right thing. I'm not following you, but I admit I haven't though this prob...

Spec says devices must set VIRTIO_1 feature bit. Fail gracefully if they don't. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_modern.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c index 17f0228..a8f...

Spec says devices must set VIRTIO_1 feature bit. Fail gracefully if they don't. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_modern.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c index 17f0228..a8f...

...t 04:10:22PM +0800, Gonglei wrote: > > Virtio modern devices are always little edian, let's introduce > > the LE functions for read/write configuration space for > > virtio modern devices, which avoid complaint by Sparse when > > we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices. > > > > Signed-off-by: Gonglei <arei.gonglei at huawei.com> > > --- > > include/linux/virtio_config.h | 45 > +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > > > diff --git a/include/linux/virtio_confi...

...> > > Virtio modern devices are always little edian, let's introduce > > > > the LE functions for read/write configuration space for > > > > virtio modern devices, which avoid complaint by Sparse when > > > > we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices. > > > > > > > > Signed-off-by: Gonglei <arei.gonglei at huawei.com> > > > > --- > > > > include/linux/virtio_config.h | 45 > > > +++++++++++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 45 insertions(+)...

...driver registered for this ID, so it's just ignored. > Seems like what spec is asking for, no? Not to me, no. There will be a vm_dev registered with an _illegal_ ID. > > > > + } > > > > > > Need to also > > > 1. validate that feature bit VIRTIO_1 is set > > > 2. validate that ID is not for a legacy device > > > > > > otherwise device specific drivers might get invoked > > > on future devices (e.g. when we update balloon for 1.0) > > > and they not do the right thing. > > > >...

...driver registered for this ID, so it's just ignored. > Seems like what spec is asking for, no? Not to me, no. There will be a vm_dev registered with an _illegal_ ID. > > > > + } > > > > > > Need to also > > > 1. validate that feature bit VIRTIO_1 is set > > > 2. validate that ID is not for a legacy device > > > > > > otherwise device specific drivers might get invoked > > > on future devices (e.g. when we update balloon for 1.0) > > > and they not do the right thing. > > > >...

...> any error." Absolutely. So what happens if you drop these code lines? There's no driver registered for this ID, so it's just ignored. Seems like what spec is asking for, no? > > > + } > > > > Need to also > > 1. validate that feature bit VIRTIO_1 is set > > 2. validate that ID is not for a legacy device > > > > otherwise device specific drivers might get invoked > > on future devices (e.g. when we update balloon for 1.0) > > and they not do the right thing. > > I'm not following you, but I a...

...> any error." Absolutely. So what happens if you drop these code lines? There's no driver registered for this ID, so it's just ignored. Seems like what spec is asking for, no? > > > + } > > > > Need to also > > 1. validate that feature bit VIRTIO_1 is set > > 2. validate that ID is not for a legacy device > > > > otherwise device specific drivers might get invoked > > on future devices (e.g. when we update balloon for 1.0) > > and they not do the right thing. > > I'm not following you, but I a...

...ing for, no? > > Not to me, no. There will be a vm_dev registered with an _illegal_ ID. Yes - there will be a device, but no driver will drive it. > > > > > + } > > > > > > > > Need to also > > > > 1. validate that feature bit VIRTIO_1 is set > > > > 2. validate that ID is not for a legacy device > > > > > > > > otherwise device specific drivers might get invoked > > > > on future devices (e.g. when we update balloon for 1.0) > > > > and they not do the right th...

...ing for, no? > > Not to me, no. There will be a vm_dev registered with an _illegal_ ID. Yes - there will be a device, but no driver will drive it. > > > > > + } > > > > > > > > Need to also > > > > 1. validate that feature bit VIRTIO_1 is set > > > > 2. validate that ID is not for a legacy device > > > > > > > > otherwise device specific drivers might get invoked > > > > on future devices (e.g. when we update balloon for 1.0) > > > > and they not do the right th...

Virtio modern devices are always little edian, let's introduce the LE functions for read/write configuration space for virtio modern devices, which avoid complaint by Sparse when we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices. Signed-off-by: Gonglei <arei.gonglei at huawei.com> --- include/linux/virtio_config.h | 45 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h index 26c155b..de05707 100644 --- a/i...

...-endian host, num_buffers wasn't byte-swapped correctly, so large incoming packets got corrupted. To fix, fill it in within hdr - this also makes sure it gets the correct type. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- It seems important to get this into 3.19, otherwise VIRTIO_1 feature bit is unreliable. Dave, do you plan another pull request for 3.19? If yes pls merge this, if not pls let me know and I'll try to send it to Linus directly. drivers/vhost/net.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/net.c b/drivers/vhost...

...-endian host, num_buffers wasn't byte-swapped correctly, so large incoming packets got corrupted. To fix, fill it in within hdr - this also makes sure it gets the correct type. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- It seems important to get this into 3.19, otherwise VIRTIO_1 feature bit is unreliable. Dave, do you plan another pull request for 3.19? If yes pls merge this, if not pls let me know and I'll try to send it to Linus directly. drivers/vhost/net.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/net.c b/drivers/vhost...

...(write ? req->out_num : req->in_num) - 1; > + unsigned long sector = le64_to_cpu(req->hdr.sector); Using little-endian instead of the virtio types means that only VIRTIO 1.0 modern devices are supported (older devices may not be little-endian!). In that case you'd need to put the VIRTIO_1 feature bit into the features mask. > + req = &q->req[head]; > + req->index = head; > + req->out_num = out; > + req->in_num = in; > + req->out_iov = &vq->iov[1]; > + req->in_iov = &vq->iov[out]; > + req->status = vq->iov[out + i...