search for: virtio32

...s is definately bug. The command ID I was talking about was > the one being passed via the descriptor ring. That one I believe is > native on both sides. Well qemu swaps it for modern devices: virtio_tswap32s(vdev, &id); guest swaps it too: vb->cmd_id_active = cpu_to_virtio32(vb->vdev, virtio_balloon_cmd_id_received(vb)); sg_init_one(&sg, &vb->cmd_id_active, sizeof(vb->cmd_id_active)); err = virtqueue_add_outbuf(vq, &sg, 1, &vb->cmd_id_active, GFP_KERNEL); So it's native for legacy....

...s is definately bug. The command ID I was talking about was > the one being passed via the descriptor ring. That one I believe is > native on both sides. Well qemu swaps it for modern devices: virtio_tswap32s(vdev, &id); guest swaps it too: vb->cmd_id_active = cpu_to_virtio32(vb->vdev, virtio_balloon_cmd_id_received(vb)); sg_init_one(&sg, &vb->cmd_id_active, sizeof(vb->cmd_id_active)); err = virtqueue_add_outbuf(vq, &sg, 1, &vb->cmd_id_active, GFP_KERNEL); So it's native for legacy....

...talking about was > > the one being passed via the descriptor ring. That one I believe is > > native on both sides. > > Well qemu swaps it for modern devices: > > virtio_tswap32s(vdev, &id); > > guest swaps it too: > vb->cmd_id_active = cpu_to_virtio32(vb->vdev, > virtio_balloon_cmd_id_received(vb)); > sg_init_one(&sg, &vb->cmd_id_active, sizeof(vb->cmd_id_active)); > err = virtqueue_add_outbuf(vq, &sg, 1, &vb->cmd_id_active, GFP_KERNEL); > > So it&...

On Fri, Jul 10, 2020 at 09:13:41AM -0700, Alexander Duyck wrote: > On Fri, Jul 10, 2020 at 4:31 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > Page reporting features were never supported by legacy hypervisors. > > Supporting them poses a problem: should we use native endian-ness (like > > current code assumes)? Or little endian-ness like the virtio spec

On Fri, Jul 10, 2020 at 09:13:41AM -0700, Alexander Duyck wrote: > On Fri, Jul 10, 2020 at 4:31 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > Page reporting features were never supported by legacy hypervisors. > > Supporting them poses a problem: should we use native endian-ness (like > > current code assumes)? Or little endian-ness like the virtio spec

...com> > > Hmm so now you pointed out it's just cmd id, maybe I should just fix it > instead? what do you say? So the config issues are bugs, but I don't think you saw the one I was talking about. In the function send_cmd_id_start the cmd_id_active value which is initialized as a virtio32 is added as a sg entry and then sent as an outbuf to the device. I'm assuming virtio32 is a host native byte ordering.

Hi Michael, this patch (against your vhost branch) should fix the endianness issues we saw on s390 that I mentioned on irc yesterday. Both the config space and the stats seem to be fine endianness-wise, but the pfns for inflate/deflate were not converted to little endian for virtio-1 (the qemu code is correct). Without the patch, I get an immediate crash on qemu master when started via libvirt

Hi Michael, this patch (against your vhost branch) should fix the endianness issues we saw on s390 that I mentioned on irc yesterday. Both the config space and the stats seem to be fine endianness-wise, but the pfns for inflate/deflate were not converted to little endian for virtio-1 (the qemu code is correct). Without the patch, I get an immediate crash on qemu master when started via libvirt

As virtio-1 devices use little endian on their queues, we need to make sure the pfns are in virtio32 format before we put them on the queue. Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- drivers/virtio/virtio_balloon.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 7b6d74f..89...

...ange? Changes from PATCH v10: [1] - Rebased on Linux-5.2-rc4 Changes from PATCH v9: [2] - Kconfig help text add two spaces - Randy - Fixed libnvdimm 'bio' include warning - Dan - virtio-pmem, separate request/resp struct and move to uapi file with updated license - DavidH - Use virtio32* type for req/resp endianess - DavidH - Added tested-by & ack-by of Jakob - Rebased to 5.2-rc1 Changes from PATCH v8: - Set device mapper synchronous if all target devices support - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages in pat...

...to confirm if this behaviour is ok or needs any change? Changes from PATCH v9: [1] - Kconfig help text add two spaces - Randy - Fixed libnvdimm 'bio' include warning - Dan - virtio-pmem, separate request/resp struct and move to uapi file with updated license - DavidH - Use virtio32* type for req/resp endianess - DavidH - Added tested-by & ack-by of Jakob - Rebased to 5.2-rc1 Changes from PATCH v8: [2] - Set device mapper synchronous if all target devices support - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages i...

...apper - [Mike] Changes from PATCH v10: - Rebased on Linux-5.2-rc4 Changes from PATCH v9: - Kconfig help text add two spaces - Randy - Fixed libnvdimm 'bio' include warning - Dan - virtio-pmem, separate request/resp struct and move to uapi file with updated license - DavidH - Use virtio32* type for req/resp endianess - DavidH - Added tested-by & ack-by of Jakob - Rebased to 5.2-rc1 Changes from PATCH v8: - Set device mapper synchronous if all target devices support - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages in pat...

...apper - [Mike] Changes from PATCH v10: - Rebased on Linux-5.2-rc4 Changes from PATCH v9: - Kconfig help text add two spaces - Randy - Fixed libnvdimm 'bio' include warning - Dan - virtio-pmem, separate request/resp struct and move to uapi file with updated license - DavidH - Use virtio32* type for req/resp endianess - DavidH - Added tested-by & ack-by of Jakob - Rebased to 5.2-rc1 Changes from PATCH v8: - Set device mapper synchronous if all target devices support - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages in pat...

...apper - [Mike] Changes from PATCH v10: - Rebased on Linux-5.2-rc4 Changes from PATCH v9: - Kconfig help text add two spaces - Randy - Fixed libnvdimm 'bio' include warning - Dan - virtio-pmem, separate request/resp struct and move to uapi file with updated license - DavidH - Use virtio32* type for req/resp endianess - DavidH - Added tested-by & ack-by of Jakob - Rebased to 5.2-rc1 Changes from PATCH v8: - Set device mapper synchronous if all target devices support - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages in pat...

...er - Mike Changes from PATCH v10: [2] - Rebased on Linux-5.2-rc4 Changes from PATCH v9: - Kconfig help text add two spaces - Randy - Fixed libnvdimm 'bio' include warning - Dan - virtio-pmem, separate request/resp struct and move to uapi file with updated license - DavidH - Use virtio32* type for req/resp endianess - DavidH - Added tested-by & ack-by of Jakob - Rebased to 5.2-rc1 Changes from PATCH v8: - Set device mapper synchronous if all target devices support - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages in pat...