search for: virtinput_send_status

...;evt, &len)) != NULL) { > + input_event(vi->idev, > + le16_to_cpu(event->type), > + le16_to_cpu(event->code), > + le32_to_cpu(event->value)); > + virtinput_queue_evtbuf(vi, event); > + } > + virtqueue_kick(vq); > +} > + > +static int virtinput_send_status(struct virtio_input *vi, > + u16 type, u16 code, s32 value) > +{ > + struct virtio_input_event *stsbuf; > + struct scatterlist sg[1]; > + > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); > + if (!stsbuf) > + return -ENOMEM; Does this return an error to userspace? If...

...;evt, &len)) != NULL) { > + input_event(vi->idev, > + le16_to_cpu(event->type), > + le16_to_cpu(event->code), > + le32_to_cpu(event->value)); > + virtinput_queue_evtbuf(vi, event); > + } > + virtqueue_kick(vq); > +} > + > +static int virtinput_send_status(struct virtio_input *vi, > + u16 type, u16 code, s32 value) > +{ > + struct virtio_input_event *stsbuf; > + struct scatterlist sg[1]; > + > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); > + if (!stsbuf) > + return -ENOMEM; Does this return an error to userspace? If...

...pe), > > + le16_to_cpu(event->code), > > + le32_to_cpu(event->value)); > > What happens if input layer gets an > unexpected event code or value? input layer checks it and ignores events not supported (according to the support bitmaps). > > +static int virtinput_send_status(struct virtio_input *vi, > > + u16 type, u16 code, s32 value) > > +{ > This means that caller will get errors if it happens to call > send_status at a rate that's faster than host's consumption of them. > To me this looks wrong. > Poking at input layer, it seems...

...pe), > > + le16_to_cpu(event->code), > > + le32_to_cpu(event->value)); > > What happens if input layer gets an > unexpected event code or value? input layer checks it and ignores events not supported (according to the support bitmaps). > > +static int virtinput_send_status(struct virtio_input *vi, > > + u16 type, u16 code, s32 value) > > +{ > This means that caller will get errors if it happens to call > send_status at a rate that's faster than host's consumption of them. > To me this looks wrong. > Poking at input layer, it seems...

Hi, > > +static int virtinput_send_status(struct virtio_input *vi, > > + u16 type, u16 code, s32 value) > > +{ > > + struct virtio_input_event *stsbuf; > > + struct scatterlist sg[1]; > > + > > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); > > + if (!stsbuf) > > + return -ENOMEM; >...

Hi, > > +static int virtinput_send_status(struct virtio_input *vi, > > + u16 type, u16 code, s32 value) > > +{ > > + struct virtio_input_event *stsbuf; > > + struct scatterlist sg[1]; > > + > > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); > > + if (!stsbuf) > > + return -ENOMEM; >...

...le16_to_cpu(event->type), > + le16_to_cpu(event->code), > + le32_to_cpu(event->value)); > + virtinput_queue_evtbuf(vi, event); > + } > + virtqueue_kick(vq); > +} > + > +static int virtinput_send_status(struct virtio_input *vi, > + u16 type, u16 code, s32 value) > +{ > + struct virtio_input_event *stsbuf; > + struct scatterlist sg[1]; > + > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); > + if (!stsbuf) > +...

...le16_to_cpu(event->type), > + le16_to_cpu(event->code), > + le32_to_cpu(event->value)); > + virtinput_queue_evtbuf(vi, event); > + } > + virtqueue_kick(vq); > +} > + > +static int virtinput_send_status(struct virtio_input *vi, > + u16 type, u16 code, s32 value) > +{ > + struct virtio_input_event *stsbuf; > + struct scatterlist sg[1]; > + > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); > + if (!stsbuf) > +...

Hi, This patch adds a virtio driver for input devices. Specification: https://www.kraxel.org/cgit/virtio-spec/log/?h=virtio-input https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-input.html#x1-2640007 Qemu patches; https://lists.gnu.org/archive/html/qemu-devel/2015-03/threads.html#03973 Gerd Hoffmann (1): Add virtio-input driver. drivers/virtio/Kconfig | 10 ++

Hi, This patch adds a virtio driver for input devices. Specification: https://www.kraxel.org/cgit/virtio-spec/log/?h=virtio-input https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-input.html#x1-2640007 Qemu patches; https://lists.gnu.org/archive/html/qemu-devel/2015-03/threads.html#03973 Gerd Hoffmann (1): Add virtio-input driver. drivers/virtio/Kconfig | 10 ++

...t; > + le16_to_cpu(event->code), > > + le32_to_cpu(event->value)); > > + virtinput_queue_evtbuf(vi, event); > > + } > > + virtqueue_kick(vq); > > +} > > + > > +static int virtinput_send_status(struct virtio_input *vi, > > + u16 type, u16 code, s32 value) > > +{ > > + struct virtio_input_event *stsbuf; > > + struct scatterlist sg[1]; > > + > > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); > > +...

...t; > + le16_to_cpu(event->code), > > + le32_to_cpu(event->value)); > > + virtinput_queue_evtbuf(vi, event); > > + } > > + virtqueue_kick(vq); > > +} > > + > > +static int virtinput_send_status(struct virtio_input *vi, > > + u16 type, u16 code, s32 value) > > +{ > > + struct virtio_input_event *stsbuf; > > + struct scatterlist sg[1]; > > + > > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); > > +...

...e_get_buf(vi->evt, &len)) != NULL) { + input_event(vi->idev, + le16_to_cpu(event->type), + le16_to_cpu(event->code), + le32_to_cpu(event->value)); + virtinput_queue_evtbuf(vi, event); + } + virtqueue_kick(vq); + mutex_unlock(&vi->lock); +} + +static int virtinput_send_status(struct virtio_input *vi, + u16 type, u16 code, s32 value) +{ + struct virtio_input_event *stsbuf; + struct scatterlist sg[1]; + int rc; + + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); + if (!stsbuf) + return -ENOMEM; + + stsbuf->type = cpu_to_le16(type); + stsbuf->code = cpu_to_le16...

...e_get_buf(vi->evt, &len)) != NULL) { + input_event(vi->idev, + le16_to_cpu(event->type), + le16_to_cpu(event->code), + le32_to_cpu(event->value)); + virtinput_queue_evtbuf(vi, event); + } + virtqueue_kick(vq); + mutex_unlock(&vi->lock); +} + +static int virtinput_send_status(struct virtio_input *vi, + u16 type, u16 code, s32 value) +{ + struct virtio_input_event *stsbuf; + struct scatterlist sg[1]; + int rc; + + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); + if (!stsbuf) + return -ENOMEM; + + stsbuf->type = cpu_to_le16(type); + stsbuf->code = cpu_to_le16...

On Fri, Mar 20, 2015 at 11:28:47AM +0100, Gerd Hoffmann wrote: > Hi, > > > > +static int virtinput_send_status(struct virtio_input *vi, > > > + u16 type, u16 code, s32 value) > > > +{ > > > + struct virtio_input_event *stsbuf; > > > + struct scatterlist sg[1]; > > > + > > > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); > > > + if (!stsbuf...

On Fri, Mar 20, 2015 at 11:28:47AM +0100, Gerd Hoffmann wrote: > Hi, > > > > +static int virtinput_send_status(struct virtio_input *vi, > > > + u16 type, u16 code, s32 value) > > > +{ > > > + struct virtio_input_event *stsbuf; > > > + struct scatterlist sg[1]; > > > + > > > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); > > > + if (!stsbuf...

...evt, &len)) != NULL) { + input_event(vi->idev, + le16_to_cpu(event->type), + le16_to_cpu(event->code), + le32_to_cpu(event->value)); + virtinput_queue_evtbuf(vi, event); + } + virtqueue_kick(vq); + spin_unlock_irqrestore(&vi->lock, flags); +} + +static int virtinput_send_status(struct virtio_input *vi, + u16 type, u16 code, s32 value) +{ + struct virtio_input_event *stsbuf; + struct scatterlist sg[1]; + unsigned long flags; + int rc; + + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); + if (!stsbuf) + return -ENOMEM; + + stsbuf->type = cpu_to_le16(type); + stsbuf-...

...evt, &len)) != NULL) { + input_event(vi->idev, + le16_to_cpu(event->type), + le16_to_cpu(event->code), + le32_to_cpu(event->value)); + virtinput_queue_evtbuf(vi, event); + } + virtqueue_kick(vq); + spin_unlock_irqrestore(&vi->lock, flags); +} + +static int virtinput_send_status(struct virtio_input *vi, + u16 type, u16 code, s32 value) +{ + struct virtio_input_event *stsbuf; + struct scatterlist sg[1]; + unsigned long flags; + int rc; + + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); + if (!stsbuf) + return -ENOMEM; + + stsbuf->type = cpu_to_le16(type); + stsbuf-...

...gets an > unexpected event code or value? > Or does something prevent it? > > > > > + virtinput_queue_evtbuf(vi, event); > > + } > > + virtqueue_kick(vq); > > + spin_unlock_irqrestore(&vi->lock, flags); > > +} > > + > > +static int virtinput_send_status(struct virtio_input *vi, > > + u16 type, u16 code, s32 value) > > +{ > > + struct virtio_input_event *stsbuf; > > + struct scatterlist sg[1]; > > + unsigned long flags; > > + int rc; > > + > > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); >...

...gets an > unexpected event code or value? > Or does something prevent it? > > > > > + virtinput_queue_evtbuf(vi, event); > > + } > > + virtqueue_kick(vq); > > + spin_unlock_irqrestore(&vi->lock, flags); > > +} > > + > > +static int virtinput_send_status(struct virtio_input *vi, > > + u16 type, u16 code, s32 value) > > +{ > > + struct virtio_input_event *stsbuf; > > + struct scatterlist sg[1]; > > + unsigned long flags; > > + int rc; > > + > > + stsbuf = kzalloc(sizeof(*stsbuf), GFP_ATOMIC); >...