Displaying 20 results from an estimated 163 matches for "virtcons_probe".
2012 Sep 19
2
[PATCHv2] virtio_console: Add support for remoteproc serial
...ev->c_ivq)))
- free_buf(buf);
+ free_buf(portdev->c_ivq, buf, PAGE_SIZE);
}
/*
@@ -1688,7 +1768,7 @@ static void remove_controlq_data(struct ports_device *portdev)
* config space to see how many ports the host has spawned. We
* initialize each port found.
*/
-static int __devinit virtcons_probe(struct virtio_device *vdev)
+static int virtcons_probe(struct virtio_device *vdev)
{
struct ports_device *portdev;
int err;
@@ -1724,10 +1804,12 @@ static int __devinit virtcons_probe(struct virtio_device *vdev)
multiport = false;
portdev->config.max_nr_ports = 1;
- if (virtio_config_...
2012 Sep 19
2
[PATCHv2] virtio_console: Add support for remoteproc serial
...ev->c_ivq)))
- free_buf(buf);
+ free_buf(portdev->c_ivq, buf, PAGE_SIZE);
}
/*
@@ -1688,7 +1768,7 @@ static void remove_controlq_data(struct ports_device *portdev)
* config space to see how many ports the host has spawned. We
* initialize each port found.
*/
-static int __devinit virtcons_probe(struct virtio_device *vdev)
+static int virtcons_probe(struct virtio_device *vdev)
{
struct ports_device *portdev;
int err;
@@ -1724,10 +1804,12 @@ static int __devinit virtcons_probe(struct virtio_device *vdev)
multiport = false;
portdev->config.max_nr_ports = 1;
- if (virtio_config_...
2019 Nov 13
2
[PATCH v2] virtio_console: allocate inbufs in add_port() only if it is needed
...;port->inbuf_lock);
- if (!nr_added_bufs) {
+ err = fill_queue(port->in_vq, &port->inbuf_lock);
+ if (err < 0 && err != -ENOSPC) {
dev_err(port->dev, "Error allocating inbufs\n");
- err = -ENOMEM;
goto free_device;
}
@@ -2059,14 +2056,11 @@ static int virtcons_probe(struct virtio_device *vdev)
INIT_WORK(&portdev->control_work, &control_work_handler);
if (multiport) {
- unsigned int nr_added_bufs;
-
spin_lock_init(&portdev->c_ivq_lock);
spin_lock_init(&portdev->c_ovq_lock);
- nr_added_bufs = fill_queue(portdev->c_ivq,...
2019 Nov 13
2
[PATCH v2] virtio_console: allocate inbufs in add_port() only if it is needed
...;port->inbuf_lock);
- if (!nr_added_bufs) {
+ err = fill_queue(port->in_vq, &port->inbuf_lock);
+ if (err < 0 && err != -ENOSPC) {
dev_err(port->dev, "Error allocating inbufs\n");
- err = -ENOMEM;
goto free_device;
}
@@ -2059,14 +2056,11 @@ static int virtcons_probe(struct virtio_device *vdev)
INIT_WORK(&portdev->control_work, &control_work_handler);
if (multiport) {
- unsigned int nr_added_bufs;
-
spin_lock_init(&portdev->c_ivq_lock);
spin_lock_init(&portdev->c_ovq_lock);
- nr_added_bufs = fill_queue(portdev->c_ivq,...
2010 Feb 23
2
virtio: console: Barrier needed before dropping early_put_chars?
Hey Rusty, Christian,
Christoph Hellwig asked why we don't need a barrier before this code in
virtcons_probe():
> + /* Start using the new console output. */
> + early_put_chars = NULL;
> return 0;
Since only s390 uses early_put_chars so far, you'd know why it's not
needed / why we're safe.
Thanks,
Amit
2010 Feb 23
2
virtio: console: Barrier needed before dropping early_put_chars?
Hey Rusty, Christian,
Christoph Hellwig asked why we don't need a barrier before this code in
virtcons_probe():
> + /* Start using the new console output. */
> + early_put_chars = NULL;
> return 0;
Since only s390 uses early_put_chars so far, you'd know why it's not
needed / why we're safe.
Thanks,
Amit
2019 Nov 14
3
[PATCH v3] virtio_console: allocate inbufs in add_port() only if it is needed
...virtcons_remove(), not by unplug_port()
+ */
+ err = fill_queue(port->in_vq, &port->inbuf_lock);
+ if (err < 0 && err != -ENOSPC) {
dev_err(port->dev, "Error allocating inbufs\n");
- err = -ENOMEM;
goto free_device;
}
@@ -2059,14 +2060,11 @@ static int virtcons_probe(struct virtio_device *vdev)
INIT_WORK(&portdev->control_work, &control_work_handler);
if (multiport) {
- unsigned int nr_added_bufs;
-
spin_lock_init(&portdev->c_ivq_lock);
spin_lock_init(&portdev->c_ovq_lock);
- nr_added_bufs = fill_queue(portdev->c_ivq,...
2019 Nov 14
3
[PATCH v3] virtio_console: allocate inbufs in add_port() only if it is needed
...virtcons_remove(), not by unplug_port()
+ */
+ err = fill_queue(port->in_vq, &port->inbuf_lock);
+ if (err < 0 && err != -ENOSPC) {
dev_err(port->dev, "Error allocating inbufs\n");
- err = -ENOMEM;
goto free_device;
}
@@ -2059,14 +2060,11 @@ static int virtcons_probe(struct virtio_device *vdev)
INIT_WORK(&portdev->control_work, &control_work_handler);
if (multiport) {
- unsigned int nr_added_bufs;
-
spin_lock_init(&portdev->c_ivq_lock);
spin_lock_init(&portdev->c_ovq_lock);
- nr_added_bufs = fill_queue(portdev->c_ivq,...
2009 Nov 28
3
[PATCH 00/28] virtio: console: Fixes, support for generic ports
Hey Rusty,
This is a respin of my patches on top of the series you posted.
I've taken the liberty to modify your patches for style consistency
and comments where needed, keeping the authorship info intact.
I've had to update a few of your patches for functional changes, I've
changed the authorship info on those patches. The (only) major
functional change is to have a list for ports
2009 Nov 28
3
[PATCH 00/28] virtio: console: Fixes, support for generic ports
Hey Rusty,
This is a respin of my patches on top of the series you posted.
I've taken the liberty to modify your patches for style consistency
and comments where needed, keeping the authorship info intact.
I've had to update a few of your patches for functional changes, I've
changed the authorship info on those patches. The (only) major
functional change is to have a list for ports
2010 Jan 18
2
[PATCH 00/32] virtio: console: Fixes, multiple devices and generic ports
Hey Rusty,
In this version:
- Assume only one inbuf; no input buffering for ports
- Remove the START/END delimiters for outgoing buffers
- Remove the header that was sent along with each buffer
- Remove unused buffers in the vqs at port remove time
- Send a guest port open message to the host when a console port is
attached
- Remove cached buffers when ports are closed / disconnected
- Send
2010 Jan 18
2
[PATCH 00/32] virtio: console: Fixes, multiple devices and generic ports
Hey Rusty,
In this version:
- Assume only one inbuf; no input buffering for ports
- Remove the START/END delimiters for outgoing buffers
- Remove the header that was sent along with each buffer
- Remove unused buffers in the vqs at port remove time
- Send a guest port open message to the host when a console port is
attached
- Remove cached buffers when ports are closed / disconnected
- Send
2012 Sep 13
0
[PATCH] virtio_console: Add support for remoteproc serial
...ev->c_ivq)))
- free_buf(buf);
+ free_buf(portdev->c_ivq, buf, PAGE_SIZE);
}
/*
@@ -1688,7 +1749,7 @@ static void remove_controlq_data(struct ports_device *portdev)
* config space to see how many ports the host has spawned. We
* initialize each port found.
*/
-static int __devinit virtcons_probe(struct virtio_device *vdev)
+static int virtcons_probe(struct virtio_device *vdev)
{
struct ports_device *portdev;
int err;
@@ -1724,10 +1785,12 @@ static int __devinit virtcons_probe(struct virtio_device *vdev)
multiport = false;
portdev->config.max_nr_ports = 1;
- if (virtio_config_...
2012 Sep 13
0
[PATCH] virtio_console: Add support for remoteproc serial
...ev->c_ivq)))
- free_buf(buf);
+ free_buf(portdev->c_ivq, buf, PAGE_SIZE);
}
/*
@@ -1688,7 +1749,7 @@ static void remove_controlq_data(struct ports_device *portdev)
* config space to see how many ports the host has spawned. We
* initialize each port found.
*/
-static int __devinit virtcons_probe(struct virtio_device *vdev)
+static int virtcons_probe(struct virtio_device *vdev)
{
struct ports_device *portdev;
int err;
@@ -1724,10 +1785,12 @@ static int __devinit virtcons_probe(struct virtio_device *vdev)
multiport = false;
portdev->config.max_nr_ports = 1;
- if (virtio_config_...
2014 Oct 20
4
[PATCH v4 13/25] virtio_console: enable VQs early
...amp;port->waitqueue);
>
> - virtio_device_ready(portdev->vdev);
> -
> /* Fill the in_vq with buffers so the host can send us data. */
> nr_added_bufs = fill_queue(port->in_vq, &port->inbuf_lock);
> if (!nr_added_bufs) {
> @@ -2026,6 +2024,8 @@ static int virtcons_probe(struct virtio_device *vdev)
> spin_lock_init(&portdev->ports_lock);
> INIT_LIST_HEAD(&portdev->ports);
>
> + virtio_device_ready(portdev->vdev);
> +
> if (multiport) {
> unsigned int nr_added_bufs;
>
I wanted to set DRIVER_OK as late as possibl...
2014 Oct 20
4
[PATCH v4 13/25] virtio_console: enable VQs early
...amp;port->waitqueue);
>
> - virtio_device_ready(portdev->vdev);
> -
> /* Fill the in_vq with buffers so the host can send us data. */
> nr_added_bufs = fill_queue(port->in_vq, &port->inbuf_lock);
> if (!nr_added_bufs) {
> @@ -2026,6 +2024,8 @@ static int virtcons_probe(struct virtio_device *vdev)
> spin_lock_init(&portdev->ports_lock);
> INIT_LIST_HEAD(&portdev->ports);
>
> + virtio_device_ready(portdev->vdev);
> +
> if (multiport) {
> unsigned int nr_added_bufs;
>
I wanted to set DRIVER_OK as late as possibl...
2019 Nov 13
2
[PATCH v2] virtio_console: allocate inbufs in add_port() only if it is needed
...ror allocating inbufs\n");
> > - err = -ENOMEM;
> > goto free_device;
> > }
> >
>
> Pls add a comment explaining that -ENOSPC happens when
> queue already has buffers (e.g. from previous detach).
>
>
> > @@ -2059,14 +2056,11 @@ static int virtcons_probe(struct virtio_device *vdev)
> > INIT_WORK(&portdev->control_work, &control_work_handler);
> >
> > if (multiport) {
> > - unsigned int nr_added_bufs;
> > -
> > spin_lock_init(&portdev->c_ivq_lock);
> > spin_lock_init(&portd...
2019 Nov 13
2
[PATCH v2] virtio_console: allocate inbufs in add_port() only if it is needed
...ror allocating inbufs\n");
> > - err = -ENOMEM;
> > goto free_device;
> > }
> >
>
> Pls add a comment explaining that -ENOSPC happens when
> queue already has buffers (e.g. from previous detach).
>
>
> > @@ -2059,14 +2056,11 @@ static int virtcons_probe(struct virtio_device *vdev)
> > INIT_WORK(&portdev->control_work, &control_work_handler);
> >
> > if (multiport) {
> > - unsigned int nr_added_bufs;
> > -
> > spin_lock_init(&portdev->c_ivq_lock);
> > spin_lock_init(&portd...
2010 Mar 30
3
[PATCH 4/4] virtio: disable multiport console support.
...nconf.nr_ports - portdev->config.nr_ports) {
- err = add_port(portdev, portdev->config.nr_ports);
- if (err)
- break;
- portdev->config.nr_ports++;
- }
-}
-
static int init_vqs(struct ports_device *portdev)
{
vq_callback_t **io_callbacks;
@@ -1385,7 +1165,6 @@ static int __devinit virtcons_probe(stru
struct ports_device *portdev;
u32 i;
int err;
- bool multiport;
portdev = kmalloc(sizeof(*portdev), GFP_KERNEL);
if (!portdev) {
@@ -1411,32 +1190,8 @@ static int __devinit virtcons_probe(stru
goto free;
}
- multiport = false;
portdev->config.nr_ports = 1;
portdev->...
2010 Mar 30
3
[PATCH 4/4] virtio: disable multiport console support.
...nconf.nr_ports - portdev->config.nr_ports) {
- err = add_port(portdev, portdev->config.nr_ports);
- if (err)
- break;
- portdev->config.nr_ports++;
- }
-}
-
static int init_vqs(struct ports_device *portdev)
{
vq_callback_t **io_callbacks;
@@ -1385,7 +1165,6 @@ static int __devinit virtcons_probe(stru
struct ports_device *portdev;
u32 i;
int err;
- bool multiport;
portdev = kmalloc(sizeof(*portdev), GFP_KERNEL);
if (!portdev) {
@@ -1411,32 +1190,8 @@ static int __devinit virtcons_probe(stru
goto free;
}
- multiport = false;
portdev->config.nr_ports = 1;
portdev->...