search for: virtballoon_remove

...kin wrote: > On Thu, Nov 20, 2014 at 06:25:43PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > > > On Thu, Nov 20, 2014 at 05:03:17PM +0100, Petr Mladek wrote: > > > ... > > > > @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) > > > > { > > > > struct virtio_balloon *vb = vdev->priv; > > > > > > > > - kthread_stop(vb->thread); > > > > remove_common(vb); > > > > kfree(vb); > > > > } > > &gt...

...kin wrote: > On Thu, Nov 20, 2014 at 06:25:43PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > > > On Thu, Nov 20, 2014 at 05:03:17PM +0100, Petr Mladek wrote: > > > ... > > > > @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) > > > > { > > > > struct virtio_balloon *vb = vdev->priv; > > > > > > > > - kthread_stop(vb->thread); > > > > remove_common(vb); > > > > kfree(vb); > > > > } > > &gt...

...06:25:43PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > > > > > On Thu, Nov 20, 2014 at 05:03:17PM +0100, Petr Mladek wrote: > > > > > ... > > > > > > @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) > > > > > > { > > > > > > struct virtio_balloon *vb = vdev->priv; > > > > > > > > > > > > - kthread_stop(vb->thread); > > > > > > remove_common(vb); > > > >...

...06:25:43PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > > > > > On Thu, Nov 20, 2014 at 05:03:17PM +0100, Petr Mladek wrote: > > > > > ... > > > > > > @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) > > > > > > { > > > > > > struct virtio_balloon *vb = vdev->priv; > > > > > > > > > > > > - kthread_stop(vb->thread); > > > > > > remove_common(vb); > > > >...

On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > On Thu, Nov 20, 2014 at 05:03:17PM +0100, Petr Mladek wrote: > ... > > @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) > > { > > struct virtio_balloon *vb = vdev->priv; > > > > - kthread_stop(vb->thread); > > remove_common(vb); > > kfree(vb); > > } > > Shouldn't the work item be flushed before removal is complete? In f...

...hu, Nov 20, 2014 at 06:25:43PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > > > > On Thu, Nov 20, 2014 at 05:03:17PM +0100, Petr Mladek wrote: > > > > ... > > > > > @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) > > > > > { > > > > > struct virtio_balloon *vb = vdev->priv; > > > > > > > > > > - kthread_stop(vb->thread); > > > > > remove_common(vb); > > > > > kfree(vb); > &...

On Thu, Nov 20, 2014 at 11:07:46AM -0500, Tejun Heo wrote: > On Thu, Nov 20, 2014 at 05:03:17PM +0100, Petr Mladek wrote: > ... > > @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) > > { > > struct virtio_balloon *vb = vdev->priv; > > > > - kthread_stop(vb->thread); > > remove_common(vb); > > kfree(vb); > > } > > Shouldn't the work item be flushed before removal is complete? In f...

Hello, The main fix is to update the host with the current balloon value on module removal after deflating the balloon. Without the fix, the host has the wrong idea of the ballooned memory in the guest. This is patch 2. Patches 1 and 3 are cleanups with no effective code change. Please apply, Amit Shah (3): virtio: balloon: drop restore_common() virtio: balloon: let host know of updated

Hello, The main fix is to update the host with the current balloon value on module removal after deflating the balloon. Without the fix, the host has the wrong idea of the ballooned memory in the guest. This is patch 2. Patches 1 and 3 are cleanups with no effective code change. Please apply, Amit Shah (3): virtio: balloon: drop restore_common() virtio: balloon: let host know of updated

...ork, not sleep + queue work. Doing a sleep ties up one thread for 1/5 of a second, does it not? If so, as long as it's the only driver doing this, we'll be fine, but if many others copy this pattern, things will start to break, will they not? > > > @@ -563,7 +534,7 @@ static void virtballoon_remove(struct virtio_device *vdev) > > > struct virtio_balloon *vb = vdev->priv; > > > > > > unregister_oom_notifier(&vb->nb); > > > - kthread_stop(vb->thread); > > > + cancel_work_sync(&vb->wq_work); > > > > OK but since...

...ork, not sleep + queue work. Doing a sleep ties up one thread for 1/5 of a second, does it not? If so, as long as it's the only driver doing this, we'll be fine, but if many others copy this pattern, things will start to break, will they not? > > > @@ -563,7 +534,7 @@ static void virtballoon_remove(struct virtio_device *vdev) > > > struct virtio_balloon *vb = vdev->priv; > > > > > > unregister_oom_notifier(&vb->nb); > > > - kthread_stop(vb->thread); > > > + cancel_work_sync(&vb->wq_work); > > > > OK but since...

...nel/git/rusty/linux-2.6-for-linus.git master Christian Borntraeger (1): virtio: let header files include virtio_ids.h Christoph Hellwig (1): virtio_blk: revert QUEUE_FLAG_VIRT addition Rusty Russell (1): virtio_blk: Revert serial number support Uwe Kleine-K?nig (2): move virtballoon_remove to .devexit.text move virtrng_remove to .devexit.text Documentation/lguest/lguest.c | 1 - drivers/block/virtio_blk.c | 39 ++-------------------------------- drivers/char/hw_random/virtio-rng.c | 3 +- drivers/char/virtio_console.c | 1 - drivers/net/virtio_...

...nel/git/rusty/linux-2.6-for-linus.git master Christian Borntraeger (1): virtio: let header files include virtio_ids.h Christoph Hellwig (1): virtio_blk: revert QUEUE_FLAG_VIRT addition Rusty Russell (1): virtio_blk: Revert serial number support Uwe Kleine-K?nig (2): move virtballoon_remove to .devexit.text move virtrng_remove to .devexit.text Documentation/lguest/lguest.c | 1 - drivers/block/virtio_blk.c | 39 ++-------------------------------- drivers/char/hw_random/virtio-rng.c | 3 +- drivers/char/virtio_console.c | 1 - drivers/net/virtio_...

...RTIO_BALLOON_F_MUST_TELL_HOST, VIRTIO_BALLOON_F_STATS_VQ, @@ -675,6 +681,7 @@ static struct virtio_driver virtio_balloon_driver = { .driver.name = KBUILD_MODNAME, .driver.owner = THIS_MODULE, .id_table = id_table, + .validate = virtballoon_validate, .probe = virtballoon_probe, .remove = virtballoon_remove, .config_changed = virtballoon_changed, -- MST

...RTIO_BALLOON_F_MUST_TELL_HOST, VIRTIO_BALLOON_F_STATS_VQ, @@ -675,6 +681,7 @@ static struct virtio_driver virtio_balloon_driver = { .driver.name = KBUILD_MODNAME, .driver.owner = THIS_MODULE, .id_table = id_table, + .validate = virtballoon_validate, .probe = virtballoon_probe, .remove = virtballoon_remove, .config_changed = virtballoon_changed, -- MST

...read)) { > - err = PTR_ERR(vb->thread); > - goto out_del_vqs; > - } > - > return 0; > > -out_del_vqs: > - unregister_oom_notifier(&vb->nb); > out_oom_notify: > vdev->config->del_vqs(vdev); > out_free_vb: > @@ -563,7 +534,7 @@ static void virtballoon_remove(struct virtio_device *vdev) > struct virtio_balloon *vb = vdev->priv; > > unregister_oom_notifier(&vb->nb); > - kthread_stop(vb->thread); > + cancel_work_sync(&vb->wq_work); OK but since job requeues itself, cancelling like this might not be enough. >...

...read)) { > - err = PTR_ERR(vb->thread); > - goto out_del_vqs; > - } > - > return 0; > > -out_del_vqs: > - unregister_oom_notifier(&vb->nb); > out_oom_notify: > vdev->config->del_vqs(vdev); > out_free_vb: > @@ -563,7 +534,7 @@ static void virtballoon_remove(struct virtio_device *vdev) > struct virtio_balloon *vb = vdev->priv; > > unregister_oom_notifier(&vb->nb); > - kthread_stop(vb->thread); > + cancel_work_sync(&vb->wq_work); OK but since job requeues itself, cancelling like this might not be enough. >...

...t_free_vb; - vb->thread = kthread_run(balloon, vb, "vballoon"); - if (IS_ERR(vb->thread)) { - err = PTR_ERR(vb->thread); - goto out_del_vqs; - } - return 0; -out_del_vqs: - vdev->config->del_vqs(vdev); out_free_vb: kfree(vb); out: @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) { struct virtio_balloon *vb = vdev->priv; - kthread_stop(vb->thread); remove_common(vb); kfree(vb); } @@ -487,7 +470,7 @@ static int virtballoon_freeze(struct virtio_device *vdev) struct virtio_balloon *vb = vdev->priv; /* - * The kthread is alr...

...t_free_vb; - vb->thread = kthread_run(balloon, vb, "vballoon"); - if (IS_ERR(vb->thread)) { - err = PTR_ERR(vb->thread); - goto out_del_vqs; - } - return 0; -out_del_vqs: - vdev->config->del_vqs(vdev); out_free_vb: kfree(vb); out: @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) { struct virtio_balloon *vb = vdev->priv; - kthread_stop(vb->thread); remove_common(vb); kfree(vb); } @@ -487,7 +470,7 @@ static int virtballoon_freeze(struct virtio_device *vdev) struct virtio_balloon *vb = vdev->priv; /* - * The kthread is alr...

...something, immediately check for it in the next line (like you do throughout this patch ;) ) ... >> You are not freeing "vdev->priv". > > vdev->priv is vpmem which is allocated using devm API. I'm confused. Looking at drivers/virtio/virtio_balloon.c: static void virtballoon_remove(struct virtio_device *vdev) { struct virtio_balloon *vb = vdev->priv; ... kfree(vb); } I think you should do the same here, vdev->priv is allocated in virtio_pmem_probe. But maybe I am missing something important here :) >> >>> + nvdimm_bus_unregister(nvdimm_bus); >&...