search for: virstoragevolfree

...tFreeMemory ( virNodeGetInfo ( virResetLastError ( virSecretDefineXML ( virSecretFree ( virSecretGetUUIDString ( virSecretGetValue ( virSecretLookupByUsage ( virSecretLookupByUUIDString ( virSecretSetValue ( virSetErrorFunc ( virStoragePoolFree ( virStoragePoolGetInfo ( virStoragePoolLookupByName ( virStorageVolFree ( virStorageVolGetInfo ( virStorageVolGetPath ( virStorageVolLookupByName ( --rbKG8BlqS9xyY7Uh--

...nch-libvirt.c: https://github.com/libguestfs/libguestfs/blob/c9543de73d264943fef88f5e53403bbe32917b01/lib/launch-libvirt.c#L1372 AFAICT that way does not use the storage pool drivers. > > virStoragePoolFree ( > > virStoragePoolGetInfo ( > > virStoragePoolLookupByName ( > > virStorageVolFree ( > > virStorageVolGetInfo ( > > virStorageVolGetPath ( > > virStorageVolLookupByName ( > > So something in libguestfs is using storage pools, which would > mean you want libvirt-daemon-driver-storage-core, and one or > more of the pool impls that you use. This is w...

On Friday, 10 January 2020 17:34:27 CET Daniel P. Berrangé wrote: > > > > virStoragePoolFree ( > > > > virStoragePoolGetInfo ( > > > > virStoragePoolLookupByName ( > > > > virStorageVolFree ( > > > > virStorageVolGetInfo ( > > > > virStorageVolGetPath ( > > > > virStorageVolLookupByName ( > > > > > > So something in libguestfs is using storage pools, which would > > > mean you want libvirt-daemon-driver-storage-core, and...

...gluster/iscsi/etc, you don't need the storage pool APIs. If you're using domain <disk>s which use type=volume, then you'll need the storage pool APIs & any impls that are relevant > virStoragePoolFree ( > virStoragePoolGetInfo ( > virStoragePoolLookupByName ( > virStorageVolFree ( > virStorageVolGetInfo ( > virStorageVolGetPath ( > virStorageVolLookupByName ( So something in libguestfs is using storage pools, which would mean you want libvirt-daemon-driver-storage-core, and one or more of the pool impls that you use. Regards, Daniel -- |: https://berrange.com...

...fs/blob/c9543de73d264943fef88f5e53403bbe32917b01/lib/launch-libvirt.c#L1372 > > AFAICT that way does not use the storage pool drivers. YEs, that is correct. > > > virStoragePoolFree ( > > > virStoragePoolGetInfo ( > > > virStoragePoolLookupByName ( > > > virStorageVolFree ( > > > virStorageVolGetInfo ( > > > virStorageVolGetPath ( > > > virStorageVolLookupByName ( > > > > So something in libguestfs is using storage pools, which would > > mean you want libvirt-daemon-driver-storage-core, and one or > > more of the...

...to cleanup; + + filename = virStorageVolGetPath (vol); + if (filename == NULL) { + err = virGetLastError (); + error (g, _("cannot get the filename of the libvirt volume '%s': %s"), + volume_name, err->message); + goto cleanup; + } + + cleanup: + if (vol) virStorageVolFree (vol); + if (pool) virStoragePoolFree (pool); + + return filename; +} + #else /* no libvirt at compile time */ #define NOT_IMPL(r) \ -- 2.7.4

...to cleanup; + + filename = virStorageVolGetPath (vol); + if (filename == NULL) { + err = virGetLastError (); + error (g, _("cannot get the filename of the libvirt volume '%s': %s"), + volume_name, err->message); + goto cleanup; + } + + cleanup: + if (vol) virStorageVolFree (vol); + if (pool) virStoragePoolFree (pool); + + return filename; +} + #else /* no libvirt at compile time */ #define NOT_IMPL(r) \ diff --git a/tests/disks/test-qemu-drive-libvirt.sh b/tests/disks/test-qemu-drive-libvirt.sh index 215a99e.....

libguestfs usually needs qemu. However it only requires an emulator for the same architecture, not for all architectures. libvirt-daemon-kvm pulls in qemu which pulls in emulators for all architectures, as well as a bunch of other stuff we don't need at all like network interface support and nwfilter. There are no Fedora TCG-only arches, so drop the conditional section. I also made support

...ind libvirt volume ‘%s’: %s"), volname, err->message); virStoragePoolFree (pool); - virConnectClose (conn); caml_invalid_argument (errmsg); } @@ -353,12 +398,10 @@ v2v_vol_dumpxml (value connv, value poolnamev, value volnamev) volname, err->message); virStorageVolFree (vol); virStoragePoolFree (pool); - virConnectClose (conn); caml_invalid_argument (errmsg); } virStorageVolFree (vol); virStoragePoolFree (pool); - virConnectClose (conn); retv = caml_copy_string (xml); free (xml); @@ -367,11 +410,10 @@ v2v_vol_dumpxml (value connv, v...

...caml_invalid_argument (errmsg); - } - - xml = virStorageVolGetXMLDesc (vol, 0); - if (xml == NULL) { - err = virGetLastError (); - snprintf (errmsg, sizeof errmsg, - _("cannot fetch XML description of volume ‘%s’: %s"), - volname, err->message); - virStorageVolFree (vol); - virStoragePoolFree (pool); - virConnectClose (conn); - caml_invalid_argument (errmsg); - } - virStorageVolFree (vol); - virStoragePoolFree (pool); - virConnectClose (conn); - - retv = caml_copy_string (xml); - free (xml); - - CAMLreturn (retv); -} - -value -v2v_capabilities...

Hi, this is a mostly done attempt to switch to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not

Hi, this is a mostly done attempt to switch to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not

Hi, this is a mostly done attempt to switch to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not

Hi, this series switches virt-2v to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not test all

Hi, this series switches virt-2v to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not test all

...t", + sig => "pool, bool : unit" }, + { name => "virStoragePoolNumOfVolumes", + sig => "pool : int" }, + { name => "virStoragePoolListVolumes", + sig => "pool, int : string array" }, + + { name => "virStorageVolFree", sig => "vol : free" }, + { name => "virStorageVolDelete", + sig => "vol, uint : unit" }, + { name => "virStorageVolLookupByName", + sig => "pool, string : vol from pool" }, + { name => "virStorageVolL...

libvirt-ocaml is used only by virt-v2v, so move it to this repository, instead of having it around in the common submodule. The removal from common will happen later. Pino Toscano (2): common: Bundle the libvirt-ocaml library for use by virt-v2v build: switch embedded copy of libvirt-ocaml .gitignore | 2 + 3rdparty/libvirt-ocaml/Makefile.am |

...f (xml == NULL) { err = virGetLastError (); snprintf (errmsg, sizeof errmsg, - _("cannot fetch XML description of volume '%s': %s"), + _("cannot fetch XML description of volume ‘%s’: %s"), volname, err->message); virStorageVolFree (vol); virStoragePoolFree (pool); @@ -392,7 +392,7 @@ v2v_capabilities (value connv, value unitv) if (conn == NULL) { if (conn_uri) snprintf (errmsg, sizeof errmsg, - _("cannot open libvirt connection '%s'"), conn_uri); + _("c...