search for: virsecretgetvalue

...uuidstr); + if (sec == NULL) { + err = virGetLastError (); + error (g, _("no secret with UUID '%s': %s"), + uuidstr, err ? err->message : "(none)"); + continue; + } + + value = virSecretGetValue (sec, &value_size, 0); + if (value == NULL) { + err = virGetLastError (); + error (g, _("cannot get the value of the secret with UUID '%s': %s"), + uuidstr, err->message); + virSecretFree (sec); +...

Move the checks for empty xmlXPathObjectPtr, and for extracting the result string out of it, to a new helper functions. This is just code motion, there should be no behaviour changes. --- src/libvirt-domain.c | 122 +++++++++++++++++++++------------------------------ 1 file changed, 50 insertions(+), 72 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 4d4142d..baab307

...out( virEventRegisterDefaultImpl ( virEventRemoveTimeout( virEventRunDefaultImpl ( virGetLastError ( virGetVersion ( virInitialize ( virNetworkFree ( virNodeGetCellsFreeMemory ( virNodeGetFreeMemory ( virNodeGetInfo ( virResetLastError ( virSecretDefineXML ( virSecretFree ( virSecretGetUUIDString ( virSecretGetValue ( virSecretLookupByUsage ( virSecretLookupByUUIDString ( virSecretSetValue ( virSetErrorFunc ( virStoragePoolFree ( virStoragePoolGetInfo ( virStoragePoolLookupByName ( virStorageVolFree ( virStorageVolGetInfo ( virStorageVolGetPath ( virStorageVolLookupByName ( --rbKG8BlqS9xyY7Uh--

libguestfs usually needs qemu. However it only requires an emulator for the same architecture, not for all architectures. libvirt-daemon-kvm pulls in qemu which pulls in emulators for all architectures, as well as a bunch of other stuff we don't need at all like network interface support and nwfilter. There are no Fedora TCG-only arches, so drop the conditional section. I also made support

...RROR (r == -1, "virSecretSetValue"); + + CAMLreturn (Val_unit); +} + +CAMLprim value +ocaml_libvirt_secret_get_value (value secv) +{ + CAMLparam1 (secv); + CAMLlocal1 (rv); + virSecretPtr sec = Secret_val (secv); + unsigned char *secval; + size_t size = 0; + + NONBLOCKING (secval = virSecretGetValue (sec, &size, 0)); + CHECK_ERROR (secval == NULL, "virSecretGetValue"); + + rv = caml_alloc_string (size); + memcpy (String_val (rv), secval, size); + free (secval); + + CAMLreturn (rv); +} + +/*----------------------------------------------------------------------*/ + +CAMLprim v...

...o secret with UUID '%s': %s"), + error (g, _("no secret with UUID ‘%s’: %s"), uuidstr, err ? err->message : "(none)"); continue; } @@ -622,7 +622,7 @@ for_each_disk (guestfs_h *g, value = virSecretGetValue (sec, &value_size, 0); if (value == NULL) { err = virGetLastError (); - error (g, _("cannot get the value of the secret with UUID '%s': %s"), + error (g, _("cannot get the value of the secret with UUID ‘%s’: %s"),...

libvirt-ocaml is used only by virt-v2v, so move it to this repository, instead of having it around in the common submodule. The removal from common will happen later. Pino Toscano (2): common: Bundle the libvirt-ocaml library for use by virt-v2v build: switch embedded copy of libvirt-ocaml .gitignore | 2 + 3rdparty/libvirt-ocaml/Makefile.am |

Hi, this is a mostly done attempt to switch to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not

Hi, this is a mostly done attempt to switch to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not

Hi, this series switches virt-2v to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not test all

Hi, this series switches virt-2v to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not test all