search for: virgetversion

Use libvirt to set up the user network instead of a custom qemu argument. Note this requires a non-upstream patch being discussed on the libvirt mailing list at the moment. https://bugzilla.redhat.com/show_bug.cgi?id=1075520#c6 Rich.

...d *datav, const char *libvirt_uri) int r; uint32_t size; CLEANUP_FREE void *buf = NULL; + unsigned long version_number; params.current_proc_is_root = geteuid () == 0; @@ -262,13 +263,16 @@ launch_libvirt (guestfs_h *g, void *datav, const char *libvirt_uri) return -1; } - virGetVersion (&data->libvirt_version, NULL, NULL); - debug (g, "libvirt version = %lu (%lu.%lu.%lu)", - data->libvirt_version, - data->libvirt_version / 1000000UL, - data->libvirt_version / 1000UL % 1000UL, - data->libvirt_version % 1000UL); - if (d...

...e "guestfs.h" -#include "guestfs-internal-frontend.h" - -int -main (int argc, char *argv[]) -{ - unsigned long ver; - guestfs_h *g; - - virInitialize (); - - /* Check that the version of libvirt we are linked against - * supports the new test-driver auth feature. - */ - virGetVersion (&ver, NULL, NULL); - if (ver < 1002001) { - fprintf (stderr, "%s: test skipped because libvirt is too old (%lu)\n", - argv[0], ver); - exit (77); - } - - g = guestfs_create (); - if (!g) - exit (EXIT_FAILURE); - - /* This will ask the user for credentials...

...( virDomainMigrate ( virDomainPinVcpu ( virDomainRef( virDomainSetMaxMemory ( virDomainSetMemory ( virDomainSetSchedulerParameters ( virDomainSetVcpus ( virDomainStatsRecordListFree ( virEventAddTimeout( virEventRegisterDefaultImpl ( virEventRemoveTimeout( virEventRunDefaultImpl ( virGetLastError ( virGetVersion ( virInitialize ( virNetworkFree ( virNodeGetCellsFreeMemory ( virNodeGetFreeMemory ( virNodeGetInfo ( virResetLastError ( virSecretDefineXML ( virSecretFree ( virSecretGetUUIDString ( virSecretGetValue ( virSecretLookupByUsage ( virSecretLookupByUUIDString ( virSecretSetValue ( virSetErrorFunc ( v...

Hi, test-qemu-drive-libvirt.sh fails to run with libvirt < 1.1.3, because the <test:runstate> attribute (used to keep the domains shut off) has been introduced in that libvirt version. Create a small (uninstalled) C tool which just does this version check, to be used in all the tests (just one, so far) written in shell/scripting language. Pino Toscano (2): tests: add a a simple

...t_get_version (value unitv) +{ + CAMLparam1 (unitv); + CAMLlocal1 (rv); + int major, minor, release; + /* We have to assemble the error on the stack because a dynamic + * string couldn't be freed. + */ + char errmsg[ERROR_MESSAGE_LEN]; + unsigned long ver; + virErrorPtr err; + + if (virGetVersion (&ver, NULL, NULL) == -1) { + err = virGetLastError (); + snprintf (errmsg, sizeof errmsg, + _("cannot get libvirt library version: %s"), + err->message); + caml_invalid_argument (errmsg); + } + + major = ver / 1000000UL; + minor = ver / 1000UL...

libguestfs usually needs qemu. However it only requires an emulator for the same architecture, not for all architectures. libvirt-daemon-kvm pulls in qemu which pulls in emulators for all architectures, as well as a bunch of other stuff we don't need at all like network interface support and nwfilter. There are no Fedora TCG-only arches, so drop the conditional section. I also made support

Hi, this adds an helper version struct, and uses it in the backends (for the libvirt and qemu versions) and inspection code. This also moves common code to that, so it is not repeated in many places. This should help with the small refactoring proposed with https://www.redhat.com/archives/libguestfs/2016-May/msg00070.html Thanks, Pino Toscano (2): src: start unifying version handling

Hi, this adds an helper version struct, and uses it in the backends (for the libvirt and qemu versions) and inspection code. This also moves common code to that, so it is not repeated in many places. This should help with the small refactoring proposed with https://www.redhat.com/archives/libguestfs/2016-May/msg00070.html Thanks, Pino Toscano (2): src: start unifying version handling

...matting mistakes in doc (Michal Privoznik) - mention C89 syntax preferences (Eric Blake) - document recent hook additions (Eric Blake) - Update on the goal page (Daniel Veillard) - Document first release with spice and qxl (Cole Robinson) - Add schema definition for imagelabel (Osier Yang) - update virGetVersion description (Tiziano Mueller) - Improve logging documentation including the debug buffer (Daniel Veillard) - update windows page for initial libvirt 0.8.8 installer (Justin Clift) - formatdomain.html.in: Fix spelling PIC->PCI (Philipp Hahn) - fix missing </p> (Eric Blake) - documenting the...

...t_get_version (value unitv) -{ - CAMLparam1 (unitv); - CAMLlocal1 (rv); - int major, minor, release; - /* We have to assemble the error on the stack because a dynamic - * string couldn't be freed. - */ - char errmsg[ERROR_MESSAGE_LEN]; - unsigned long ver; - virErrorPtr err; - - if (virGetVersion (&ver, NULL, NULL) == -1) { - err = virGetLastError (); - snprintf (errmsg, sizeof errmsg, - _("cannot get libvirt library version: %s"), - err->message); - caml_invalid_argument (errmsg); - } - - major = ver / 1000000UL; - minor = ver / 1000UL...

Hi, this is a mostly done attempt to switch to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not

Hi, this is a mostly done attempt to switch to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not

Hi, this is a mostly done attempt to switch to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not

Hi, this series switches virt-2v to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not test all

Hi, this series switches virt-2v to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not test all

...-auth-callbacks.c b/tests/events/test-libvirt-auth-callbacks.c index 86e26f8..a18ab24 100644 --- a/tests/events/test-libvirt-auth-callbacks.c +++ b/tests/events/test-libvirt-auth-callbacks.c @@ -55,22 +55,17 @@ main (int argc, char *argv[]) * supports the new test-driver auth feature. */ virGetVersion (&ver, NULL, NULL); - if (ver < 1002001) { - fprintf (stderr, "%s: test skipped because libvirt is too old (%lu)\n", - argv[0], ver); - exit (77); - } + if (ver < 1002001) + error (77, 0, "test skipped because libvirt is too old (%lu)", ver);...

...prim value +ocaml_libvirt_get_version (value driverv, value unit) +{ + CAMLparam2 (driverv, unit); + CAMLlocal1 (rv); + const char *driver = Optstring_val (driverv); + unsigned long libVer, typeVer = 0, *typeVer_ptr; + int r; + + typeVer_ptr = driver ? &typeVer : NULL; + NONBLOCKING (r = virGetVersion (&libVer, driver, typeVer_ptr)); + CHECK_ERROR (r == -1, "virGetVersion"); + + rv = caml_alloc_tuple (2); + Store_field (rv, 0, Val_int (libVer)); + Store_field (rv, 1, Val_int (typeVer)); + CAMLreturn (rv); +} + +/*----------------------------------------------------------------...

libvirt-ocaml is used only by virt-v2v, so move it to this repository, instead of having it around in the common submodule. The removal from common will happen later. Pino Toscano (2): common: Bundle the libvirt-ocaml library for use by virt-v2v build: switch embedded copy of libvirt-ocaml .gitignore | 2 + 3rdparty/libvirt-ocaml/Makefile.am |

Wherever we had code which did: if (something_bad) { perror (...); exit (EXIT_FAILURE); } replace this with use of the error(3) function: if (something_bad) error (EXIT_FAILURE, errno, ...); The error(3) function is supplied by glibc, or by gnulib on platforms which don't have it, and is much more flexible than perror(3). Since we already use error(3), there seems to be