search for: virgetlasterror

Hi, As the subject line indicates, when I'm calling virDomainCreate() to start a defined domain, and that command fails because the domain is already running at that point, virGetLastError() will return NULL, instead of a proper pointer to an error code. Libvirt will, however, print an error to the console: libvir: QEMU error : Requested operation is not valid: domain is already running This looks like a bug to me, and I'm fairly certain that earlier version would return an...

good day to all. i still have not solved my problem with event handling. currently i have following code void libvirt_eventloop_thr_func() { while(true) //TODO: stop somehow on exit { if(virEventRunDefaultImpl() < 0) { virErrorPtr err = virGetLastError(); fprintf(stderr, "Failed to run event loop: %s\n", err && err->message ? err->message : "Unknown error"); } } } ... virSetErrorFunc(NULL, libvirt_error_handler); libvirt_connection = virConnectOpen("qemu:///system"); if (virEventRegisterDe...

...ing. >> currently i have following code >> >> >> void libvirt_eventloop_thr_func() >> { >> while(true) //TODO: stop somehow on exit >> { >> if(virEventRunDefaultImpl() < 0) >> { >> virErrorPtr err = virGetLastError(); >> fprintf(stderr, "Failed to run event loop: %s\n", err && >> err->message ? err->message : "Unknown error"); >> } >> } >> } >> >> >> >> ... >> >> virSetErrorFunc(...

...>> >>>> void libvirt_eventloop_thr_func() >>>> { >>>> while(true) //TODO: stop somehow on exit >>>> { >>>> if(virEventRunDefaultImpl() < 0) >>>> { >>>> virErrorPtr err = virGetLastError(); >>>> fprintf(stderr, "Failed to run event loop: %s\n", err && >>>> err->message ? err->message : "Unknown error"); >>>> } >>>> } >>>> } >>>> >>>> >&g...

...const char *pool_name, const char *volume_name) +{ + char *filename = NULL; + virErrorPtr err; + virStoragePoolPtr pool = NULL; + virStorageVolPtr vol = NULL; + virStorageVolInfo info; + int ret; + + pool = virStoragePoolLookupByName (conn, pool_name); + if (pool == NULL) { + err = virGetLastError (); + error (g, _("no libvirt pool called '%s': %s"), + pool_name, err->message); + goto cleanup; + } + + vol = virStorageVolLookupByName (pool, volume_name); + if (vol == NULL) { + err = virGetLastError (); + error (g, _("no volume called '%s&...

...r handler > in the second thread appears to have reset itself back to the default > error handler). I haven't yet worked out a better way to solve this. Do you have a feeling whether the error handler function push/pop is a commonly used feature or not ? In libvirt we originally had virGetLastError (global error) virConnGetLastError (per connection error) virSetErrorFunc (global error handler func) When we introduced thread support we didn't try to make the virConnGetLastError/SetErrorFun work. We just updated the docs to tell applications to /never/ use them in threaded appl...

.... We cannot open the connection + * in read-only mode (VIR_CONNECT_RO), as that kind of connection + * is considered untrusted, and thus libvirt will prevent to read + * the values of secrets. + */ + conn = guestfs_int_open_libvirt_connection (g, libvirturi, 0); if (!conn) { err = virGetLastError (); error (g, _("could not connect to libvirt (code %d, domain %d): %s"), @@ -163,7 +169,7 @@ guestfs_impl_add_domain (guestfs_h *g, const char *domain_name, return r; } -static int add_disk (guestfs_h *g, const char *filename, const char *format, int readonly, const char *prot...

Move the checks for empty xmlXPathObjectPtr, and for extracting the result string out of it, to a new helper functions. This is just code motion, there should be no behaviour changes. --- src/libvirt-domain.c | 122 +++++++++++++++++++++------------------------------ 1 file changed, 50 insertions(+), 72 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 4d4142d..baab307

...const char *pool_name, const char *volume_name) +{ + char *filename = NULL; + virErrorPtr err; + virStoragePoolPtr pool = NULL; + virStorageVolPtr vol = NULL; + virStorageVolInfo info; + int ret; + + pool = virStoragePoolLookupByName (conn, pool_name); + if (pool == NULL) { + err = virGetLastError (); + error (g, _("no libvirt pool called '%s': %s"), + pool_name, err->message); + goto cleanup; + } + + vol = virStorageVolLookupByName (pool, volume_name); + if (vol == NULL) { + err = virGetLastError (); + error (g, _("no volume called '%s&...

...rDomainDestroy(), I come across a domain that is already stopped. (For example when someone already stopped the domain manually using virsh or because the guest OS issued a shutdown.) This is a special case that I absolutely need to catch and handle. Unfortunately, when this happens, and I call virGetLastError() afterwards, I always just get the error code VIR_ERR_OPERATION_INVALID, which doesn't look very precise to me... Two questions about this: Is the domain not running at that moment the only possible condition that can trigger this particular error code when calling virDomainDestroy()? Ca...

...event_handler(virConnectPtr conn, virDomainPtr dom, int event, int detail, void * opaque) { std::cout<<"domain event handler called\n"; } void libvirt_eventloop_thr_func() { while(true) //TODO: stop somehow on exit { if(virEventRunDefaultImpl() < 0) { virErrorPtr err = virGetLastError(); fprintf(stderr, "Failed to run event loop: %s\n", err && err->message ? err->message : "Unknown error"); } } } .... virSetErrorFunc(NULL, libvirt_error_handler); libvirt_connection = virConnectOpen("qemu:///system"); if(libvirt_connection =...

...not implemented, fall back to - * virDomainGetInfo. See equivalent code in virsh. - */ -static int -get_dom_state (virDomainPtr dom) -{ - int state, reason; - virErrorPtr err; - virDomainInfo info; - - if (virDomainGetState (dom, &state, &reason, 0) == 0) - return state; - - err = virGetLastError (); - if (!err || err->code != VIR_ERR_NO_SUPPORT) - return -1; - - if (virDomainGetInfo (dom, &info) == 0) - return info.state; - - return -1; -} - -/* See lib/libvirt-auth.c for why we need this. */ -static int -libvirt_auth_default_wrapper (virConnectCredentialPtr cred, -...

...e not solved my problem with event handling. > currently i have following code > > > void libvirt_eventloop_thr_func() > { > while(true) //TODO: stop somehow on exit > { > if(virEventRunDefaultImpl() < 0) > { > virErrorPtr err = virGetLastError(); > fprintf(stderr, "Failed to run event loop: %s\n", err && > err->message ? err->message : "Unknown error"); > } > } > } > > > > ... > > virSetErrorFunc(NULL, libvirt_error_handler); > libvi...

...lowing code >>> >>> >>> void libvirt_eventloop_thr_func() >>> { >>> while(true) //TODO: stop somehow on exit >>> { >>> if(virEventRunDefaultImpl() < 0) >>> { >>> virErrorPtr err = virGetLastError(); >>> fprintf(stderr, "Failed to run event loop: %s\n", err && >>> err->message ? err->message : "Unknown error"); >>> } >>> } >>> } >>> >>> >>> >>> ... >&g...

...t; void libvirt_eventloop_thr_func() >>>>> { >>>>> while(true) //TODO: stop somehow on exit >>>>> { >>>>> if(virEventRunDefaultImpl() < 0) >>>>> { >>>>> virErrorPtr err = virGetLastError(); >>>>> fprintf(stderr, "Failed to run event loop: %s\n", err && >>>>> err->message ? err->message : "Unknown error"); >>>>> } >>>>> } >>>>> } >>>>> &...

...er the error handler function push/pop > is a commonly used feature or not ? All the time, in our code: $ git grep -E 'guestfs_(push|pop)_error_handler' -- *.c | wc -l 83 Of course we could change those, but it is still an API guarantee. > In libvirt we originally had > > virGetLastError (global error) > virConnGetLastError (per connection error) > virSetErrorFunc (global error handler func) > > When we introduced thread support we didn't try to make the > virConnGetLastError/SetErrorFun work. We just updated the docs > to tell applications to /ne...

Hi, When using « virsh attach-device ....." to add a channel device to a Guest , I see following entry in libvirt log : 2015-12-07 11:14:47.307+0000: 14551: debug : virDomainAttachDeviceFlags:10433 : dom=0x7f2a58252fc0, ........ Great !! But , when calling virDomainAttachDeviceFlags( ) from a C program , I got return code -1 but nothing appears related to virDomainAttachDeviceFlags(

...tested. src/libvirtdomain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libvirtdomain.c b/src/libvirtdomain.c index eecea26..110ee86 100644 --- a/src/libvirtdomain.c +++ b/src/libvirtdomain.c @@ -104,6 +104,8 @@ guestfs__add_domain (guestfs_h *g, const char *domain_name, err = virGetLastError (); error (g, _("could not connect to libvirt (code %d, domain %d): %s"), err->code, err->domain, err->message); + if (err->code == VIR_ERR_AUTH_FAILED) + error (g, _("Possible fix: 'polkit-auth --user <username> --grant org.libvirt.unix...

...flags = check_for_errors ? VIR_DOMAIN_DESTROY_GRACEFUL : 0; + virErrorPtr err; + + again: + debug (g, "calling virDomainDestroy flags=%s", + check_for_errors ? "VIR_DOMAIN_DESTROY_GRACEFUL" : "0"); + if (virDomainDestroyFlags (dom, flags) == -1) { + err = virGetLastError (); + + /* Second chance if we're just waiting for qemu to shut down. See: + * https://www.redhat.com/archives/libvir-list/2016-January/msg00767.html + */ + if ((flags & VIR_DOMAIN_DESTROY_GRACEFUL) && + err && err->code == VIR_ERR_SYSTEM_ERROR &...

https://bugzilla.redhat.com/show_bug.cgi?id=912499 (especially comments 7 & 10) This patch set is the final fix so that we can access disks in use by other guests when SELinux and sVirt are enabled. Previously such disks were inaccessible because sVirt labels the disks with a random SELinux label to prevent other instances of qemu from being able to read them. So naturally the libguestfs