search for: vircommand

...- build: fix VIR_DEBUG on mingw (Eric Blake) - build: generate files when building without libvirtd (Wen Congyang) - build: drop unused sys/syslimits.h header (Eric Blake) - Fix prototype of virRun for Win32 targets (Daniel P. Berrange) - build: tolerate unlimited group size (Eric Blake) - Disable virCommandExec on Win32 (Daniel P. Berrange) - command: Fix compilation on FreeBSD (Matthias Bolte) - apparmor: Fix compilation by removing remains from virCommand conversion (Matthias Bolte) - configure: Fix mpath check on non-Linux systems (Matthias Bolte) - fix xdr detection and use with recent glibc (Chri...

...IG_DFL for all signals, but also just as > importantly, the signal mask. It should be set to all ones before calling > fork, and set back to all zeroes immedaitely before execve, as illustrated > in libvirt to avoid races: > > https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/util/vircommand.c;h=de937f6f9aa91abb518eac98bfac9dcf37e1f5df;hb=HEAD#l304 > > https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/util/vircommand.c;h=de937f6f9aa91abb518eac98bfac9dcf37e1f5df;hb=HEAD#l360 This is absolutely right. What's interesting and new here is that collectd is actually using dlope...

Peter Dimitrov and myself were debugging a very peculiar bug when libguestfs is run as a plugin from collectd: https://www.redhat.com/archives/libguestfs/2018-November/thread.html#00023 The long story short is that collectd leaks SIGCHLD == SIG_IGN setting into plugins: https://www.redhat.com/archives/libguestfs/2018-November/msg00095.html This means that any plugin that does the usual

...means not only setting SIG_DFL for all signals, but also just as importantly, the signal mask. It should be set to all ones before calling fork, and set back to all zeroes immedaitely before execve, as illustrated in libvirt to avoid races: https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/util/vircommand.c;h=de937f6f9aa91abb518eac98bfac9dcf37e1f5df;hb=HEAD#l304 https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/util/vircommand.c;h=de937f6f9aa91abb518eac98bfac9dcf37e1f5df;hb=HEAD#l360 Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://li...

Here are strace outputs per process. strace_output.22076 is the plugin's pid. (A little before forking) strace_output.22077 runs qemu-img strace_output.22078 is a mystery to me strace_output.22079 is rm -rf to the overlay image and its temporary dir. Best Regards, Peter On Wed, Nov 7, 2018 at 4:38 PM Richard W.M. Jones <rjones@redhat.com> wrote: > On Wed, Nov 07, 2018 at

Hi, Ever since I recently upgraded to Fedora 25, I can't get kvm working. It's worked on this system since initial fedora 20 install. All upgrades were done via yum, then once available, dnf. I do have libvirt-sock in LISTENING state: STREAM LISTENING /var/run/libvirt/libvirt-sock I noticed I also have multiple connections in CONNECTING state: STREAM CONNECTING 0

...out>, >nfds=<optimized out>, timeout=<optimized out>, fdslen=<optimized out>) >at poll_chk.c:27 >No locals. >#2 0x00007fcd6f07bf41 in poll (__timeout=-1, __nfds=<optimized out>, >__fds=0x7fcd3bf16ec0) at /usr/include/bits/poll2.h:41 >No locals. >#3 virCommandProcessIO (cmd=cmd@entry=0x7fcd344228f0) at >util/vircommand.c:2049 > i = <optimized out> > fds = {{fd = 22, events = 1, revents = 0}, {fd = 24, events = >1, revents = 0}, {fd = 1802946632, events = 32717, revents = 0}} > nfds = <optimized out> >...

...his is a bug in collectd. It's surprisingly hard to correctly fork a process in Unix. Here's what libvirt does, which is the most comprehensive code that I know of. It involves resetting multiple things before running the child: https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/util/vircommand.c;h=de937f6f9aa91abb518eac98bfac9dcf37e1f5df;hb=HEAD#l280 While you're getting the collectd bug fixed, the easiest workaround is probably to add: signal (SIGCHLD, SIG_DFL); in your code. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my progr...

...hk (fds=<optimized out>, nfds=<optimized out>, timeout=<optimized out>, fdslen=<optimized out>) at poll_chk.c:27 #2 0x00007fcf4e10f281 in poll (__timeout=-1, __nfds=<optimized out>, __fds=0x7fcf3b3143b0) at /usr/include/x86_64-linux-gnu/bits/poll2.h:41 #3 virCommandProcessIO (cmd=cmd@entry=0x7fcf34015d30) --Type <return> to continue, or q <return> to quit--- at util/vircommand.c:2085 #4 0x00007fcf4e1134ea in virCommandRun (cmd=0x7fcf34015d30, exitstatus=exitstatus@entry=0x7fcf3b314924) at util/vircommand.c:2316 #5 0x00007fcf3e239fca in vi...

...have a question when I reading the libvirt source codes. I have known the process of how libvirt start/manage qemu, since I need to write a driver based on libvirt. But one thing also confused, please give me some tips. 1. In qemu_command.c, there is a function call "cmd = virCommandNewArgList(emulator, "-S", NULL);", which initializes pointer "cmd". However, I don't find the initial value of "cmd->args", which represents the input of virFindFileInPath in Util.c. Through virFindFileInPath, one could find a requested executable file in t...

...ed out>, timeout=<optimized out>, fdslen=<optimized out>) >> at poll_chk.c:27 >> No locals. >> #2 0x00007fcd6f07bf41 in poll (__timeout=-1, __nfds=<optimized out>, >> __fds=0x7fcd3bf16ec0) at /usr/include/bits/poll2.h:41 >> No locals. >> #3 virCommandProcessIO (cmd=cmd@entry=0x7fcd344228f0) at >> util/vircommand.c:2049 >> i = <optimized out> >> fds = {{fd = 22, events = 1, revents = 0}, {fd = 24, events = >> 1, revents = 0}, {fd = 1802946632, events = 32717, revents = 0}} >> nfds = <...

...tory name (Daniel P. Berrange) - qemu: Ignore unusable binaries (Jiri Denemark) Improvements: - maint: detect clang 2.9 (Eric Blake) - qemu: update qemuCgroupControllerActive signature (Eric Blake) - lxc: report correct error (Eric Blake) - libxl: avoid compiler warning (Eric Blake) - storage: use virCommand to avoid compiler warning (Eric Blake) - tests: Lower stack usage below 4096 bytes (Matthias Bolte) - tests: Update valgrind suppressions file (Matthias Bolte) - tests: simplify common setup (Eric Blake) - network: fix return value of hostsFileWrite (Laine Stump) - libvirt/qemu - support persistent...

Inspired by libvirt's virCommand* internal mini-library, this adds some internal APIs for running commands. The first patch contains the new APIs. The subsequent patches change various parts of the library over to use it. Rich.