search for: vir_domain_device_modify_live

Hi, According to the docs on http://libvirt.org/html/libvirt-libvirt.html#virDomainDetachDeviceFlags I ought to be able to do virDomainDetachDeviceFlags( <domain>, <devicexml>, VIR_DOMAIN_DEVICE_MODIFY_LIVE | VIR_DOMAIN_DEVICE_MODIFY_CONFIG); to detach a volume both from a currently running VM instance and permanently from the defined config file. If I actually try that, though, I'm getting this error: libvir: QEMU error : Requested operation is not valid: cannot modify the persistent configu...

Here is v11. Fixed comments/bugs and updated against the latest libvirt.git. Changes v10->v11: - fixed comments on each patches - fixed cgroup handling in patch 3. - fixed MODIFY_CURRENT handling in patch 4. most of diff comes from refactoring qemu/qemu_driver.c -- conf/domain_conf.c | 40 ++ conf/domain_conf.h | 5 libvirt_private.syms | 3 qemu/qemu_driver.c | 727

...and XML + * in atomic, limiting modification as only-acrive and + * only-inactive. Need some idea to update both at the same time. + */ + return qemuDomainModifyDevicePersistent(dom, xml, 1); } - return qemudDomainAttachDevice(dom, xml); + if (flags & VIR_DOMAIN_DEVICE_MODIFY_LIVE) + return qemudDomainAttachDevice(dom, xml); + + return -1; } @@ -4304,9 +4462,7 @@ static int qemudDomainDetachDeviceFlags(virDomainPtr dom, const char *xml, unsigned int flags) { if (flags &...

This rounds off hotplugging support by allowing you to add and remove drives at any stage (before and after launch). Rich.

This is, I guess, version 3 of this patch series which adds disk labels and hotplugging (only hot-add implemented so far). The good news is .. it works! Rich.