search for: vio_le

...dentally changed the virtio_net header used by > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > Hi David, Oops my bad... I obviously overlooked this one when adding cross-endian support. > Since virtio_legacy_is_little_endian() is a very long identifier, > define a VIO_LE macro and use that throughout the code instead of the VIO usually refers to virtual IO adapters for the PowerPC pSeries platform. > hard-coded 'false' for little-endian. > What about introducing dedicated accessors as it is done in many other locations where we do virtio byteswap...

...dentally changed the virtio_net header used by > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > Hi David, Oops my bad... I obviously overlooked this one when adding cross-endian support. > Since virtio_legacy_is_little_endian() is a very long identifier, > define a VIO_LE macro and use that throughout the code instead of the VIO usually refers to virtual IO adapters for the PowerPC pSeries platform. > hard-coded 'false' for little-endian. > What about introducing dedicated accessors as it is done in many other locations where we do virtio byteswap...

...82410950aa ("virtio: add explicit big-endian support to memory > accessors") accidentally changed the virtio_net header used by > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > > Since virtio_legacy_is_little_endian() is a very long identifier, > define a VIO_LE macro and use that throughout the code instead of the > hard-coded 'false' for little-endian. > > This restores the ABI to match 4.1 and earlier kernels, and makes my > test program work again. > > Signed-off-by: David Woodhouse <David.Woodhouse at intel.com> I...

...82410950aa ("virtio: add explicit big-endian support to memory > accessors") accidentally changed the virtio_net header used by > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > > Since virtio_legacy_is_little_endian() is a very long identifier, > define a VIO_LE macro and use that throughout the code instead of the > hard-coded 'false' for little-endian. > > This restores the ABI to match 4.1 and earlier kernels, and makes my > test program work again. > > Signed-off-by: David Woodhouse <David.Woodhouse at intel.com> I...

...; > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > > > > Hi David, > > Oops my bad... I obviously overlooked this one when adding cross-endian > support. > > > Since virtio_legacy_is_little_endian() is a very long identifier, > > define a VIO_LE macro and use that throughout the code instead of the > > VIO usually refers to virtual IO adapters for the PowerPC pSeries platform. > > > hard-coded 'false' for little-endian. > > > > What about introducing dedicated accessors as it is done in many other &gt...

...cket/af_packet.c index b9e1a13..3d555c7 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -1976,7 +1976,7 @@ static int packet_rcv_vnet(struct msghdr *msg, const struct sk_buff *skb, return -EINVAL; *len -= sizeof(vnet_hdr); - if (virtio_net_hdr_from_skb(skb, &vnet_hdr, vio_le())) + if (virtio_net_hdr_from_skb(skb, &vnet_hdr, vio_le(), true)) return -EINVAL; return memcpy_to_msg(msg, (void *)&vnet_hdr, sizeof(vnet_hdr)); @@ -2237,7 +2237,7 @@ static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev, if (po->has_vnet_hdr) { if (virtio_net_...

...cket/af_packet.c index b9e1a13..3d555c7 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -1976,7 +1976,7 @@ static int packet_rcv_vnet(struct msghdr *msg, const struct sk_buff *skb, return -EINVAL; *len -= sizeof(vnet_hdr); - if (virtio_net_hdr_from_skb(skb, &vnet_hdr, vio_le())) + if (virtio_net_hdr_from_skb(skb, &vnet_hdr, vio_le(), true)) return -EINVAL; return memcpy_to_msg(msg, (void *)&vnet_hdr, sizeof(vnet_hdr)); @@ -2237,7 +2237,7 @@ static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev, if (po->has_vnet_hdr) { if (virtio_net_...

...55c7 100644 > --- a/net/packet/af_packet.c > +++ b/net/packet/af_packet.c > @@ -1976,7 +1976,7 @@ static int packet_rcv_vnet(struct msghdr *msg, const struct sk_buff *skb, > return -EINVAL; > *len -= sizeof(vnet_hdr); > > - if (virtio_net_hdr_from_skb(skb, &vnet_hdr, vio_le())) > + if (virtio_net_hdr_from_skb(skb, &vnet_hdr, vio_le(), true)) > return -EINVAL; > > return memcpy_to_msg(msg, (void *)&vnet_hdr, sizeof(vnet_hdr)); > @@ -2237,7 +2237,7 @@ static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev, > if (po->has_...

Hi, This patches introduce virtio_net_hdr_{from,to}_skb functions for conversion of GSO information between skb and virtio_net_hdr. Mike Rapoport (6): virtio_net: add _UAPI prefix to virtio_net header guards virtio_net: introduce virtio_net_hdr_{from,to}_skb macvtap: use common code for virtio_net_hdr and skb GSO conversion tuntap: use common code for virtio_net_hdr and skb GSO

Hi, This patches introduce virtio_net_hdr_{from,to}_skb functions for conversion of GSO information between skb and virtio_net_hdr. Mike Rapoport (6): virtio_net: add _UAPI prefix to virtio_net header guards virtio_net: introduce virtio_net_hdr_{from,to}_skb macvtap: use common code for virtio_net_hdr and skb GSO conversion tuntap: use common code for virtio_net_hdr and skb GSO

From: David Woodhouse <dwmw2 at infradead.org> Date: Wed, 23 Sep 2015 15:44:30 +0100 > +#define VIO_LE virtio_legacy_is_little_endian() When you define a shorthand macro, the defines to a function call, make the macro have parenthesis too.

From: David Woodhouse <dwmw2 at infradead.org> Date: Wed, 23 Sep 2015 15:44:30 +0100 > +#define VIO_LE virtio_legacy_is_little_endian() When you define a shorthand macro, the defines to a function call, make the macro have parenthesis too.