search for: vidmem_bindings

...vice *dev) > return NULL; > pscreen = &screen->base.base; > > + /* Recognize chipsets with no VRAM */ > + switch (dev->chipset) { > + /* GK20A */ > + case 0xea: > + screen->base.vram_domain = NOUVEAU_BO_GART; I think you also want to set vidmem_bindings = 0... although potentially after the |= that's done below. Although I guess that constbuf + command args buf need to be |='d into the sysmem_bindings for this to work out well. That said, we don't really handle explicit migration well right now, and those PIPE_BIND_* are *incredibly* m...

...uffer->domain = NV_VRAM_DOMAIN(screen); > break; > case PIPE_USAGE_STAGING: > case PIPE_USAGE_STREAM: > @@ -676,7 +674,7 @@ nouveau_buffer_create(struct pipe_screen *pscreen, > } > } else { > if (buffer->base.bind & screen->vidmem_bindings) > - buffer->domain = NOUVEAU_BO_VRAM; > + buffer->domain = NV_VRAM_DOMAIN(screen); > else > if (buffer->base.bind & screen->sysmem_bindings) > buffer->domain = NOUVEAU_BO_GART; Both of these changes should be unnecessary if...

...t;> pscreen = &screen->base.base; >> >> + /* Recognize chipsets with no VRAM */ >> + switch (dev->chipset) { >> + /* GK20A */ >> + case 0xea: >> + screen->base.vram_domain = NOUVEAU_BO_GART; > > I think you also want to set vidmem_bindings = 0... although > potentially after the |= that's done below. Although I guess that > constbuf + command args buf need to be |='d into the sysmem_bindings > for this to work out well. Thanks for pointing this out ; I didn't know about vidmem_bindings to be honest. Will update...

...stent VRAM memory. In that respect it seems to be the right thing to do, and all things taken is not very intrusive. Tested on GK20A with Wayland and several EGL clients running, and working fine. Changes since v1: - When using GART as the VRAM domain, move all vidmem bindings to sysmem and set vidmem_bindings to 0. Alexandre Courbot (3): nouveau: support for custom VRAM domains nvc0: use NV_VRAM_DOMAIN() macro gk20a: use NOUVEAU_BO_GART as VRAM domain src/gallium/drivers/nouveau/nouveau_buffer.c | 6 ++--- src/gallium/drivers/nouveau/nouveau_screen.c | 6 +++++ src/gallium/drivers...

New revision of this patchset that prevents VRAM objects from being allocated on VRAM-less systems like Tegra. This is required for Mesa to work on such systems. Changes since v2: - Use vram_size to detect systems without VRAM and set the correct domain instead of expecting each chip to set its domain explicitly. Alexandre Courbot (2): nouveau: support for custom VRAM domains nvc0: use

Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/gallium/drivers/nouveau/nouveau_buffer.c | 4 +--- src/gallium/drivers/nouveau/nouveau_context.h | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nouveau_buffer.c b/src/gallium/drivers/nouveau/nouveau_buffer.c index e308ff4..904e2cc 100644 ---

...return NULL; > pscreen = &screen->base.base; > + pscreen->destroy = nvc0_screen_destroy; > > ret = nouveau_screen_init(&screen->base, dev); > if (ret) { > @@ -672,7 +672,6 @@ nvc0_screen_create(struct nouveau_device *dev) > screen->base.vidmem_bindings = 0; > } > > - pscreen->destroy = nvc0_screen_destroy; > pscreen->context_create = nvc0_create; > pscreen->is_format_supported = nvc0_screen_is_format_supported; > pscreen->get_param = nvc0_screen_get_param; > @@ -1065,8 +1064,8 @@ nvc0_screen_crea...

...;base.base; >>> + pscreen->destroy = nvc0_screen_destroy; >>> >>> ret = nouveau_screen_init(&screen->base, dev); >>> if (ret) { >>> @@ -672,7 +672,6 @@ nvc0_screen_create(struct nouveau_device *dev) >>> screen->base.vidmem_bindings = 0; >>> } >>> >>> - pscreen->destroy = nvc0_screen_destroy; >>> pscreen->context_create = nvc0_create; >>> pscreen->is_format_supported = nvc0_screen_is_format_supported; >>> pscreen->get_param = nvc0_screen_get_pa...

This series is to allow NVIDIA chips with shared memory to operate more efficiently (and to operate at all once we disable VRAM from the kernel driver) by allowing nouveau_screen to specify a domain to use for objects originally allocated into VRAM. If the domain is not overridden, the default NOUVEAU_BO_VRAM is used. A NV_VRAM_DOMAIN() macro is then introduced to be used in place of

The main patches are from Christoph. Unfortunately they're a little beyond my understanding of all the vertex-related details, but they generally seemed fine. I'm just going to push these unless someone steps up to review them. Christoph Bumiller (2): nvc0: add support for indirect drawing nvc0: fix translate path for PRIM_RESTART_WITH_DRAW_ARRAYS Ilia Mirkin (1): nouveau: check if

...ice *dev) if (!screen) return NULL; pscreen = &screen->base.base; + pscreen->destroy = nvc0_screen_destroy; ret = nouveau_screen_init(&screen->base, dev); if (ret) { @@ -672,7 +672,6 @@ nvc0_screen_create(struct nouveau_device *dev) screen->base.vidmem_bindings = 0; } - pscreen->destroy = nvc0_screen_destroy; pscreen->context_create = nvc0_create; pscreen->is_format_supported = nvc0_screen_is_format_supported; pscreen->get_param = nvc0_screen_get_param; @@ -1065,8 +1064,8 @@ nvc0_screen_create(struct nouveau_device *dev)...

...screen = &screen->base.base; >> + pscreen->destroy = nvc0_screen_destroy; >> >> ret = nouveau_screen_init(&screen->base, dev); >> if (ret) { >> @@ -672,7 +672,6 @@ nvc0_screen_create(struct nouveau_device *dev) >> screen->base.vidmem_bindings = 0; >> } >> >> - pscreen->destroy = nvc0_screen_destroy; >> pscreen->context_create = nvc0_create; >> pscreen->is_format_supported = nvc0_screen_is_format_supported; >> pscreen->get_param = nvc0_screen_get_param; >> @@ -1065,8...

...main = NOUVEAU_BO_VRAM; + buffer->domain = NV_VRAM_DOMAIN(screen); break; case PIPE_USAGE_STAGING: case PIPE_USAGE_STREAM: @@ -676,7 +674,7 @@ nouveau_buffer_create(struct pipe_screen *pscreen, } } else { if (buffer->base.bind & screen->vidmem_bindings) - buffer->domain = NOUVEAU_BO_VRAM; + buffer->domain = NV_VRAM_DOMAIN(screen); else if (buffer->base.bind & screen->sysmem_bindings) buffer->domain = NOUVEAU_BO_GART; diff --git a/src/gallium/drivers/nouveau/nv50/nv50_miptree.c b/src/galli...

...>domain = NV_VRAM_DOMAIN(screen); > break; > case PIPE_USAGE_STAGING: > case PIPE_USAGE_STREAM: > @@ -676,7 +674,7 @@ nouveau_buffer_create(struct pipe_screen *pscreen, > } > } else { > if (buffer->base.bind & screen->vidmem_bindings) > - buffer->domain = NOUVEAU_BO_VRAM; > + buffer->domain = NV_VRAM_DOMAIN(screen); > else > if (buffer->base.bind & screen->sysmem_bindings) > buffer->domain = NOUVEAU_BO_GART; > diff --git a/src/gallium/drivers/nouvea...

From: Ben Skeggs <bskeggs at redhat.com> Signed-off-by: Ben Skeggs <bskeggs at redhat.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4016871..c02ee61 100644 --- a/configure.ac +++ b/configure.ac @@ -73,7 +73,7 @@ LIBDRM_RADEON_REQUIRED=2.4.56 LIBDRM_AMDGPU_REQUIRED=2.4.63 LIBDRM_INTEL_REQUIRED=2.4.61

From: Ben Skeggs <bskeggs at redhat.com> Signed-off-by: Ben Skeggs <bskeggs at redhat.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4016871..c02ee61 100644 --- a/configure.ac +++ b/configure.ac @@ -73,7 +73,7 @@ LIBDRM_RADEON_REQUIRED=2.4.56 LIBDRM_AMDGPU_REQUIRED=2.4.63 LIBDRM_INTEL_REQUIRED=2.4.61

From: Ben Skeggs <bskeggs at redhat.com> v2. forgot bump for non-gallium driver Signed-off-by: Ben Skeggs <bskeggs at redhat.com> --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index b6680d0..965c6f7 100644 --- a/configure.ac +++ b/configure.ac @@ -72,8 +72,8 @@ LIBDRM_REQUIRED=2.4.60

...config; switch (dev->chipset & ~0xf) { @@ -616,9 +573,6 @@ nvc0_screen_create(struct nouveau_device *dev) return NULL; } chan = screen->base.channel; - push = screen->base.pushbuf; - push->user_priv = screen; - push->rsvd_kick = 5; screen->base.vidmem_bindings |= PIPE_BIND_CONSTANT_BUFFER | PIPE_BIND_VERTEX_BUFFER | PIPE_BIND_INDEX_BUFFER; @@ -638,16 +592,12 @@ nvc0_screen_create(struct nouveau_device *dev) screen->base.base.get_video_param = nouveau_vp3_screen_get_video_param; screen->base.base.is_video_format_supported = nouveau_vp...

Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com> --- src/gallium/drivers/nouveau/nouveau_fence.c | 76 ++++++++++++------------- src/gallium/drivers/nouveau/nouveau_fence.h | 22 +++++-- src/gallium/drivers/nouveau/nouveau_screen.c | 9 +++ src/gallium/drivers/nouveau/nouveau_screen.h | 14 ++--- src/gallium/drivers/nouveau/nv30/nv30_context.c | 4 +-

...~0xf) { > @@ -616,9 +573,6 @@ nvc0_screen_create(struct nouveau_device *dev) > return NULL; > } > chan = screen->base.channel; > - push = screen->base.pushbuf; > - push->user_priv = screen; > - push->rsvd_kick = 5; > > screen->base.vidmem_bindings |= PIPE_BIND_CONSTANT_BUFFER | > PIPE_BIND_VERTEX_BUFFER | PIPE_BIND_INDEX_BUFFER; > @@ -638,16 +592,12 @@ nvc0_screen_create(struct nouveau_device *dev) > screen->base.base.get_video_param = nouveau_vp3_screen_get_video_param; > screen->base.base.is_video_format_su...