search for: vgoyal

Hi, Michael Tsirkin pointed out issues w.r.t various locking related TODO items and races w.r.t device removal. In this first round of cleanups, I have taken care of most pressing issues. These patches apply on top of following. git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v4 I have tested these patches with mount/umount and device removal using qemu monitor. For

...019 at 03:48:57PM -0400, Vivek Goyal wrote: > It is possible that a mount is in progress and device is being removed at > the same time. Use virtio_fs_mutex to avoid races. > > This also takes care of bunch of races and removes some TODO items. > > Signed-off-by: Vivek Goyal <vgoyal at redhat.com> > --- > fs/fuse/virtio_fs.c | 32 ++++++++++++++++++++++---------- > 1 file changed, 22 insertions(+), 10 deletions(-) Let's move to a per-device mutex in the future. That way a single device that fails to drain/complete requests will not hang all other virtio-fs i...

...019 at 03:48:57PM -0400, Vivek Goyal wrote: > It is possible that a mount is in progress and device is being removed at > the same time. Use virtio_fs_mutex to avoid races. > > This also takes care of bunch of races and removes some TODO items. > > Signed-off-by: Vivek Goyal <vgoyal at redhat.com> > --- > fs/fuse/virtio_fs.c | 32 ++++++++++++++++++++++---------- > 1 file changed, 22 insertions(+), 10 deletions(-) Let's move to a per-device mutex in the future. That way a single device that fails to drain/complete requests will not hang all other virtio-fs i...

Hi, If you are not already tired of so many io controller implementations, here is another one. This is a very eary very crude implementation to get early feedback to see if this approach makes any sense or not. This controller is a proportional weight IO controller primarily based on/inspired by dm-ioband. One of the things I personally found little odd about dm-ioband was need of a dm-ioband

Hi, If you are not already tired of so many io controller implementations, here is another one. This is a very eary very crude implementation to get early feedback to see if this approach makes any sense or not. This controller is a proportional weight IO controller primarily based on/inspired by dm-ioband. One of the things I personally found little odd about dm-ioband was need of a dm-ioband

...; will be cleaned when filesystem is unmounted and sb/fc drops its reference. > > Removing a device also stops all virt queues and any new reuqest gets > error -ENOTCONN. All existing in flight requests are drained before > ->remove returns. > > Signed-off-by: Vivek Goyal <vgoyal at redhat.com> > --- > fs/fuse/virtio_fs.c | 52 +++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 43 insertions(+), 9 deletions(-) > > diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c > index 01bbf2c0e144..29ec2f5bbbe2 100644 > --- a/fs/fuse/virtio_fs....

...; will be cleaned when filesystem is unmounted and sb/fc drops its reference. > > Removing a device also stops all virt queues and any new reuqest gets > error -ENOTCONN. All existing in flight requests are drained before > ->remove returns. > > Signed-off-by: Vivek Goyal <vgoyal at redhat.com> > --- > fs/fuse/virtio_fs.c | 52 +++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 43 insertions(+), 9 deletions(-) > > diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c > index 01bbf2c0e144..29ec2f5bbbe2 100644 > --- a/fs/fuse/virtio_fs....

Since fs is a modern-only device, tag config space fields as having little endian-ness. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Acked-by: Vivek Goyal <vgoyal at redhat.com> Acked-by: Vivek Goyal <vgoyal at redhat.com> Reviewed-by: Cornelia Huck <cohuck at redhat.com> --- include/uapi/linux/virtio_fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/virtio_fs.h b/include/uapi/linux/virtio_fs.h index...

Hi, RH devel kernels from http://people.redhat.com/dzickus/el5/ built against Centos tree are available here: http://fs12.vsb.cz/hrb33/el5/hrb-kernel/stable/x86_64/repodata/ http://fs12.vsb.cz/hrb33/el5/hrb-kernel/stable/i386/repodata/ Regards, David Hrb??

Hi, We have couple of places which can result in deadlock. This patch series fixes these. We can be called with fc->bg_lock (for background requests) while submitting a request. This leads to two constraints. - We can't end requests in submitter's context and call fuse_end_request() as it tries to take fc->bg_lock as well. So queue these requests on a list and use a worker to

...> On 2019/9/6 19:52, Miklos Szeredi wrote: > > On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi <stefanha at redhat.com> wrote: > >> > >> On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: > >>> On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal <vgoyal at redhat.com> wrote: > >>>> > >>>> Hi, > >>>> > >>>> Michael Tsirkin pointed out issues w.r.t various locking related TODO > >>>> items and races w.r.t device removal. > >>>> > >>>> In this...

...er layout. This breaks things like kdump when they try to use e.g. virtio-blk. Fix by forcing msi off at startup. Since pci.c already has a routine to do this, we export and use it instead of duplicating code. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Tested-by: Vivek Goyal <vgoyal at redhat.com> Cc: Jesse Barnes <jbarnes at virtuousgeek.org> Cc: linux-pci at vger.kernel.org --- Jesse, could you ack adding the pci export please? Rusty, please consider this patch for 2.6.35. drivers/pci/pci.c | 1 + drivers/virtio/virtio_pci.c | 3 +++ include/linux...

...er layout. This breaks things like kdump when they try to use e.g. virtio-blk. Fix by forcing msi off at startup. Since pci.c already has a routine to do this, we export and use it instead of duplicating code. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Tested-by: Vivek Goyal <vgoyal at redhat.com> Cc: Jesse Barnes <jbarnes at virtuousgeek.org> Cc: linux-pci at vger.kernel.org --- Jesse, could you ack adding the pci export please? Rusty, please consider this patch for 2.6.35. drivers/pci/pci.c | 1 + drivers/virtio/virtio_pci.c | 3 +++ include/linux...

...Goyal wrote: > > It is possible that a mount is in progress and device is being removed at > > the same time. Use virtio_fs_mutex to avoid races. > > > > This also takes care of bunch of races and removes some TODO items. > > > > Signed-off-by: Vivek Goyal <vgoyal at redhat.com> > > --- > > fs/fuse/virtio_fs.c | 32 ++++++++++++++++++++++---------- > > 1 file changed, 22 insertions(+), 10 deletions(-) > > Let's move to a per-device mutex in the future. That way a single > device that fails to drain/complete requests will...

...n Fri, Sep 06, 2019 at 01:52:41PM +0200, Miklos Szeredi wrote: > On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi <stefanha at redhat.com> wrote: > > > > On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: > > > On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal <vgoyal at redhat.com> wrote: > > > > > > > > Hi, > > > > > > > > Michael Tsirkin pointed out issues w.r.t various locking related TODO > > > > items and races w.r.t device removal. > > > > > > > > In this first round of...

...n Fri, Sep 06, 2019 at 01:52:41PM +0200, Miklos Szeredi wrote: > On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi <stefanha at redhat.com> wrote: > > > > On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: > > > On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal <vgoyal at redhat.com> wrote: > > > > > > > > Hi, > > > > > > > > Michael Tsirkin pointed out issues w.r.t various locking related TODO > > > > items and races w.r.t device removal. > > > > > > > > In this first round of...

...CK for this from the virtio maintainers. > > Thanks, > Miklos Can the patches themselves be posted to the relevant list(s) please? If possible, please also include "v3" in all patches so they are easier to find. I poked at https://lwn.net/ml/linux-kernel/20190821173742.24574-1-vgoyal at redhat.com/ specifically https://lwn.net/ml/linux-kernel/20190821173742.24574-12-vgoyal at redhat.com/ and things like: + /* TODO lock */ give me pause. Cleanup generally seems broken to me - what pauses the FS What about the rest of TODOs in that file? use of usleep is hacky - can't we d...

...CK for this from the virtio maintainers. > > Thanks, > Miklos Can the patches themselves be posted to the relevant list(s) please? If possible, please also include "v3" in all patches so they are easier to find. I poked at https://lwn.net/ml/linux-kernel/20190821173742.24574-1-vgoyal at redhat.com/ specifically https://lwn.net/ml/linux-kernel/20190821173742.24574-12-vgoyal at redhat.com/ and things like: + /* TODO lock */ give me pause. Cleanup generally seems broken to me - what pauses the FS What about the rest of TODOs in that file? use of usleep is hacky - can't we d...

Hi Miklos, Here are few small cleanups for virtiofs for 5.5. I had received some comments from Michael Tsirkin on original virtiofs patches and these cleanups are result of these comments. Thanks Vivek Vivek Goyal (3): virtiofs: Use a common function to send forget virtiofs: Do not send forget request "struct list_head" element virtiofs: Use completions while waiting for queue

From: Vivek Goyal <vgoyal at redhat.com> [ Upstream commit bb737bbe48bea9854455cb61ea1dc06e92ce586c ] In virtiofs (unlike in regular fuse) processing of async replies is serialized. This can result in a deadlock in rare corner cases when there's a circular dependency between the completion of two or more async rep...