search for: vga_switcheroo_client_tryget

...switch check > potentially being racy. But that's a different can of worms. Ok I got a bit annoyed about this mess again, and I think I have a reasonable idea for how to address it. Not sure why this took a decade, and definitely only pick this up if you're really bored. - We add a new vga_switcheroo_client_tryget, which checks the current state, and if it's on, increments a newly added refcount (which vgw switheroo maintains). Otherwise it fails. Drivers call this from their drm_driver->open hook. This check also allows us to drop the layer-violating checks in drm_open_helper for drm_dev->...

...s it. Not sure why this took a decade, > and definitely only pick this up if you're really bored. No, definitely not. :) I don't think I have hardware for testing vga_switcheroo. Does this still exist? It seemed to be a thing of the 2000s. Best regards Thomas > > - We add a new vga_switcheroo_client_tryget, which checks the current > state, and if it's on, increments a newly added refcount (which vgw > switheroo maintains). Otherwise it fails. Drivers call this from their > drm_driver->open hook. This check also allows us to drop the > layer-violating checks in drm_open...

...don't think I have hardware for testing > vga_switcheroo. Does this still exist? It seemed to be a thing of the 2000s. Yeah good chances the old style switcheroo doesn't have many, if any users left ... -Sima > > Best regards > Thomas > > > > > - We add a new vga_switcheroo_client_tryget, which checks the current > > state, and if it's on, increments a newly added refcount (which vgw > > switheroo maintains). Otherwise it fails. Drivers call this from their > > drm_driver->open hook. This check also allows us to drop the > > layer-violatin...

On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote: > Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from > their lastclose callbacks. Call it from drm_lastclose(), so that the > driver functions can finally be removed. Only PCI devices with enabled > switcheroo do the delayed switching. The call has no effect on other > hardware. > > v2: >