search for: vfs_stat_fsp

Release Announcements --------------------- This is the latest stable release of the Samba 4.19 release series. Changes since 4.19.5 -------------------- o? Ralph Boehme <slow at samba.org> ?? * BUG 15527: fd_handle_destructor() panics within an smbd_smb2_close() if ???? vfs_stat_fsp() fails in fd_close(). o? Guenther Deschner <gd at samba.org> ?? * BUG 15588: samba-gpupdate: Correctly implement site support. o? Noel Power <noel.power at suse.com> ?? * BUG 15527: fd_handle_destructor() panics within an smbd_smb2_close() if ???? vfs_stat_fsp() fails in fd_close...

Release Announcements --------------------- This is the latest stable release of the Samba 4.19 release series. Changes since 4.19.5 -------------------- o? Ralph Boehme <slow at samba.org> ?? * BUG 15527: fd_handle_destructor() panics within an smbd_smb2_close() if ???? vfs_stat_fsp() fails in fd_close(). o? Guenther Deschner <gd at samba.org> ?? * BUG 15588: samba-gpupdate: Correctly implement site support. o? Noel Power <noel.power at suse.com> ?? * BUG 15527: fd_handle_destructor() panics within an smbd_smb2_close() if ???? vfs_stat_fsp() fails in fd_close...

....nz> ?? * BUG 15606: Avoid null-dereference with bad claims. ?? * BUG 15613: ndr_pull_security_ace can leave resource attribute ACE coda ???? claim struct undefined. o? Ralph Boehme <slow at samba.org> ?? * BUG 15527: fd_handle_destructor() panics within an smbd_smb2_close() if ???? vfs_stat_fsp() fails in fd_close(). o? Bj?rn Jacke <bjacke at samba.org> ?? * BUG 15583: set_nt_acl sometimes fails with NT_STATUS_INVALID_PARAMETER - ???? openat() EACCES. o? Noel Power <noel.power at suse.com> ?? * BUG 15527: fd_handle_destructor() panics within an smbd_smb2_close() if ???...

....nz> ?? * BUG 15606: Avoid null-dereference with bad claims. ?? * BUG 15613: ndr_pull_security_ace can leave resource attribute ACE coda ???? claim struct undefined. o? Ralph Boehme <slow at samba.org> ?? * BUG 15527: fd_handle_destructor() panics within an smbd_smb2_close() if ???? vfs_stat_fsp() fails in fd_close(). o? Bj?rn Jacke <bjacke at samba.org> ?? * BUG 15583: set_nt_acl sometimes fails with NT_STATUS_INVALID_PARAMETER - ???? openat() EACCES. o? Noel Power <noel.power at suse.com> ?? * BUG 15527: fd_handle_destructor() panics within an smbd_smb2_close() if ???...

...TALLOC_FREE(psd_fs); > - } else { > + if (psd_is_from_fs) { > SMB_STRUCT_STAT sbuf; > SMB_STRUCT_STAT *psbuf = &sbuf; > bool is_directory = false; > @@ -725,8 +715,7 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle, > if (fsp) { > status = vfs_stat_fsp(fsp); > if (!NT_STATUS_IS_OK(status)) { > - TALLOC_FREE(frame); > - return status; > + goto fail; > } > psbuf = &fsp->fsp_name->st; > } else { > @@ -751,72 +740,74 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle, >...

On Fri, Aug 26, 2016 at 06:33:26PM +0200, Ralph Böhme via samba wrote: > On Thu, Aug 25, 2016 at 12:14:00PM -0700, Jeremy Allison wrote: > > On Wed, Aug 24, 2016 at 04:06:42PM +0200, Ralph Böhme via samba wrote: > > > > > > Yeah, as much as I'd like to avoid adding a new option, I guess we > > > have to do something about it, my latest take on this is >

...TALLOC_FREE(psd_fs); > - } else { > + if (psd_is_from_fs) { > SMB_STRUCT_STAT sbuf; > SMB_STRUCT_STAT *psbuf = &sbuf; > bool is_directory = false; > @@ -725,8 +715,7 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle, > if (fsp) { > status = vfs_stat_fsp(fsp); > if (!NT_STATUS_IS_OK(status)) { > - TALLOC_FREE(frame); > - return status; > + goto fail; > } > psbuf = &fsp->fsp_name->st; > } else { > @@ -751,72 +740,74 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle, >...

On Fri, Aug 26, 2016 at 04:03:49PM -0700, Jeremy Allison wrote: > On Fri, Aug 26, 2016 at 02:46:19PM -0700, Jeremy Allison via samba wrote: > > On Fri, Aug 26, 2016 at 06:44:05PM +0200, Ralph Böhme wrote: > > > > > > Cheerio! > > > -slow > > > > Still reviewing this - but a few things that will need changing: > > > > When adding the