search for: vfio_pci

...s that mix IOMMU and no-IOMMU configs. If so, failing on probe might not be the right thing to do, should fail binding to IOMMU group instead. Michael S. Tsirkin (3): virtio: add features for IOMMU control vfio: report group noiommu status vfio: add virtio pci quirk drivers/vfio/pci/vfio_pci_private.h | 1 + include/uapi/linux/virtio_config.h | 10 +- drivers/vfio/pci/vfio_pci.c | 13 ++- drivers/vfio/pci/vfio_pci_virtio.c | 142 +++++++++++++++++++++++++++ drivers/vfio/platform/vfio_platform_common.c | 2 +- drivers/vfio/vfio.c...

...s that mix IOMMU and no-IOMMU configs. If so, failing on probe might not be the right thing to do, should fail binding to IOMMU group instead. Michael S. Tsirkin (3): virtio: add features for IOMMU control vfio: report group noiommu status vfio: add virtio pci quirk drivers/vfio/pci/vfio_pci_private.h | 1 + include/uapi/linux/virtio_config.h | 10 +- drivers/vfio/pci/vfio_pci.c | 13 ++- drivers/vfio/pci/vfio_pci_virtio.c | 142 +++++++++++++++++++++++++++ drivers/vfio/platform/vfio_platform_common.c | 2 +- drivers/vfio/vfio.c...

...> > > Without this bit, exposing the device to userspace is unsafe, so probe > > > and fail VFIO initialization unless noiommu is enabled. > > > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > > --- > > > drivers/vfio/pci/vfio_pci_private.h | 1 + > > > drivers/vfio/pci/vfio_pci.c | 14 ++++ > > > drivers/vfio/pci/vfio_pci_virtio.c | 140 ++++++++++++++++++++++++++++++++++++ > > > drivers/vfio/pci/Makefile | 1 + > > > 4 files changed, 156 insertions(+) > > &g...

...> > > Without this bit, exposing the device to userspace is unsafe, so probe > > > and fail VFIO initialization unless noiommu is enabled. > > > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > > --- > > > drivers/vfio/pci/vfio_pci_private.h | 1 + > > > drivers/vfio/pci/vfio_pci.c | 14 ++++ > > > drivers/vfio/pci/vfio_pci_virtio.c | 140 ++++++++++++++++++++++++++++++++++++ > > > drivers/vfio/pci/Makefile | 1 + > > > 4 files changed, 156 insertions(+) > > &g...

...RM > to signal they are safe to use with an IOMMU. > > Without this bit, exposing the device to userspace is unsafe, so probe > and fail VFIO initialization unless noiommu is enabled. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/vfio/pci/vfio_pci_private.h | 1 + > drivers/vfio/pci/vfio_pci.c | 14 ++++ > drivers/vfio/pci/vfio_pci_virtio.c | 140 ++++++++++++++++++++++++++++++++++++ > drivers/vfio/pci/Makefile | 1 + > 4 files changed, 156 insertions(+) > create mode 100644 drivers/vfio/pci/vfio_pci_v...

...RM > to signal they are safe to use with an IOMMU. > > Without this bit, exposing the device to userspace is unsafe, so probe > and fail VFIO initialization unless noiommu is enabled. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/vfio/pci/vfio_pci_private.h | 1 + > drivers/vfio/pci/vfio_pci.c | 14 ++++ > drivers/vfio/pci/vfio_pci_virtio.c | 140 ++++++++++++++++++++++++++++++++++++ > drivers/vfio/pci/Makefile | 1 + > 4 files changed, 156 insertions(+) > create mode 100644 drivers/vfio/pci/vfio_pci_v...

...RM > to signal they are safe to use with an IOMMU. > > Without this bit, exposing the device to userspace is unsafe, so probe > and fail VFIO initialization unless noiommu is enabled. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/vfio/pci/vfio_pci_private.h | 1 + > drivers/vfio/pci/vfio_pci.c | 11 +++ > drivers/vfio/pci/vfio_pci_virtio.c | 135 ++++++++++++++++++++++++++++++++++++ > drivers/vfio/pci/Makefile | 1 + > 4 files changed, 148 insertions(+) > create mode 100644 drivers/vfio/pci/vfio_pci_vi...

...RM > to signal they are safe to use with an IOMMU. > > Without this bit, exposing the device to userspace is unsafe, so probe > and fail VFIO initialization unless noiommu is enabled. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/vfio/pci/vfio_pci_private.h | 1 + > drivers/vfio/pci/vfio_pci.c | 11 +++ > drivers/vfio/pci/vfio_pci_virtio.c | 135 ++++++++++++++++++++++++++++++++++++ > drivers/vfio/pci/Makefile | 1 + > 4 files changed, 148 insertions(+) > create mode 100644 drivers/vfio/pci/vfio_pci_vi...

...This adds a quirk detecting these and disabling VFIO unless the noiommu mode is used. At the moment, this only applies to virtio-pci devices. The patch might make sense on stable as well. Michael S. Tsirkin (2): vfio: report group noiommu status vfio: add virtio pci quirk drivers/vfio/pci/vfio_pci_private.h | 1 + include/linux/vfio.h | 2 + drivers/vfio/pci/vfio_pci.c | 14 ++++ drivers/vfio/pci/vfio_pci_virtio.c | 140 ++++++++++++++++++++++++++++++++++++ drivers/vfio/vfio.c | 12 ++++ drivers/vfio/pci/Makefile | 1 + 6 files change...

...This adds a quirk detecting these and disabling VFIO unless the noiommu mode is used. At the moment, this only applies to virtio-pci devices. The patch might make sense on stable as well. Michael S. Tsirkin (2): vfio: report group noiommu status vfio: add virtio pci quirk drivers/vfio/pci/vfio_pci_private.h | 1 + include/linux/vfio.h | 2 + drivers/vfio/pci/vfio_pci.c | 14 ++++ drivers/vfio/pci/vfio_pci_virtio.c | 140 ++++++++++++++++++++++++++++++++++++ drivers/vfio/vfio.c | 12 ++++ drivers/vfio/pci/Makefile | 1 + 6 files change...

...rse). What I did now was switching between VFIO and 'normal' operation, ie emulated access. megasas is happily running under VFIO, but when I do an emergency stop like killing the Qemu session the PCI device is not properly reset. IE when I load 'megaraid_sas' after unbinding the vfio_pci module the driver cannot initialize the card and waits forever for the firmware state to change. I need to do a proper pci reset via echo 1 > /sys/bus/pci/device/XXXX/reset to get it into a working state again. Looking at vfio_pci_disable() pci reset is called before the config state and BAR...

...rse). What I did now was switching between VFIO and 'normal' operation, ie emulated access. megasas is happily running under VFIO, but when I do an emergency stop like killing the Qemu session the PCI device is not properly reset. IE when I load 'megaraid_sas' after unbinding the vfio_pci module the driver cannot initialize the card and waits forever for the firmware state to change. I need to do a proper pci reset via echo 1 > /sys/bus/pci/device/XXXX/reset to get it into a working state again. Looking at vfio_pci_disable() pci reset is called before the config state and BAR...

...00 Oct 7 11:32:53 artemis2 kernel: Call Trace: Oct 7 11:32:53 artemis2 kernel: [<ffffffff815e237b>] dump_stack+0x19/0x1b Oct 7 11:32:53 artemis2 kernel: [<ffffffff810f924a>] __setup_irq+0x54a/0x570 Oct 7 11:32:53 artemis2 kernel: [<ffffffffa0866ee0>] ? virqfd_wakeup+0xc0/0xc0 [vfio_pci] Oct 7 11:32:53 artemis2 kernel: [<ffffffff810f93cc>] request_threaded_irq+0xcc/0x170 Oct 7 11:32:53 artemis2 kernel: [<ffffffffa0866b8a>] vfio_intx_set_signal+0x10a/0x1f0 [vfio_pci] Oct 7 11:32:53 artemis2 kernel: [<ffffffffa08670e8>] vfio_pci_set_intx_trigger+0xc8/0x1b0 [vfio...

When using vfio, callers might want to know whether device is added to a regular group or an non-iommu group. Report this status from vfio_add_group_dev. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vfio/pci/vfio_pci.c | 2 +- drivers/vfio/platform/vfio_platform_common.c | 2 +- drivers/vfio/vfio.c | 5 ++++- Documentation/vfio.txt | 4 +++- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pc...

...is bit, exposing the device to userspace is unsafe, so probe > > > > and fail VFIO initialization unless noiommu is enabled. > > > > > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > > > --- > > > > drivers/vfio/pci/vfio_pci_private.h | 1 + > > > > drivers/vfio/pci/vfio_pci.c | 14 ++++ > > > > drivers/vfio/pci/vfio_pci_virtio.c | 140 ++++++++++++++++++++++++++++++++++++ > > > > drivers/vfio/pci/Makefile | 1 + > > > > 4 files changed, 156 insert...

...;/name> <uuid>61bc1a72-bd02-408a-b88e-dec696742c20</uuid> <bridge name='virtsw0' stp='on' delay='0'/> <mac address='52:54:00:6b:1b:92'/> </network> as it is possible I'm missing a kernel config, here is the output of lsmod: vfio_pci 49152 6 vfio_virqfd 16384 1 vfio_pci vfio_iommu_type1 32768 2 vfio 28672 16 vfio_iommu_type1,vfio_pci ip6table_nat 16384 1 iptable_nat 16384 1 ebtables 24576 0 bridge 143360 0 stp...

...ci devices can set VIRTIO_F_IOMMU_PLATFORM to signal they are safe to use with an IOMMU. Without this bit, exposing the device to userspace is unsafe, so probe and fail VFIO initialization unless noiommu is enabled. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vfio/pci/vfio_pci_private.h | 1 + drivers/vfio/pci/vfio_pci.c | 11 +++ drivers/vfio/pci/vfio_pci_virtio.c | 135 ++++++++++++++++++++++++++++++++++++ drivers/vfio/pci/Makefile | 1 + 4 files changed, 148 insertions(+) create mode 100644 drivers/vfio/pci/vfio_pci_virtio.c diff --git a/driv...

...ci devices can set VIRTIO_F_IOMMU_PLATFORM to signal they are safe to use with an IOMMU. Without this bit, exposing the device to userspace is unsafe, so probe and fail VFIO initialization unless noiommu is enabled. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vfio/pci/vfio_pci_private.h | 1 + drivers/vfio/pci/vfio_pci.c | 14 ++++ drivers/vfio/pci/vfio_pci_virtio.c | 140 ++++++++++++++++++++++++++++++++++++ drivers/vfio/pci/Makefile | 1 + 4 files changed, 156 insertions(+) create mode 100644 drivers/vfio/pci/vfio_pci_virtio.c diff --git a/dri...

...ld happen in error_report. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- changes from v1: - more detailed commit log - fixed a couple of bugs Alex, pls review but don't apply until we get - userspace updated to use the new interface - testing reports drivers/vfio/pci/vfio_pci.c | 35 ++++++++++++++++++++++++++++++++++- drivers/vfio/pci/vfio_pci_intrs.c | 19 +++++++++++++++++++ drivers/vfio/pci/vfio_pci_private.h | 1 + include/linux/virtio_config.h | 12 +++++++++++- include/uapi/linux/vfio.h | 1 + 5 files changed, 66 insertions(+), 2 delet...

...ld happen in error_report. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- changes from v1: - more detailed commit log - fixed a couple of bugs Alex, pls review but don't apply until we get - userspace updated to use the new interface - testing reports drivers/vfio/pci/vfio_pci.c | 35 ++++++++++++++++++++++++++++++++++- drivers/vfio/pci/vfio_pci_intrs.c | 19 +++++++++++++++++++ drivers/vfio/pci/vfio_pci_private.h | 1 + include/linux/virtio_config.h | 12 +++++++++++- include/uapi/linux/vfio.h | 1 + 5 files changed, 66 insertions(+), 2 delet...