search for: vfio_op

...d the device specific callbacks in create() s/in create()/in the create()/ > +callback. E.g for vfio-mdev device it needs to be done through: "Each class provides a helper function to do so; e.g. for vfio-mdev devices, the function to be called is:" ? > + > + int mdev_set_vfio_ops(struct mdev_device *mdev, > + const struct vfio_mdev_ops *vfio_ops); > + > +The class id (set to MDEV_CLASS_ID_VFIO) is used to match a device "(set by this helper function to MDEV_CLASS_ID_VFIO)" ? > +with an mdev driver via its id table. The devic...

...d the device specific callbacks in create() s/in create()/in the create()/ > +callback. E.g for vfio-mdev device it needs to be done through: "Each class provides a helper function to do so; e.g. for vfio-mdev devices, the function to be called is:" ? > + > + int mdev_set_vfio_ops(struct mdev_device *mdev, > + const struct vfio_mdev_ops *vfio_ops); > + > +The class id (set to MDEV_CLASS_ID_VFIO) is used to match a device "(set by this helper function to MDEV_CLASS_ID_VFIO)" ? > +with an mdev driver via its id table. The devic...

...gt;>>>> int mdev_set_class_struct(struct device *dev, const struct >>>>> mdev_class_struct *class); >>>>> >>>>> struct mdev_class_struct { >>>>> u16 id; >>>>> union { >>>>> struct vfio_mdev_ops vfio_ops; >>>>> struct virtio_mdev_ops virtio_ops; >>>>> }; >>>>> }; >>>>> >>>>> Maybe even: >>>>> >>>>> struct vfio_mdev_ops *mdev_get_vfio_ops(struct mdev_device *mdev) { >>>>> BUG_...

...gt;>>>> int mdev_set_class_struct(struct device *dev, const struct >>>>> mdev_class_struct *class); >>>>> >>>>> struct mdev_class_struct { >>>>> u16 id; >>>>> union { >>>>> struct vfio_mdev_ops vfio_ops; >>>>> struct virtio_mdev_ops virtio_ops; >>>>> }; >>>>> }; >>>>> >>>>> Maybe even: >>>>> >>>>> struct vfio_mdev_ops *mdev_get_vfio_ops(struct mdev_device *mdev) { >>>>> BUG_...

...eate()/in the create()/ > > > +callback. E.g for vfio-mdev device it needs to be done through: > > "Each class provides a helper function to do so; e.g. for vfio-mdev > devices, the function to be called is:" > > ? > > > + > > + int mdev_set_vfio_ops(struct mdev_device *mdev, > > + const struct vfio_mdev_ops *vfio_ops); > > + > > +The class id (set to MDEV_CLASS_ID_VFIO) is used to match a device > > "(set by this helper function to MDEV_CLASS_ID_VFIO)" ? > > > +with an md...

...en for > > simplicity. We could still do something like: > > > > int mdev_set_class_struct(struct device *dev, const struct mdev_class_struct > > *class); > > > > struct mdev_class_struct { > > u16 id; > > union { > > struct vfio_mdev_ops vfio_ops; > > struct virtio_mdev_ops virtio_ops; > > }; > > }; > > > > Maybe even: > > > > struct vfio_mdev_ops *mdev_get_vfio_ops(struct mdev_device *mdev) { > > BUG_ON(mdev->class.id != MDEV_ID_VFIO); > > return &mdev->class.vfio_ops;...

On Fri, 11 Oct 2019 16:15:54 +0800 Jason Wang <jasowang at redhat.com> wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of

On Fri, 11 Oct 2019 16:15:54 +0800 Jason Wang <jasowang at redhat.com> wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of

...+-- > drivers/vfio/mdev/mdev_core.c | 24 ++++++++- > drivers/vfio/mdev/mdev_private.h | 5 ++ > drivers/vfio/mdev/vfio_mdev.c | 37 ++++++------- > include/linux/mdev.h | 43 ++++----------- > include/linux/mdev_vfio_ops.h | 52 +++++++++++++++++++ > samples/vfio-mdev/mbochs.c | 20 ++++--- > samples/vfio-mdev/mdpy.c | 20 ++++--- > samples/vfio-mdev/mtty.c | 18 ++++--- > 13 files changed, 206 insertions(+), 99 deletions(-) &...

...+-- > drivers/vfio/mdev/mdev_core.c | 24 ++++++++- > drivers/vfio/mdev/mdev_private.h | 5 ++ > drivers/vfio/mdev/vfio_mdev.c | 37 ++++++------- > include/linux/mdev.h | 43 ++++----------- > include/linux/mdev_vfio_ops.h | 52 +++++++++++++++++++ > samples/vfio-mdev/mbochs.c | 20 ++++--- > samples/vfio-mdev/mdpy.c | 20 ++++--- > samples/vfio-mdev/mtty.c | 18 ++++--- > 13 files changed, 206 insertions(+), 99 deletions(-) &...

...> > > > > int mdev_set_class_struct(struct device *dev, const struct > > > > mdev_class_struct *class); > > > > > > > > struct mdev_class_struct { > > > > u16 id; > > > > union { > > > > struct vfio_mdev_ops vfio_ops; > > > > struct virtio_mdev_ops virtio_ops; > > > > }; > > > > }; > > > > > > > > Maybe even: > > > > > > > > struct vfio_mdev_ops *mdev_get_vfio_ops(struct mdev_device *mdev) { > > > > BUG_ON(mdev-...

...ops.c | 14 +++-- drivers/vfio/mdev/mdev_core.c | 24 ++++++++- drivers/vfio/mdev/mdev_private.h | 5 ++ drivers/vfio/mdev/vfio_mdev.c | 37 ++++++------- include/linux/mdev.h | 43 ++++----------- include/linux/mdev_vfio_ops.h | 52 +++++++++++++++++++ samples/vfio-mdev/mbochs.c | 20 ++++--- samples/vfio-mdev/mdpy.c | 20 ++++--- samples/vfio-mdev/mtty.c | 18 ++++--- 13 files changed, 206 insertions(+), 99 deletions(-) create mode 100644 i...

...ops.c | 14 +++-- drivers/vfio/mdev/mdev_core.c | 24 ++++++++- drivers/vfio/mdev/mdev_private.h | 5 ++ drivers/vfio/mdev/vfio_mdev.c | 37 ++++++------- include/linux/mdev.h | 43 ++++----------- include/linux/mdev_vfio_ops.h | 52 +++++++++++++++++++ samples/vfio-mdev/mbochs.c | 20 ++++--- samples/vfio-mdev/mdpy.c | 20 ++++--- samples/vfio-mdev/mtty.c | 18 ++++--- 13 files changed, 206 insertions(+), 99 deletions(-) create mode 100644 i...

...ops.c | 14 +++-- drivers/vfio/mdev/mdev_core.c | 24 ++++++++- drivers/vfio/mdev/mdev_private.h | 5 ++ drivers/vfio/mdev/vfio_mdev.c | 37 ++++++------- include/linux/mdev.h | 43 ++++----------- include/linux/mdev_vfio_ops.h | 52 +++++++++++++++++++ samples/vfio-mdev/mbochs.c | 20 ++++--- samples/vfio-mdev/mdpy.c | 20 ++++--- samples/vfio-mdev/mtty.c | 18 ++++--- 13 files changed, 206 insertions(+), 99 deletions(-) create mode 100644 i...

...ops.c | 14 +++-- drivers/vfio/mdev/mdev_core.c | 25 ++++++++- drivers/vfio/mdev/mdev_private.h | 5 ++ drivers/vfio/mdev/vfio_mdev.c | 37 ++++++------- include/linux/mdev.h | 43 ++++----------- include/linux/mdev_vfio_ops.h | 52 +++++++++++++++++++ samples/vfio-mdev/mbochs.c | 20 ++++--- samples/vfio-mdev/mdpy.c | 20 ++++--- samples/vfio-mdev/mtty.c | 18 ++++--- 13 files changed, 206 insertions(+), 100 deletions(-) create mode 100644...

...+-- > drivers/vfio/mdev/mdev_core.c | 25 ++++++++- > drivers/vfio/mdev/mdev_private.h | 5 ++ > drivers/vfio/mdev/vfio_mdev.c | 37 ++++++------- > include/linux/mdev.h | 43 ++++----------- > include/linux/mdev_vfio_ops.h | 52 +++++++++++++++++++ > samples/vfio-mdev/mbochs.c | 20 ++++--- > samples/vfio-mdev/mdpy.c | 20 ++++--- > samples/vfio-mdev/mtty.c | 18 ++++--- > 13 files changed, 206 insertions(+), 100 deletions(-)...

...| 24 ++++++++- > > > drivers/vfio/mdev/mdev_private.h | 5 ++ > > > drivers/vfio/mdev/vfio_mdev.c | 37 ++++++------- > > > include/linux/mdev.h | 43 ++++----------- > > > include/linux/mdev_vfio_ops.h | 52 +++++++++++++++++++ > > > samples/vfio-mdev/mbochs.c | 20 ++++--- > > > samples/vfio-mdev/mdpy.c | 20 ++++--- > > > samples/vfio-mdev/mtty.c | 18 ++++--- > > > 13 files chang...

...evice *dev, const struct > > > > > > mdev_class_struct *class); > > > > > > > > > > > > struct mdev_class_struct { > > > > > > u16 id; > > > > > > union { > > > > > > struct vfio_mdev_ops vfio_ops; > > > > > > struct virtio_mdev_ops virtio_ops; > > > > > > }; > > > > > > }; > > > > > > > > > > > > Maybe even: > > > > > > > > > > > > struct vfio_mdev_ops *mdev_get_...

...19 16:30:43 +0800 Jason Wang <jasowang at redhat.com> wrote: > On 2019/10/17 ??12:53, Alex Williamson wrote: > >>> Yet another suggestion: have the class id derive from the function > >>> you use to set up the ops. > >>> > >>> void mdev_set_vfio_ops(struct mdev_device *mdev, const struct > >>> vfio_mdev_ops *vfio_ops) { > >>> mdev->device_ops = vfio_ops; > >>> mdev->class_id = MDEV_ID_VFIO; > >>> } > >>> > >>> void mdev_set_virtio_ops(struct mdev_device *mdev, con...

...io/mdev/mdev_core.c | 24 ++++++++- > > drivers/vfio/mdev/mdev_private.h | 5 ++ > > drivers/vfio/mdev/vfio_mdev.c | 37 ++++++------- > > include/linux/mdev.h | 43 ++++----------- > > include/linux/mdev_vfio_ops.h | 52 +++++++++++++++++++ > > samples/vfio-mdev/mbochs.c | 20 ++++--- > > samples/vfio-mdev/mdpy.c | 20 ++++--- > > samples/vfio-mdev/mtty.c | 18 ++++--- > > 13 files changed, 206 insertions(+...