search for: vertex_buffer_index

http://bugs.freedesktop.org/show_bug.cgi?id=23505 Summary: KDE's Kubrick has problems with xf86-video-nouveau driver Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/nouveau AssignedTo: nouveau at

...t an apitrace (https://github.com/apitrace/apitrace) with your "fix" in place. Once you make the trace, change your fix to instead abort the program, and replay the trace. This will allow us to look at the precise call sequence that causes the issue. What is the numerical value of ve->vertex_buffer_index when it's >= num_vtxbufs? [What about num_vtxbufs?] Cheers, -ilia On Fri, Feb 27, 2015 at 9:41 AM, Arno Willig <arno.willig at hertz.st> wrote: > > Hi, > > I experience a crash in the nouveau part of the mesa driver: > > src/gallium/drivers/nouveau/nv30/nv30_vbo....

...>vtxbuf_nr == 0) + return; + vtxbuf = so_new(nv50->vtxelt_nr * 4, nv50->vtxelt_nr * 2); vtxfmt = so_new(nv50->vtxelt_nr + 1, 0); so_method(vtxfmt, tesla, 0x1ac0, nv50->vtxelt_nr); @@ -218,30 +273,7 @@ nv50_vbo_validate(struct nv50_context *nv50) &nv50->vtxbuf[ve->vertex_buffer_index]; struct nouveau_bo *bo = nouveau_bo(vb->buffer); - switch (ve->src_format) { - case PIPE_FORMAT_R32G32B32A32_FLOAT: - so_data(vtxfmt, 0x7e080000 | i); - break; - case PIPE_FORMAT_R32G32B32_FLOAT: - so_data(vtxfmt, 0x7e100000 | i); - break; - case PIPE_FORMAT_R32G32_FLOAT: -...

.../drivers/nv30/nv30_vbo.c b/src/gallium/drivers/nv30/nv30_vbo.c index 128457f..94febc3 100644 --- a/src/gallium/drivers/nv30/nv30_vbo.c +++ b/src/gallium/drivers/nv30/nv30_vbo.c @@ -226,6 +226,8 @@ nv30_vbo_validate(struct nv30_context *nv30) user = (nv30->vbo_user & (1 << ve->vertex_buffer_index)); res = nv04_resource(vb->buffer); + if (!res) + continue; if (nv30->vbo_fifo || unlikely(vb->stride == 0)) { if (!nv30->vbo_fifo) With patch above, stk doesn't produce core anymore and Xorg freezes. So far, mesa 8 is better. I could use it...

...v50) == FALSE) + return FALSE; + + emit->nr_ve = 0; + emit->vtx_dwords = 0; + + for (i = 0; i < nv50->vtxelt_nr; ++i) { + struct pipe_vertex_element *ve; + struct pipe_vertex_buffer *vb; + unsigned n, type, size; + + ve = &nv50->vtxelt[i]; + vb = &nv50->vtxbuf[ve->vertex_buffer_index]; + if (!(nv50->vbo_fifo & (1 << i))) + continue; + n = emit->nr_ve++; + + emit->stride[n] = vb->stride; + emit->map[n] = nouveau_bo(vb->buffer)->map + + (start * vb->stride + ve->src_offset); + + type = pf_type(ve->src_format); + size = pf_size_x(v...