search for: version_less

In the root llvm/CMakeLists.txt we have: if( ${PYTHON_VERSION_STRING} VERSION_LESS 2.7 ) message(FATAL_ERROR "Python 2.7 or newer is required") endif() But lit seems to still be stuck in a Python 2.5 world. For example, detectCPUs is redundant now that we have multiprocessing.cpu_count() (multiprocessing requires >=2.6). And there are a bunch of other Python 2.5 w...

...of work... > One approach commonly used with CMake modules that change frequently upstream is for the project to keep a local copy and have a check in place to use CMake's version if new enough. For instance, in llvm's source tree: cmake/modules/ExternalProject.cmake: if(CMAKE_VERSION VERSION_LESS "3.5.1") include(${PROJECT_SOURCE_DIR}/cmake/modules/newcmake/ExternalProject.cmake) else() include(${CMAKE_ROOT}/Modules/ExternalProject.cmake) endif() cmake/modules/newcmake/ExternalProject.cmake - Copy of the ExternalProject.cmake shipped with 3.5.1 Then in the top level CMakeList...

...t gmail.com> wrote: > > Seems reasonable to me. Chris? > > On Mon, Feb 22, 2016, 8:40 PM Sean Silva via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > In the root llvm/CMakeLists.txt we have: > > if( ${PYTHON_VERSION_STRING} VERSION_LESS 2.7 ) > message(FATAL_ERROR "Python 2.7 or newer is required") > endif() > > But lit seems to still be stuck in a Python 2.5 world. For example, detectCPUs is redundant now that we have multiprocessing.cpu_count() (multiprocessing requires >=2.6). And there are a bunch o...

...G_LINK_COMPONENTS) + if (LLVM_LINK_LLVM_DYLIB AND NOT ARG_DISABLE_LLVM_LINK_LLVM_DYLIB) + set(llvm_libs LLVM) + else() + llvm_map_components_to_libnames(llvm_libs + ${ARG_LINK_COMPONENTS} + ${LLVM_LINK_COMPONENTS} + ) + endif() endif() if(CMAKE_VERSION VERSION_LESS 2.8.12) Index: cmake/modules/LLVM-Config.cmake =================================================================== --- cmake/modules/LLVM-Config.cmake (revision 259743) +++ cmake/modules/LLVM-Config.cmake (working copy) @@ -40,10 +40,17 @@ # done in case libLLVM does not contain all of...

..._LINK_COMPONENTS) + if (LLVM_LINK_LLVM_DYLIB AND NOT ARG_DISABLE_LLVM_LINK_LLVM_DYLIB) + set(llvm_libs LLVM) + else() + llvm_map_components_to_libnames(llvm_libs + ${ARG_LINK_COMPONENTS} + ${LLVM_LINK_COMPONENTS} + ) + endif() + endif() + if(CMAKE_VERSION VERSION_LESS 2.8.12) # Link libs w/o keywords, assuming PUBLIC. target_link_libraries(${name} @@ -885,11 +891,18 @@ add_llvm_executable(${test_name} IGNORE_EXTERNALIZE_DEBUGINFO ${ARGN}) set(outdir ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}) set_output_directory(${test_name} BINARY_DIR $...

...stopher <echristo at gmail.com> wrote: > > Seems reasonable to me. Chris? > > On Mon, Feb 22, 2016, 8:40 PM Sean Silva via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> In the root llvm/CMakeLists.txt we have: >> >> if( ${PYTHON_VERSION_STRING} VERSION_LESS 2.7 ) >> message(FATAL_ERROR "Python 2.7 or newer is required") >> endif() >> >> But lit seems to still be stuck in a Python 2.5 world. For example, >> detectCPUs is redundant now that we have multiprocessing.cpu_count() >> (multiprocessing requires &...

Most of the comments I have are actually very well captured by Chandler's email, so I'm not going to pile on. I do have a few things to add. Renato, in your most recent email you comment about differentiating *stable* vs random versions of CMake built from source. I believe as a community our recommendation should be that people download CMake sources from https://CMake.org/download/