search for: verkuil

From: Hans Verkuil <hans.verkuil at cisco.com> Repost because I wasn't a member of the nouveau mailinglist the first time around and this series was blocked. I also updated this cover letter for the part about the amdgpu patch after receiving feedback from Alex Deucher. The patches are unchanged (except fo...

Reviewed-by: Lyude Paul <lyude at redhat.com> We really need to add support for using this into the MST helpers. A good way to test this would probably be to hook up an aux device to the DP AUX adapters we create for each MST topology On Fri, 2018-08-17 at 16:11 +0200, Hans Verkuil wrote: > From: Hans Verkuil <hans.verkuil at cisco.com> > > When parsing the reply of a DP_REMOTE_DPCD_READ DPCD command the > result is wrong due to a missing idx increment. > > This was never noticed since DP_REMOTE_DPCD_READ is currently not > used, but if you enable...

From: Hans Verkuil <hans.verkuil at cisco.com> Now that the DisplayPort CEC-Tunneling-over-AUX drm+i915 support has been merged in the mainline kernel it is time to roll this out to nouveau and amdgpu as well. I combined both in the same patch series since both depend on the same first patch, the comments in...

From: Hans Verkuil <hans.verkuil at cisco.com> Now that the DisplayPort CEC-Tunneling-over-AUX drm+i915 support has been merged in the mainline kernel it is time to roll this out to nouveau and amdgpu as well. The first patch is required for this: it adds checks that the drm_dp_cec functions are called with a...

On 2018-08-17 10:11 AM, Hans Verkuil wrote: > From: Hans Verkuil <hans.verkuil at cisco.com> > > Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. > > Signed-off-by: Hans Verkuil <hans.verkuil at cisco.com> > Acked-by: Alex Deucher <alexander.deucher at amd.com> > --- > drivers/gpu/...

On Fri, 2018-08-17 at 16:11 +0200, Hans Verkuil wrote: > From: Hans Verkuil <hans.verkuil at cisco.com> > > If aux->transfer == NULL, then just return without doing > anything. In that case the function is likely called for > a non-(e)DP connector. > > This never happened for the i915 driver, but the nouveau and a...

On Fri, Aug 24, 2018 at 3:20 AM Hans Verkuil <hverkuil at xs4all.nl> wrote: > > On 08/23/2018 08:38 PM, Harry Wentland wrote: > > On 2018-08-17 10:11 AM, Hans Verkuil wrote: > >> From: Hans Verkuil <hans.verkuil at cisco.com> > >> > >> Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu....

...> We really need to add support for using this into the MST helpers. A good way to > test this would probably be to hook up an aux device to the DP AUX adapters we > create for each MST topology If you are interested, I have code for that in my MST test branch: https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=cec-nv-amd-mst It's the "drm_dp_mst_topology: use correct AUX channel" patch. I don't have plans to post this patch since CEC for MST isn't working (still trying to figure out why not), but you are free to pick it up if you want. Regards, Hans >...

From: Hans Verkuil <hans.verkuil at cisco.com> Signed-off-by: Hans Verkuil <hans.verkuil at cisco.com> [sammc at chromium.org: - rebased - removed polling-related changes - moved the calls to drm_dp_cec_(un)set_edid() into the next patch ] Signed-off-by: Sam McNally <sammc at chromium.org> ---...

On 08/23/2018 08:38 PM, Harry Wentland wrote: > On 2018-08-17 10:11 AM, Hans Verkuil wrote: >> From: Hans Verkuil <hans.verkuil at cisco.com> >> >> Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. >> >> Signed-off-by: Hans Verkuil <hans.verkuil at cisco.com> >> Acked-by: Alex Deucher <alexander.deucher at amd.com> >&...

On 08/20/2018 08:51 PM, Lyude Paul wrote: > On Fri, 2018-08-17 at 16:11 +0200, Hans Verkuil wrote: >> From: Hans Verkuil <hans.verkuil at cisco.com> >> >> If aux->transfer == NULL, then just return without doing >> anything. In that case the function is likely called for >> a non-(e)DP connector. >> >> This never happened for the i915 dri...

From: Hans Verkuil <hans.verkuil at cisco.com> If aux->transfer == NULL, then just return without doing anything. In that case the function is likely called for a non-(e)DP connector. This never happened for the i915 driver, but the nouveau and amdgpu drivers need this check. The alternative would be to a...

From: Hans Verkuil <hans.verkuil at cisco.com> Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. Signed-off-by: Hans Verkuil <hans.verkuil at cisco.com> Acked-by: Alex Deucher <alexander.deucher at amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +++++++++++-- .../dr...

From: Hans Verkuil <hans.verkuil at cisco.com> A big problem with DP CEC-Tunneling-over-AUX is that it is tricky to find adapters with a chipset that supports this AND where the manufacturer actually connected the HDMI CEC line to the chipset. Add a mention of the MegaChips 2900 chipset which seems to support...

From: Hans Verkuil <hans.verkuil at cisco.com> Add DisplayPort CEC-Tunneling-over-AUX support to nouveau. Signed-off-by: Hans Verkuil <hans.verkuil at cisco.com> --- drivers/gpu/drm/nouveau/nouveau_connector.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/driver...

From: Hans Verkuil <hans.verkuil at cisco.com> When parsing the reply of a DP_REMOTE_DPCD_READ DPCD command the result is wrong due to a missing idx increment. This was never noticed since DP_REMOTE_DPCD_READ is currently not used, but if you enable it, then it is all wrong. Signed-off-by: Hans Verkuil <h...

From: Hans Verkuil <hans.verkuil at cisco.com> Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. Signed-off-by: Hans Verkuil <hans.verkuil at cisco.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +++++++++++-- .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 ++ 2 fil...

From: Hans Verkuil <hans.verkuil at cisco.com> Add DisplayPort CEC-Tunneling-over-AUX support to nouveau. Signed-off-by: Hans Verkuil <hans.verkuil at cisco.com> --- drivers/gpu/drm/nouveau/nouveau_connector.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/driver...

From: Hans Verkuil <hans.verkuil at cisco.com> When parsing the reply of a DP_REMOTE_DPCD_READ DPCD command the result is wrong due to a missing idx increment. This was never noticed since DP_REMOTE_DPCD_READ is currently not used, but if you enable it, then it is all wrong. Signed-off-by: Hans Verkuil <h...

From: Hans Verkuil <hans.verkuil at cisco.com> If aux->transfer == NULL, then just return without doing anything. In that case the function is likely called for a non-(e)DP connector. This never happened for the i915 driver, but the nouveau and amdgpu drivers need this check. The alternative would be to a...