search for: verify_octal_permissions

Displaying 10 results from an estimated 10 matches for "verify_octal_permissions".

2014 Mar 19
5
[PATCH] virtio-blk: make the queue depth configurable
...duleparam_const __param_##name \ >> >> It might make sense to separate this octal permissions >> test into a new macro for other checks in macros like >> CLASS_ATTR, DEVICE_ATTR, SENSOR_ATTR and SENSOR_ATTR_2. OK, I took your bikeshed and re-painted it below. > #define VERIFY_OCTAL_PERMISSIONS(perms) \ > ({ \ > if (__builtin_constant_p(perms)) { \ > BUILD_BUG_ON((perms) < 0); \ > BUILD_BUG_ON((perms) > 0777); \ > /* User perms >= group perms >= other perms */ \ > BUILD_BUG_ON(((perms) >> 6) < (((perms) >> 3) &amp...
2014 Mar 19
5
[PATCH] virtio-blk: make the queue depth configurable
...duleparam_const __param_##name \ >> >> It might make sense to separate this octal permissions >> test into a new macro for other checks in macros like >> CLASS_ATTR, DEVICE_ATTR, SENSOR_ATTR and SENSOR_ATTR_2. OK, I took your bikeshed and re-painted it below. > #define VERIFY_OCTAL_PERMISSIONS(perms) \ > ({ \ > if (__builtin_constant_p(perms)) { \ > BUILD_BUG_ON((perms) < 0); \ > BUILD_BUG_ON((perms) > 0777); \ > /* User perms >= group perms >= other perms */ \ > BUILD_BUG_ON(((perms) >> 6) < (((perms) >> 3) &amp...
2014 Mar 17
2
[PATCH] virtio-blk: make the queue depth configurable
...tr_##name[] = prefix #name; \ > static struct kernel_param __moduleparam_const __param_##name \ It might make sense to separate this octal permissions test into a new macro for other checks in macros like CLASS_ATTR, DEVICE_ATTR, SENSOR_ATTR and SENSOR_ATTR_2. Maybe something like: #define VERIFY_OCTAL_PERMISSIONS(perm) \ static int __param_perm_check_##name __attribute__((unused)) = \ BUILD_BUG_ON_ZERO((perm) < 0 || (perm) > 0777 || ((perm) & 2)) \ /* User perms >= group perms >= other perms. */ \ + BUILD_BUG_ON_ZERO(((perm) >> 6) < (((perm) >> 3) & 7)) \ + BUIL...
2014 Mar 17
2
[PATCH] virtio-blk: make the queue depth configurable
...tr_##name[] = prefix #name; \ > static struct kernel_param __moduleparam_const __param_##name \ It might make sense to separate this octal permissions test into a new macro for other checks in macros like CLASS_ATTR, DEVICE_ATTR, SENSOR_ATTR and SENSOR_ATTR_2. Maybe something like: #define VERIFY_OCTAL_PERMISSIONS(perm) \ static int __param_perm_check_##name __attribute__((unused)) = \ BUILD_BUG_ON_ZERO((perm) < 0 || (perm) > 0777 || ((perm) & 2)) \ /* User perms >= group perms >= other perms. */ \ + BUILD_BUG_ON_ZERO(((perm) >> 6) < (((perm) >> 3) & 7)) \ + BUIL...
2014 Mar 19
0
[PATCH] virtio-blk: make the queue depth configurable
...>>> >>> It might make sense to separate this octal permissions >>> test into a new macro for other checks in macros like >>> CLASS_ATTR, DEVICE_ATTR, SENSOR_ATTR and SENSOR_ATTR_2. > > OK, I took your bikeshed and re-painted it below. > >> #define VERIFY_OCTAL_PERMISSIONS(perms) \ >> ({ \ >> if (__builtin_constant_p(perms)) { \ >> BUILD_BUG_ON((perms) < 0); \ >&g...
2014 Mar 19
1
[PATCH] virtio-blk: make the queue depth configurable
Couple more bikesheddy things: Is there ever a reason to use a non __builtin_const_p(perms)? Maybe that should be a BUILD_BUG_ON too BUILD_BUG_ON(!builtin_const_p_perms) My brain of little size gets confused by the BUILD_BUG_ON_ZERO(foo) + vs BUILD_BUG_ON(foo); as it just seems like more text for the same content. Is there any value on the "_ZERO(foo) +" I don't understand?
2014 Mar 19
1
[PATCH] virtio-blk: make the queue depth configurable
Couple more bikesheddy things: Is there ever a reason to use a non __builtin_const_p(perms)? Maybe that should be a BUILD_BUG_ON too BUILD_BUG_ON(!builtin_const_p_perms) My brain of little size gets confused by the BUILD_BUG_ON_ZERO(foo) + vs BUILD_BUG_ON(foo); as it just seems like more text for the same content. Is there any value on the "_ZERO(foo) +" I don't understand?
2014 Mar 17
0
[PATCH] virtio-blk: make the queue depth configurable
...atic struct kernel_param __moduleparam_const __param_##name \ > > It might make sense to separate this octal permissions > test into a new macro for other checks in macros like > CLASS_ATTR, DEVICE_ATTR, SENSOR_ATTR and SENSOR_ATTR_2. > > Maybe something like: > > #define VERIFY_OCTAL_PERMISSIONS(perm) \ > static int __param_perm_check_##name __attribute__((unused)) = \ > BUILD_BUG_ON_ZERO((perm) < 0 || (perm) > 0777 || ((perm) & 2)) \ > /* User perms >= group perms >= other perms. */ \ > + BUILD_BUG_ON_ZERO(((perm) >> 6) < (((perm) >> 3)...
2014 Mar 14
2
[PATCH] virtio-blk: make the queue depth configurable
On Fri, Mar 14, 2014 at 10:38:40AM -0700, Joe Perches wrote: > > +static int queue_depth = 64; > > +module_param(queue_depth, int, 444); > > 444? Really Ted? Oops, *blush*. Thanks for catching that. - Ted
2014 Mar 14
2
[PATCH] virtio-blk: make the queue depth configurable
On Fri, Mar 14, 2014 at 10:38:40AM -0700, Joe Perches wrote: > > +static int queue_depth = 64; > > +module_param(queue_depth, int, 444); > > 444? Really Ted? Oops, *blush*. Thanks for catching that. - Ted