search for: vedant_kumar

Excellent, thanks! --paulr From: James Y Knight [mailto:jyknight at google.com] Sent: Thursday, November 29, 2018 12:00 PM To: Robinson, Paul Cc: Mikhail Ramalho; vedant_kumar at apple.com; llvm-dev Subject: Re: [llvm-dev] 'git llvm push' not working for me on Windows Aha! From your output I figured out what I screwed up. Sorry about the trouble... Illustration of the issue: svn checkout --depth=empty https://llvm.org/svn/llvm-project svn update --depth=immedia...

...f small growth, if it doesn't add more relocations (I think the call sites need them (but they're already emitted/that's not what we're discussing enabling here), but call value descriptions don't), sounds good to me :) > > On Fri, Feb 7, 2020 at 12:04 PM Vedant Kumar <vedant_kumar at apple.com <mailto:vedant_kumar at apple.com>> wrote: > Hi all, > > I think we've reached a state where we're ready to enable debug entry value production by default for the x86_64, ARM, and AArch64 targets. For context, this is a debug info feature that allows debugger...

...d also patch llvm/utils/git-svn/git-llvm to add the `--verbose` option to the `git apply` command, which would provide better diagnostic output. HTH, --paulr From: Petr Hosek [mailto:phosek at chromium.org] Sent: Wednesday, January 30, 2019 10:52 PM To: Robinson, Paul Cc: James Y Knight; llvm-dev; vedant_kumar at apple.com Subject: Re: [llvm-dev] 'git llvm push' not working for me on Windows I just hit this failure as well. I've uploaded the log to https://reviews.llvm.org/P8126. The error message is: `git apply -p2 -` returned 1 error: patch failed: lib/Basic/Version.cpp:14 error: lib/Basi...

...t.unlikely section is also reducing significantly, so it seems like some of the already cold blocks are getting split - has anyone noticed that? Teresa > -Aditya > > ------------------------------ > *From:* vsk at apple.com <vsk at apple.com> on behalf of Vedant Kumar < > vedant_kumar at apple.com> > *Sent:* Monday, January 28, 2019 1:00 PM > *To:* Aditya K > *Cc:* llvm-dev at lists.llvm.org; Sebastian Pop > *Subject:* Re: [llvm-dev] Status update on the hot/cold splitting pass > > The splitting pass currently doesn’t move cold symbols into a separate > s...

On Tue, Feb 5, 2019, 3:46 PM Vedant Kumar <vedant_kumar at apple.com> wrote: > Hi Teresa, > > On Feb 5, 2019, at 2:38 PM, Teresa Johnson via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > > > > On Mon, Jan 28, 2019 at 11:03 AM Aditya K via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> &g...

...small growth, if it doesn't add more relocations (I think the call sites need them (but they're already emitted/that's not what we're discussing enabling here), but call value descriptions don't), sounds good to me :) > > On Fri, Feb 7, 2020 at 12:04 PM Vedant Kumar <vedant_kumar at apple.com <mailto:vedant_kumar at apple.com>> wrote: > Hi all, > > I think we've reached a state where we're ready to enable debug entry value production by default for the x86_64, ARM, and AArch64 targets. For context, this is a debug info feature that allows debugge...

...hich is not a typical case for mobile workload, I wanted to be precautious of enabling it by default. However, as with default outlining case, I don't mind enabling this under -Oz (for minimizing code) with an opt-out option. Regards, Kyungwoo On Tue, Mar 24, 2020 at 12:01 PM Vedant Kumar <vedant_kumar at apple.com> wrote: > This looks really interesting. In the slides, it’s mentioned that the > combination of tuning the MachineOutliner for ThinLTO and of optimizing > function prolog/epilogs improved measured run-time performance. > > What kind of performance impact do you see...

...39;t add more relocations (I think the call sites need them (but they're already emitted/that's not what we're discussing enabling here), but call value descriptions don't), sounds good to me :) > >   > > On Fri, Feb 7, 2020 at 12:04 PM Vedant Kumar <vedant_kumar at apple.com <mailto:vedant_kumar at apple.com>> wrote: > > Hi all, > >   > > I think we've reached a state where we're ready to enable debug entry value production by default for the x86_64, ARM, and AArch64 targets. For con...

...-mdnode.ll... Patch doesn't apply: maybe you should try `git pull -r` first? From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of via llvm-dev Sent: Wednesday, November 28, 2018 2:39 PM To: mikhail.ramalho at gmail.com; jyknight at google.com Cc: llvm-dev at lists.llvm.org; vedant_kumar at apple.com Subject: Re: [llvm-dev] 'git llvm push' not working for me on Windows And now it's failing for me also… complaining about "no such file or directory" on a file that plainly exists. Verbose log attached. --paulr From: Mikhail Ramalho [mailto:mikhail.ramalho at gm...

...t aggressive hot-cold splitting. Static profile isn't helping much for our use cases. I'll be curious to know if someone got good improvements only with static profile analysis. > > > -Aditya > > From: vsk at apple.com <vsk at apple.com> on behalf of Vedant Kumar <vedant_kumar at apple.com> > Sent: Friday, January 25, 2019 6:29 PM > To: llvm-dev at lists.llvm.org > Cc: Aditya Kumar; Sebastian Pop; Teresa Johnson; jun.l at samsung.com; Duncan Smith; Gerolf Hoflehner > Subject: Status update on the hot/cold splitting pass > > Hello, > > I’d li...

I think I get it now, thanks for explaining! >> On Jan 12, 2020, at 11:44 AM, David Blaikie via llvm-dev <llvm-dev at lists.llvm.org> wrote: >  > > >> On Fri, Jan 10, 2020 at 12:57 PM Vedant Kumar <vedant_kumar at apple.com> wrote: >> I don't totally follow the proposed encoding change & would appreciate a small example. >> >> Is the idea to replace e.g. an 'AT_low_pc (<direct address>) + relocation for <direct address>' with an 'AT_low_pc (<indirec...

Hi all, I think we've reached a state where we're ready to enable debug entry value production by default for the x86_64, ARM, and AArch64 targets. For context, this is a debug info feature that allows debuggers to recover the value of unmodified optimized-out parameters by 'going up' a stack frame and interpreting spilled values, constants, etc. to work out what was passed to the

...tially *decrease* scheduling potential. Solution 3 would align debug mode with non-debug mode (in terms of instruction scheduling) and therefore *increase* scheduling potential. David ________________________________ From: vsk at apple.com <vsk at apple.com> on behalf of Vedant Kumar <vedant_kumar at apple.com> Sent: 30 September 2019 20:50 To: David Tellenbach <David.Tellenbach at arm.com> Cc: paul.robinson at sony.com <paul.robinson at sony.com>; llvm-dev at lists.llvm.org <llvm-dev at lists.llvm.org>; nd <nd at arm.com>; Tim Northover <tnorthover at apple.com...

I just got a Diffusion notification about a change of mine being reverted by Fangrui, but I'm not sure that's actually what happened and am confused and concerned. My commit was "[DebugInfo] Allow spill slots in call site parameter descriptions", and it appears in the history under two hashes: 1ee84e and 67c416. The first commit contains the actual change. The second touches

Hi Sourabh, Thanks for raising this issue. To answer your question, (afaik) there isn’t anyone working on DW_AT_start_scope support in tree. We’re looking for a solution to this problem for Swift debugging, where it's important not to make a debug location for a variable available until its (guaranteed) initialization is complete. If at all possible, I’d /much/ rather we use the existing

OK, I've managed to do it: I was trying to push it from a build/ directory, maybe that's why the git apply was failing. Pushing the commit from the root of the repo worked. Em qua, 28 de nov de 2018 às 16:40, Mikhail Ramalho < mikhail.ramalho at gmail.com> escreveu: > Hi, > > The patch only changes one file in clang. Here's the patch: >

Hi Vedant, thanks for the detailed response, On Tue, Feb 25, 2020 at 7:23 AM Vedant Kumar <vedant_kumar at apple.com> wrote: > > Finally, being forced to always specify both the machine location and > > the program location at the same time (in a single DBG_VALUE) > > introduces un-necessary burdens. In MachineSink, when we sink between > > blocks an instruction that define...

Hello, I’d like to give a status update to the community about the recently-added hot/cold splitting pass. I'll provide some motivation for the pass, describe its implementation, summarize recent/ongoing work, and share early results. # Motivation We (at Apple) have found that memory pressure from resident pages of code is significant on embedded devices. In particular, this pressure spikes

Hi Xiang, On Wed, Nov 11, 2020 at 1:59 AM Zhang, Xiang1 <xiang1.zhang at intel.com> wrote: > Jeremy wrote: > > ... The value %0 is live up to and including the ADD64ri but not past it, meaning LLVM today will drop the DBG_VALUE ... > > Just a little puzzle about the " drop the DBG_VALUE ", maybe I didn't get your key point, >

I don't totally follow the proposed encoding change & would appreciate a small example. Is the idea to replace e.g. an 'AT_low_pc (<direct address>) + relocation for <direct address>' with an 'AT_low_pc (<indirection into a pool of addresses> + offset)', s.t. the cost of a relocation for the address is paid down the more it's used? How do you figure