search for: vdpa_setup_irq

On 2020/7/12 ??10:49, Zhu Lingshan wrote: > This commit implements IRQ offloading helpers in vDPA core by > introducing two couple of functions: > > vdpa_alloc_vq_irq() and vdpa_free_vq_irq(): request irq and free > irq, will setup irq offloading if irq_bypass is enabled. > > vdpa_setup_irq() and vdpa_unsetup_irq(): supportive functions, > will call vhost_vdpa helpers. > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> This patch should go before patch 3. > --- > drivers/vdpa/vdpa.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > driver...

...gt; This commit implements IRQ offloading helpers Let's say "vq irq allocate/free helpers" here. > in vDPA core by > introducing two couple of functions: > > vdpa_alloc_vq_irq() and vdpa_free_vq_irq(): request irq and free > irq, will setup irq offloading. > > vdpa_setup_irq() and vdpa_unsetup_irq(): supportive functions, > will call vhost_vdpa helpers. > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > Suggested-by: Jason Wang <jasowang at redhat.com> > --- > drivers/vdpa/vdpa.c | 42 +++++++++++++++++++++++++++++++++++++++++...

...into account. >>>> >>>> And how can this synchronize with driver releasing and binding? >>> Will add an vdpa_unsetup_irq() call in vhsot_vdpa_release(). >>> For binding, I think it is a new dev bound to the the driver, >>> it should go through the vdpa_setup_irq() routine. or if it is >>> a device re-bind to vhost_vdpa, I think we have cleaned up >>> irq_bypass_producer for it as we would call vhdpa_unsetup_irq() >>> in the release function. >> >> >> I meant can the following things happen? >> >> 1)...

...eck this when we take the releasing path into account. >> >> And how can this synchronize with driver releasing and binding? > Will add an vdpa_unsetup_irq() call in vhsot_vdpa_release(). > For binding, I think it is a new dev bound to the the driver, > it should go through the vdpa_setup_irq() routine. or if it is > a device re-bind to vhost_vdpa, I think we have cleaned up > irq_bypass_producer for it as we would call vhdpa_unsetup_irq() > in the release function. I meant can the following things happen? 1) some vDPA device driver probe the hardware and call vdpa_request_...

...unsigned long irqflags, const char *devname, void *dev_id, > + int qid) > +{ > + int ret; > + > + ret = devm_request_irq(dev, irq, handler, irqflags, devname, dev_id); > + if (ret) > + dev_err(dev, "Failed to request irq for vq %d\n", qid); > + else > + vdpa_setup_irq(vdev, qid, irq); > + > + return ret; > + > +} > +EXPORT_SYMBOL_GPL(vdpa_devm_request_irq);