search for: vdebug

...PI used only for testing language bindings. It is guarded by GUESTFS_PRIVATE in the C api, but exported by all other language bindings as it is required for testing. If language bindings offer any way to guard use of these apis, that mechanism should be used. It is not documented anywhere. VDebug: A debugging API. It is exported by all language bindings, and in guestfish, but is not documented anywhere. VInternal: An internal-only API. It is guarded by GUESTFS_PRIVATE in the C api, and not exported at all in any other language binding. It is not documented anywhere. --- generato...

...is will shorten the latency for tx. Signed-off-by: Dor Laor <dor.laor@qumranet.com> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 7b051d5..8bb17d1 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -406,10 +405,10 @@ again: virtio_debug(vdebug, "%s: before calling kick %d\n", __FUNCTION__, __LINE__); vi->svq->vq_ops->kick(vi->svq); vi->out_num = 0; - } else { - vi->stats.hrtimer_starts++; - hrtimer_start(&vi->tx_timer, ktime_set(0,500000), - HRTIMER_M...

...is will shorten the latency for tx. Signed-off-by: Dor Laor <dor.laor@qumranet.com> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 7b051d5..8bb17d1 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -406,10 +405,10 @@ again: virtio_debug(vdebug, "%s: before calling kick %d\n", __FUNCTION__, __LINE__); vi->svq->vq_ops->kick(vi->svq); vi->out_num = 0; - } else { - vi->stats.hrtimer_starts++; - hrtimer_start(&vi->tx_timer, ktime_set(0,500000), - HRTIMER_M...

...vate.h /src/guestfs-structs.pod /src/libguestfs.3 /src/libguestfs.pc diff --git a/generator/c.ml b/generator/c.ml index f0df5ea..4497c48 100644 --- a/generator/c.ml +++ b/generator/c.ml @@ -39,7 +39,13 @@ let is_public { visibility = v } = match v with | VPublic | VPublicNoFish | VStateTest | VDebug -> true | VBindTest | VInternal -> false -let is_private f = not (is_public f) +let is_private { visibility = v } = match v with + | VBindTest -> true + | VPublic | VPublicNoFish | VStateTest | VDebug | VInternal -> false + +let is_internal { visibility = v } = match v with + |...

Move the generate_all_structs and generate_all_headers functions, previously internal within the implementation of generate_guestfs_h, to be usable by other functions in the same "C" module (but not public). Only code motion. --- generator/c.ml | 163 +++++++++++++++++++++++++++++---------------------------- 1 file changed, 82 insertions(+), 81 deletions(-) diff --git a/generator/c.ml

I pushed a few of the msys2 patches upstream. I changed the way that $(SHARED_LDFLAGS) works so it's more to my liking, and the others were pushed unchanged. Three patches remain which I'm posting on the mailing list for proper review. Rich.

...ic void nbdkit_verror (const char *msg, va_list args) +{ + _nbdkit_functions.verror (msg, args); +} +static void nbdkit_debug (const char *msg, ...) + ATTRIBUTE_FORMAT_PRINTF (1, 2); +static void nbdkit_debug (const char *msg, ...) +{ + va_list args; + va_start (args, msg); + _nbdkit_functions.vdebug (msg, args); + va_end (args); +} +static void nbdkit_vdebug (const char *msg, va_list args) + ATTRIBUTE_FORMAT_PRINTF (1, 0); +static void nbdkit_vdebug (const char *msg, va_list args) +{ + _nbdkit_functions.vdebug (msg, args); +} + +static char *nbdkit_absolute_path (const char *path) +{ + ret...

Hi, attached there is the second version of the patch series adding copy_in and copy_out in the library, mostly moving them from guestfish. It also adds the copy_in usage in virt-customize, as aid in a new image building. Thanks, Pino Toscano (7): cmd: add a way to run (and wait) asynchronously commands cmd: add a child-setup callback cmd: add the possibility to get a fd to the process

--- src/command.c | 64 +++++++++++++++++++++++++++++++++++++++++++------- src/guestfs-internal.h | 3 +++ 2 files changed, 58 insertions(+), 9 deletions(-) diff --git a/src/command.c b/src/command.c index 4bb469b..e26573d 100644 --- a/src/command.c +++ b/src/command.c @@ -360,7 +360,7 @@ debug_command (struct command *cmd) } static int -run_command (struct command *cmd)

...ler {..} parent, unsigned int max_errors, unsigned int errors, unsigned int warnings, _Bool log_info, _Bool log_debug, pointer to function(..) returning void verror, pointer to function(..) returning void vwarning, pointer to function(..) returning void vinfo, pointer to function(..) returning void vdebug, pointer to function(..) returning void free}, unsigned int, _Bool) returning _Bool previous: function(pointer to struct sieve_multiscript {pointer to struct sieve_instance {..} svinst, pointer to struct sieve_result {..} result, pointer to const struct sieve_message_data {..} msgdata, pointer to...

...on is used internally when setting up the appliance." }; name = "internal_exit"; added = (1, 23, 30); style = RErr, [], []; proc_nr = Some 414; - visibility = VInternal; + (* Really VInternal, but we need to use it from the Perl bindings. XXX *) + visibility = VDebug; cancellable = true; shortdesc = "cause the daemon to exit (internal use only)"; longdesc = "\ diff --git a/tests/daemon/captive-daemon.pm.in b/tests/daemon/captive-daemon.pm.in index 991a9a1..19833b8 100644 --- a/tests/daemon/captive-daemon.pm.in +++ b/tests/daemon/ca...

...nt fib_right(int i) { if (i < 2) return 1; return fib_left(i-1) + fib_right(i-2); } int fib(int i) { if (i < 2) return 1; return fib_left(i-1) + fib_right(i-2); } int main() { int i = 45; printf("fib(%d) == %d\n", i, fib(i)); } $clang -g -S -emit-llvm -o loopy.ll loopy.c $ operf -Vdebug -e CPU_CLK_UNHALTED:5000000 lli -debug-only="oprofile-jit-event-listener" loopy.ll Using samples dir /home/dad/oprofile_data/samples Kernel profiling is not possible with current system config Set /proc/sys/kernel/kptr_restrict to 0 to collect kernel samples. Exec args are: lli -debug-onl...

This is only lightly tested at the moment. For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1138203#c40 https://bugzilla.redhat.com/show_bug.cgi?id=1075143 https://bugzilla.redhat.com/show_bug.cgi?id=1075164 Note this is not a complete fix. At least one more libguestfs patch is required (to implement virDomainPtr in the python bindings). Plus a virt-manager patch. Rich.

...t_peer_name not implemented on this platform"); + return -1; +} + +static void init_functions () +{ + functions = malloc (sizeof *functions); + if (functions == NULL) { + perror ("malloc"); + exit (EXIT_FAILURE); + } + functions->verror = nbdkit_verror; + functions->vdebug = nbdkit_vdebug; + functions->absolute_path = nbdkit_absolute_path; + functions->parse_size = nbdkit_parse_size; + functions->parse_bool = nbdkit_parse_bool; + functions->parse_int = nbdkit_parse_int; + functions->parse_unsigned = nbdkit_parse_unsigned; + functions->parse_in...

This completes the implementation on the libguestfs side, allowing python-libvirt dom pointers to be passed to guestfs_add_libvirt_dom. For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1138203#c40 https://bugzilla.redhat.com/show_bug.cgi?id=1075143 https://bugzilla.redhat.com/show_bug.cgi?id=1075164 Rich.

...eturn fib_left(i-1) + fib_right(i-2); } > int fib(int i) { if (i < 2) return 1; > return fib_left(i-1) + fib_right(i-2); } > > int main() { > int i = 45; printf("fib(%d) == %d\n", i, fib(i)); } > > $clang -g -S -emit-llvm -o loopy.ll loopy.c > > $ operf -Vdebug -e CPU_CLK_UNHALTED:5000000 lli > -debug-only="oprofile-jit-event-listener" loopy.ll > Using samples dir /home/dad/oprofile_data/samples > Kernel profiling is not possible with current system config > Set /proc/sys/kernel/kptr_restrict to 0 to collect kernel samples. > Exec...

A hopefully cleaner implementation this time. It doesn't require any special insights into how libvirt-python is implemented. Instead, it requires a change to libvirt-python to add a .c_pointer() method: https://www.redhat.com/archives/libvir-list/2014-December/msg00615.html Rich.

Since v3: - Fix labelling over overlays (see 6/6) - Tested it with a test program which simulates what virt-manager will do. See the attachment here: https://bugzilla.redhat.com/show_bug.cgi?id=1075164#c7 Rich.

In v2: - Kernel command line parsing now moved to the appliance. - In the captive daemon test, the daemon cleanly shuts down on exit. - Add another btrfs test. Rich.

By splitting up large C files we can make parallel compiles a bit faster. Rich.