search for: vddk_minor

...rliest version of VDDK that we support. */ diff --git a/plugins/vddk/vddk.c b/plugins/vddk/vddk.c index e2c0bf7d..87c0d146 100644 --- a/plugins/vddk/vddk.c +++ b/plugins/vddk/vddk.c @@ -70,7 +70,7 @@ int vddk_debug_datapath = 1; /* Parameters passed to InitEx. */ #define VDDK_MAJOR 5 -#define VDDK_MINOR 1 +#define VDDK_MINOR 5 static void *dl; /* dlopen handle */ static bool init_called; /* was InitEx called */ @@ -363,14 +363,14 @@ load_library (void) static const char *sonames[] = { /* Prefer the newest library in case multiple exist. Check...

We had a query yesterday about the VDDK plugin and making it actually obey the weird "Multithreading Considerations" rules in the VDDK documentation (https://vdc-download.vmware.com/vmwb-repository/dcr-public/8f96698a-0e7b-4d67-bb6c-d18a1d101540/ef536a47-27cd-481a-90ef-76b38e75353c/vsphere-vddk-671-programming-guide.pdf) This patch is my attempt to implement this. The idea is that the

...up to 6.7 (but should work with future versions). diff --git a/plugins/vddk/vddk.c b/plugins/vddk/vddk.c index 1beecabc..4bfcdea7 100644 --- a/plugins/vddk/vddk.c +++ b/plugins/vddk/vddk.c @@ -71,7 +71,7 @@ int vddk_debug_extents; /* Parameters passed to InitEx. */ #define VDDK_MAJOR 5 -#define VDDK_MINOR 1 +#define VDDK_MINOR 5 static void *dl; /* dlopen handle */ static bool init_called; /* was InitEx called */ @@ -361,14 +361,14 @@ load_library (void) static const char *sonames[] = { /* Prefer the newest library in case multiple exist. Check...

..., with or without * modification, are permitted provided that the following conditions are @@ -40,6 +40,7 @@ #include <string.h> #include <unistd.h> #include <dlfcn.h> +#include <fcntl.h> #define NBDKIT_API_VERSION 2 @@ -72,7 +73,8 @@ int vddk_debug_extents; #define VDDK_MINOR 1 static void *dl = NULL; /* dlopen handle */ -static int init_called = 0; /* was InitEx called */ +static bool init_called = false; /* was InitEx called */ +static char *reexeced = false; /* did libdir require reexec */ static char *confi...

This is my second attempt at this. The first version (also not working) was here: https://www.redhat.com/archives/libguestfs/2019-October/msg00062.html In part 1/2 I introduce a new .ready_to_serve plugin method which is called after forking and just before accepting any client connection. The idea would be that plugins could start background threads here. However this doesn't work well in

...ir) { + nbdkit_error ("strdup: %m"); + return -1; + } + } + load_library (); /* Initialize VDDK library. */ DEBUG_CALL ("VixDiskLib_InitEx", "%d, %d, &debug_fn, &error_fn, &error_fn, %s, %s", VDDK_MAJOR, VDDK_MINOR, - libdir ? : VDDK_LIBDIR, config ? : "NULL"); + libdir, config ? : "NULL"); err = VixDiskLib_InitEx (VDDK_MAJOR, VDDK_MINOR, &debug_function, /* log function */ &error_function, /* warn...

In v7: everything should work now! The re-exec code is slightly simplified, with Rich's suggestion to pass the original LD_LIBRARY_PATH rather than just the prefix being added, and I've now finished wiring up the initial dlopen() check into code that correctly computes the right prefix dir to add to LD_LIBRARY_PATH. Eric Blake (1): vddk: Add re-exec with altered environment Richard

...provided that the following conditions are > @@ -40,6 +40,7 @@ > #include <string.h> > #include <unistd.h> > #include <dlfcn.h> > +#include <fcntl.h> > > #define NBDKIT_API_VERSION 2 > > @@ -72,7 +73,8 @@ int vddk_debug_extents; > #define VDDK_MINOR 1 > > static void *dl = NULL; /* dlopen handle */ > -static int init_called = 0; /* was InitEx called */ > +static bool init_called = false; /* was InitEx called */ > +static char *reexeced = false; /* did libdir require reexe...

I couldn't get this to work in the end. This is the latest non-working version. This email documents what doesn't work for the permanent record. The central problem is that VDDK InitEx() appears to dlopen() various of its own plugins. Although I wasn't able to capture exactly what dlopen() command it is running, the plugins cannot be loaded because they rely on the recompiled

..._VERSION 2 @@ -50,6 +51,7 @@ #include "minmax.h" #include "rounding.h" +#include "shim.h" #include "vddk-structs.h" /* Enable extra disk info debugging with: -D vddk.diskinfo=1 */ @@ -71,7 +73,8 @@ int vddk_debug_extents; #define VDDK_MAJOR 5 #define VDDK_MINOR 1 -static void *dl = NULL; /* dlopen handle */ +static void *shimdl = NULL; /* shim dlopen handle */ +static void *dl = NULL; /* vddk dlopen handle */ static int init_called = 0; /* was InitEx called */ static char *config = NU...