search for: vcpus_entry

https://bugzilla.redhat.com/show_bug.cgi?id=823758

...@ -1051,6 +1053,32 @@ conversion_back_clicked (GtkWidget *w, gpointer data) > gtk_widget_set_sensitive (next_button, FALSE); > } > > +static int > +get_vcpus_from_conv_dlg (void) > +{ > + const char *str; > + int i; > + > + str = gtk_entry_get_text (GTK_ENTRY (vcpus_entry)); > + if (sscanf (str, "%d", &i) == 1 && i > 0) > + return i; > + else > + return 1; > +} > + > +static uint64_t > +get_memory_from_conv_dlg (void) > +{ > + const char *str; > + uint64_t i; > + > + str = gtk_entry_get_text...

...K_FILL, GTK_FILL, 1, 1); - vcpus_label = gtk_label_new (_("# vCPUs:")); + vcpus_label = gtk_label_new_with_mnemonic (_("# _vCPUs:")); table_attach (target_tbl, vcpus_label, 0, 1, 1, 2, GTK_FILL, GTK_FILL, 1, 1); set_alignment (vcpus_label, 1., 0.5); vcpus_entry = gtk_entry_new (); + gtk_label_set_mnemonic_widget (GTK_LABEL (vcpus_label), vcpus_entry); snprintf (vcpus_str, sizeof vcpus_str, "%d", config->vcpus); gtk_entry_set_text (GTK_ENTRY (vcpus_entry), vcpus_str); table_attach (target_tbl, vcpus_entry, @@ -810,11 +816,12 @@ creat...

..._dlg (void); enum { DISKS_COL_CONVERT = 0, @@ -1051,6 +1053,32 @@ conversion_back_clicked (GtkWidget *w, gpointer data) gtk_widget_set_sensitive (next_button, FALSE); } +static int +get_vcpus_from_conv_dlg (void) +{ + const char *str; + int i; + + str = gtk_entry_get_text (GTK_ENTRY (vcpus_entry)); + if (sscanf (str, "%d", &i) == 1 && i > 0) + return i; + else + return 1; +} + +static uint64_t +get_memory_from_conv_dlg (void) +{ + const char *str; + uint64_t i; + + str = gtk_entry_get_text (GTK_ENTRY (memory_entry)); + if (sscanf (str, "%" SCN...

...ment (GTK_MISC (vcpus_label), 1., 0.5); - gtk_table_attach (GTK_TABLE (target_tbl), vcpus_label, - 0, 1, 1, 2, GTK_FILL, GTK_FILL, 1, 1); + set_alignment (vcpus_label, 1., 0.5); + table_attach (target_tbl, vcpus_label, + 0, 1, 1, 2, GTK_FILL, GTK_FILL, 1, 1); vcpus_entry = gtk_entry_new (); snprintf (vcpus_str, sizeof vcpus_str, "%d", config->vcpus); gtk_entry_set_text (GTK_ENTRY (vcpus_entry), vcpus_str); - gtk_table_attach (GTK_TABLE (target_tbl), vcpus_entry, - 1, 2, 1, 2, GTK_FILL, GTK_FILL, 1, 1); + table_attach (target_...

This version of the Gtk 2/3 patch gets alignment and padding mostly right. I still can't work out how to vertically align labels in the middle of a cell in a GtkGrid. The GtkTextView in the final dialog is still broken. Rich.

... and a small initial patch which makes it easier to test virt-p2v without having to start up a virtual machine. There is still a bug in Gtk 3 where the GtkTextView on the final (running) dialog ignores gtk_widget_set_size_request and so the window appears just a single pixel high. Rich.

This is basically the same as what I posted earlier today. The main difference is I split out the GDK thread sychronization (removal of) changes from the other Gtk 2/3 changes, which should make it a bit easier to review. Gtk 3 is still not quite perfect. Apart from the problem with the GtkTextView noted before, there are also vertical alignment and padding problems with labels in GtkGrid

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1792141 Let the user pass "-oo" options from the kernel cmdline and from the GUI to virt-v2v. This is primarily useful with the OpenStack output mode, so reenable that mode. Cc: Alban Lecorps <alban.lecorps at ubisoft.com> Laszlo Alban Lecorps (1): Introduce "p2v.output.misc" for passing "-oo" options

Now that virt-p2v has its own repository [1] and releases [2], it is time to remove it from libguestfs. [1] https://github.com/libguestfs/virt-p2v [2] http://download.libguestfs.org/virt-p2v/ Pino Toscano (2): Remove virt-p2v Remove remaining virt-p2v bits .gitignore | 4 - Makefile.am | 7 +- bash/Makefile.am