search for: vblank_work

...syrjala at linux.intel.com>, > change below to signoff later] > > Cc: Ville Syrj?l? <ville.syrjala at linux.intel.com> > Signed-off-by: Lyude Paul <lyude at redhat.com> Hm not really sold on the idea that we have should reinvent our own worker infrastructure here. Imo a vblank_work should look like a delayed work, i.e. using struct work_struct as the base class, and wrapping the vblank thing around it (instead of the timer). That alos would allow drivers to schedule works on their own work queues, allowing for easier flushing and all that stuff. Also if we do this I think we...

...ed int pipe); static unsigned int drm_timestamp_precision = 20; /* Default to 20 usecs. */ @@ -440,6 +443,9 @@ void drm_vblank_cleanup(struct drm_device *dev) drm_core_check_feature(dev, DRIVER_MODESET)); del_timer_sync(&vblank->disable_timer); + + wake_up_all(&vblank->vblank_work.work_wait); + kthread_stop(vblank->vblank_work.thread); } kfree(dev->vblank); @@ -447,6 +453,108 @@ void drm_vblank_cleanup(struct drm_device *dev) dev->num_crtcs = 0; } +static int vblank_work_thread(void *data) +{ + struct drm_vblank_crtc *vblank = data; + + while (!kthread_s...

...later] > > > > > > Cc: Ville Syrj?l? <ville.syrjala at linux.intel.com> > > > Signed-off-by: Lyude Paul <lyude at redhat.com> > > > > Hm not really sold on the idea that we have should reinvent our own worker > > infrastructure here. Imo a vblank_work should look like a delayed work, > > i.e. using struct work_struct as the base class, and wrapping the vblank > > thing around it (instead of the timer). That alos would allow drivers to > > schedule works on their own work queues, allowing for easier flushing and > > all th...

...; > change below to signoff later] > > > > Cc: Ville Syrj?l? <ville.syrjala at linux.intel.com> > > Signed-off-by: Lyude Paul <lyude at redhat.com> > > Hm not really sold on the idea that we have should reinvent our own worker > infrastructure here. Imo a vblank_work should look like a delayed work, > i.e. using struct work_struct as the base class, and wrapping the vblank > thing around it (instead of the timer). That alos would allow drivers to > schedule works on their own work queues, allowing for easier flushing and > all that stuff. > >...

...gt; Cc: Ville Syrj?l? <ville.syrjala at linux.intel.com> > > > > Signed-off-by: Lyude Paul <lyude at redhat.com> > > > > > > Hm not really sold on the idea that we have should reinvent our own > > > worker > > > infrastructure here. Imo a vblank_work should look like a delayed work, > > > i.e. using struct work_struct as the base class, and wrapping the vblank > > > thing around it (instead of the timer). That alos would allow drivers to > > > schedule works on their own work queues, allowing for easier flushing >...

Nvidia released some documentation on how CRC support works on their GPUs, hooray! So: this patch series implements said CRC support in nouveau, along with adding some special debugfs interfaces for some relevant igt-gpu-tools tests that we'll be sending in just a short bit. This additionally adds a feature that Ville Syrj?l? came up with: vblank works. Basically, this is just a generic DRM

...tructure so that we can de-complicate our implementation of this. Anyway-welcome to the future! :) Major changes since v7: * Drop /harm/armh/ patch * Address danvet's comments * Drop "drm/nouveau/kms/nv50-: Unroll error cleanup in nv50_head_create()" Major changes since v6: * Move vblank_work related functions into their own files * Write documentation * Simplify work flushing and cancellation by getting rid of seqcounts and ->pending Major changes since v4: * Remove the interfaces we tried adding to kthread_worker and use a wait queue + seqcount in order to implement flushing vb...

...as well (hence why they came up with it!). And finally: in order to implement the last feature, we expose some new functions in the kernel's kthread_worker infrastructure so that we can de-complicate our implementation of this. Anyway-welcome to the future! :) Major changes since v6: * Move vblank_work related functions into their own files * Write documentation * Simplify work flushing and cancellation by getting rid of seqcounts and ->pending Major changes since v4: * Remove the interfaces we tried adding to kthread_worker and use a wait queue + seqcount in order to implement flushing vb...