Displaying 10 results from an estimated 10 matches for "vblank_put".
2017 Jan 18
1
[PATCH 3/4] drm/amd/display: Switch to using atomic_helper for flip.
...at drm_atomic_helper_page_flip doesn't
> call drm_crtc_vblank_get is a bit alarming. From the
> DRM_IOCTL_MODE_PAGE_FLIP POV, drm_crtc_vblank_get must be called
> when userspace calls the ioctl (either by drm_mode_page_flip_ioctl or the
> page_flip hook implementation), and drm_crtc_vblank_put must be called
> when the flip completes and the event is sent to userspace. How is this
> supposed to be handled with atomic?
First let me ask you - why we have to enable vlbank as part of pflip,
I understand why it has to be enbbled in WAIT_FOR_VBLANK IOCTL
but not sure about PFLIP IOCTL...
2015 Nov 09
2
[PATCH] drm/nouveau: Fix pre-nv50 pageflip events (v2)
...lt;treding at nvidia.com>
Cc: Mario Kleiner <mario.kleiner.de at gmail.com>
Cc: Ben Skeggs <bskeggs at redhat.com>
Cc: Ilia Mirkin <imirkin at alum.mit.edu>
v2 (mario): Integrate my own review comments into Daniels patch.
- Fix function prototypes in drmP.h
- Add missing vblank_put() for pageflip completion without
pageflip event.
- Initialize sequence number for queued pageflip event to avoid
trouble in drm_handle_vblank_events().
- Remove dead code and spelling fix.
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
Reviewed-by: Mario Kleiner &...
2015 Nov 10
2
[PATCH] drm/nouveau: Fix pre-nv50 pageflip events (v3)
...lt;treding at nvidia.com>
Cc: Mario Kleiner <mario.kleiner.de at gmail.com>
Cc: Ben Skeggs <bskeggs at redhat.com>
Cc: Ilia Mirkin <imirkin at alum.mit.edu>
v2 (mario): Integrate my own review comments into Daniels patch.
- Fix function prototypes in drmP.h
- Add missing vblank_put() for pageflip completion without
pageflip event.
- Initialize sequence number for queued pageflip event to avoid
trouble in drm_handle_vblank_events().
- Remove dead code and spelling fix.
v3 (mario): Add a signed-off-by and cc stable tag per Ilja's advice.
Signed-off-by: Dan...
2015 Nov 10
2
[PATCH] drm/nouveau: Fix pre-nv50 pageflip events (v3)
...o.kleiner.de at gmail.com>
>> Cc: Ben Skeggs <bskeggs at redhat.com>
>> Cc: Ilia Mirkin <imirkin at alum.mit.edu>
>>
>> v2 (mario): Integrate my own review comments into Daniels patch.
>> - Fix function prototypes in drmP.h
>> - Add missing vblank_put() for pageflip completion without
>> pageflip event.
>> - Initialize sequence number for queued pageflip event to avoidng
>> trouble in drm_handle_vblank_events().
>> - Remove dead code and spelling fix.
>>
>> v3 (mario): Add a signed-off-by a...
2015 Nov 09
0
[PATCH] drm/nouveau: Fix pre-nv50 pageflip events (v2)
...Cc: Mario Kleiner <mario.kleiner.de at gmail.com>
> Cc: Ben Skeggs <bskeggs at redhat.com>
> Cc: Ilia Mirkin <imirkin at alum.mit.edu>
>
> v2 (mario): Integrate my own review comments into Daniels patch.
> - Fix function prototypes in drmP.h
> - Add missing vblank_put() for pageflip completion without
> pageflip event.
> - Initialize sequence number for queued pageflip event to avoid
> trouble in drm_handle_vblank_events().
> - Remove dead code and spelling fix.
>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>...
2015 Nov 12
2
[PATCH] drm/nouveau: Fix pre-nv50 pageflip events (v3) -> v4
...n Skeggs <bskeggs at redhat.com>
> >>> Cc: Ilia Mirkin <imirkin at alum.mit.edu>
> >>>
> >>> v2 (mario): Integrate my own review comments into Daniels patch.
> >>> - Fix function prototypes in drmP.h
> >>> - Add missing vblank_put() for pageflip completion without
> >>> pageflip event.
> >>> - Initialize sequence number for queued pageflip event to avoidng
> >>> trouble in drm_handle_vblank_events().
> >>> - Remove dead code and spelling fix.
> >>&g...
2015 Nov 10
0
[PATCH] drm/nouveau: Fix pre-nv50 pageflip events (v3)
...c: Mario Kleiner <mario.kleiner.de at gmail.com>
> Cc: Ben Skeggs <bskeggs at redhat.com>
> Cc: Ilia Mirkin <imirkin at alum.mit.edu>
>
> v2 (mario): Integrate my own review comments into Daniels patch.
> - Fix function prototypes in drmP.h
> - Add missing vblank_put() for pageflip completion without
> pageflip event.
> - Initialize sequence number for queued pageflip event to avoid
> trouble in drm_handle_vblank_events().
> - Remove dead code and spelling fix.
>
> v3 (mario): Add a signed-off-by and cc stable tag per Ilja'...
2015 Dec 15
2
[PATCH] drm/nouveau: Fix pre-nv50 pageflip events (v4)
...and not when it
>> completes in the next vblank seems to be fairly common (older i915 hw
>> works very similarly) create a new helper to arm vblank events for
>> such drivers.
>>
>> v2 (Mario Kleiner):
>> - Fix function prototypes in drmP.h
>> - Add missing vblank_put() for pageflip completion without
>> pageflip event.
>> - Initialize sequence number for queued pageflip event to avoid
>> trouble in drm_handle_vblank_events().
>> - Remove dead code and spelling fix.
>>
>> v3 (Mario Kleiner):
>> - Add a signed-off-by...
2015 Nov 11
0
[PATCH] drm/nouveau: Fix pre-nv50 pageflip events (v3) -> v4
...m>
>>> Cc: Ben Skeggs <bskeggs at redhat.com>
>>> Cc: Ilia Mirkin <imirkin at alum.mit.edu>
>>>
>>> v2 (mario): Integrate my own review comments into Daniels patch.
>>> - Fix function prototypes in drmP.h
>>> - Add missing vblank_put() for pageflip completion without
>>> pageflip event.
>>> - Initialize sequence number for queued pageflip event to avoidng
>>> trouble in drm_handle_vblank_events().
>>> - Remove dead code and spelling fix.
>>>
>>> v3 (mario...
2017 Jan 16
4
[PATCH 3/4] drm/amd/display: Switch to using atomic_helper for flip.
...flip\n",
> - crtc->base.id);
> - ret = -EINVAL;
> - goto fail;
> - }
> - acrtc->flip_flags = flags;
> -
> - ret = drm_atomic_nonblocking_commit(state);
> -
> -fail:
> - if (ret == -EDEADLK)
> - goto backoff;
> -
> - if (ret)
> - drm_crtc_vblank_put(crtc);
> -
> - drm_atomic_state_put(state);
> -
> - return ret;
> -backoff:
> - drm_atomic_state_clear(state);
> - drm_atomic_legacy_backoff(state);
> -
> - /*
> - * Someone might have exchanged the framebuffer while we dropped locks
> - * in the backoff code. We...