Displaying 4 results from an estimated 4 matches for "vblank_on".
Did you mean:
vblank_hi
2017 Jul 20
2
[PATCH] drm: disable vblank only if it got previously enabled
...s,
Tobias
On 7/20/17 10:13 AM, Daniel Vetter wrote:
> On Wed, Jul 19, 2017 at 04:10:50PM -0400, Ilia Mirkin wrote:
>> I believe the solution is to not call drm_crtc_vblank_off for atomic
>> modesetting in nouveau_display_fini. I think Ben's working on it.
> Yes, the goal of vblank_on/off was very much to not paper over driver bugs
> with clever tricks like these. If the driver cant keep track of its
> vblank, something has gone wrong, and the core should _not_ fix it up.
> Otherwise we're back to the old style vblank horror show.
>
> Thanks, Daniel
>
>&...
2017 Jul 19
2
[PATCH] drm: disable vblank only if it got previously enabled
...k.c
> index a233a6be934a..4a21756bf2bd 100644
> --- a/drivers/gpu/drm/drm_vblank.c
> +++ b/drivers/gpu/drm/drm_vblank.c
> @@ -1140,8 +1140,11 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)
>
> /* Avoid redundant vblank disables without previous
> * drm_crtc_vblank_on(). */
> - if (drm_core_check_feature(dev, DRIVER_ATOMIC) || !vblank->inmodeset)
> + if (drm_core_check_feature(dev, DRIVER_ATOMIC) || (!vblank->inmodeset &&
> + vblank->enabled)) {
> + DRM_DEBUG("disabling vblank on crtc %u\n...
2017 Jul 20
0
[PATCH] drm: disable vblank only if it got previously enabled
On Wed, Jul 19, 2017 at 04:10:50PM -0400, Ilia Mirkin wrote:
> I believe the solution is to not call drm_crtc_vblank_off for atomic
> modesetting in nouveau_display_fini. I think Ben's working on it.
Yes, the goal of vblank_on/off was very much to not paper over driver bugs
with clever tricks like these. If the driver cant keep track of its
vblank, something has gone wrong, and the core should _not_ fix it up.
Otherwise we're back to the old style vblank horror show.
Thanks, Daniel
>
> On Wed, Jul 19, 2017 a...
2017 Jul 20
0
[PATCH] drm: disable vblank only if it got previously enabled
...7/20/17 10:13 AM, Daniel Vetter wrote:
>> On Wed, Jul 19, 2017 at 04:10:50PM -0400, Ilia Mirkin wrote:
>>> I believe the solution is to not call drm_crtc_vblank_off for atomic
>>> modesetting in nouveau_display_fini. I think Ben's working on it.
>> Yes, the goal of vblank_on/off was very much to not paper over driver bugs
>> with clever tricks like these. If the driver cant keep track of its
>> vblank, something has gone wrong, and the core should _not_ fix it up.
>> Otherwise we're back to the old style vblank horror show.
>>
>> Thank...