search for: valuesperblock

...--- a/lib/Transforms/Scalar/GVN.cpp +++ b/lib/Transforms/Scalar/GVN.cpp @@ -1767,7 +1767,7 @@ bool GVN::processNonLocalLoad(LoadInst *LI) { } // Step 4: Eliminate partial redundancy. - if (!EnablePRE || !EnableLoadPRE) + if (!EnableLoadPRE) return false; return PerformLoadPRE(LI, ValuesPerBlock, UnavailableBlocks); This will disable Scalar PRE without disabling load PRE. (note, again, however, that load PRE can create exactly the same GEP situation you are referring to)

...lib/Transforms/Scalar/GVN.cpp > @@ -1767,7 +1767,7 @@ bool GVN::processNonLocalLoad(LoadInst *LI) { > } > > // Step 4: Eliminate partial redundancy. > - if (!EnablePRE || !EnableLoadPRE) > + if (!EnableLoadPRE) > return false; > > return PerformLoadPRE(LI, ValuesPerBlock, UnavailableBlocks); > > > > > This will disable Scalar PRE without disabling load PRE. > > > (note, again, however, that load PRE can create exactly the same GEP situation you are referring to) >

Hi, Daniel: Thanks a lot for detailed background information, we are willing to provide the right fix, however it will take time, do you mind if you forward me the discussion you had 5 months ago? I may not be able to access it since I only joined ellvmdev list this week. I did some performance measurement last night, some of our critical benchmark degraded up to 30% with your patch, so we have