Displaying 6 results from an estimated 6 matches for "validate_encoder_layout".
2017 Apr 10
2
[Patch] Non-diegetic support for channel mapping 254
...((nondiegetic_channels / 2) % 2);
+ nb_coupled_streams = nondiegetic_channels / 2;
Why not just have:
+ nb_streams = acn_channels + nondiegetic_channels;
+ nb_coupled_streams = nondiegetic_channels != 0;
Done
4) About this change:
- if (!validate_layout(&st->layout) ||
!validate_encoder_layout(&st->layout))
+ if (!validate_layout(&st->layout) ||
+ (mapping_type == MAPPING_TYPE_SURROUND &&
+ !validate_encoder_layout(&st->layout)))
Is there nothing to validate for ambisonics?
We do this when determine the (n+1)^2 + 2j listed above, but we can
va...
2017 Apr 07
2
[Patch] Non-diegetic support for channel mapping 254
Hello all,
Attached is a proposed patch for Opus that allows support for encoding
non-diegetic stereo audio as a coupled stream for use with channel mapping
254. It also rejects channel counts that are not (n+1)^2 + 2j, where n is 0
to 14 and j is either 0 or 1 (See IETF public draft doc attached for
clarification).
Please let me know any suggestions / concerns / comments.
Thank you for your
2017 Apr 07
0
[Patch] Non-diegetic support for channel mapping 254
...nnels + ((nondiegetic_channels / 2) % 2);
+ nb_coupled_streams = nondiegetic_channels / 2;
Why not just have:
+ nb_streams = acn_channels + nondiegetic_channels;
+ nb_coupled_streams = nondiegetic_channels != 0;
4) About this change:
- if (!validate_layout(&st->layout) ||
!validate_encoder_layout(&st->layout))
+ if (!validate_layout(&st->layout) ||
+ (mapping_type == MAPPING_TYPE_SURROUND &&
+ !validate_encoder_layout(&st->layout)))
Is there nothing to validate for ambisonics?
5) For opus_multistream_surround_encoder_init(), the same comments as...
2017 Apr 24
0
[Patch] Non-diegetic support for channel mapping 254
...els / 2;
>
> Why not just have:
> + nb_streams = acn_channels + nondiegetic_channels;
> + nb_coupled_streams = nondiegetic_channels != 0;
>
> Done
>
>
> 4) About this change:
> - if (!validate_layout(&st->layout) ||
> !validate_encoder_layout(&st->layout))
> + if (!validate_layout(&st->layout) ||
> + (mapping_type == MAPPING_TYPE_SURROUND &&
> + !validate_encoder_layout(&st->layout)))
>
> Is there nothing to validate for ambisonics?
>
> We do this when det...
2017 Apr 25
2
[Patch] Non-diegetic support for channel mapping 254
...:
> > + nb_streams = acn_channels + nondiegetic_channels;
> > + nb_coupled_streams = nondiegetic_channels != 0;
> >
> > Done
> >
> >
> > 4) About this change:
> > - if (!validate_layout(&st->layout) ||
> > !validate_encoder_layout(&st->layout))
> > + if (!validate_layout(&st->layout) ||
> > + (mapping_type == MAPPING_TYPE_SURROUND &&
> > + !validate_encoder_layout(&st->layout)))
> >
> > Is there nothing to validate for ambisonics?
> &...
2015 Aug 07
0
[PATCH] Silence clang -Wcast-align warnings
...get_window_mem(OpusMSEncoder *st)
@@ -117,7 +118,8 @@ static opus_val32 *ms_get_window_mem(OpusMSEncoder *st)
else
ptr += align(mono_size);
}
- return (opus_val32*)ptr;
+ /* void* cast avoids clang -Wcast-align warning */
+ return (opus_val32*)(void*)ptr;
}
static int validate_encoder_layout(const ChannelLayout *layout)
--
2.4.5