search for: valgrind_daemon

Instead of forcing valgrind to be run when --enable-valgrind-daemon is passed to configure, enable it only when the backend setting "valgrind_daemon" is set. This allows developers to keep building with --enable-valgrind-daemon, which unconditionally adds valgrind in the appliance but using only when requested. When --enable-valgrind-daemon is not passed (typical for release builds), then no valgrind-related code is built at all, and &qu...

...les.in \ - guestfsd.suppressions \ guestfs_lvm_conf.aug \ guestfs_shadow.aug \ hostfiles.in \ @@ -66,9 +65,6 @@ make.sh: make.sh.in $(top_builddir)/config.log $(top_builddir)/config.status rm -f $@-t PACKAGELIST_CPP_FLAGS = -D$(DISTRO)=1 -DEXTRA_PACKAGES="$(EXTRA_PACKAGES)" -if VALGRIND_DAEMON -PACKAGELIST_CPP_FLAGS += -DVALGRIND_DAEMON=1 -endif packagelist: packagelist.in Makefile m4 $(PACKAGELIST_CPP_FLAGS) $< | \ @@ -76,12 +72,11 @@ packagelist: packagelist.in Makefile cmp -s $@ $@-t || mv $@-t $@ rm -f $@-t -supermin.d/daemon.tar.gz: ../daemon/guestfsd guestfsd.suppress...

Previously posted here: https://www.redhat.com/archives/libguestfs/2015-June/msg00266.html Rich.

...rt-*.1 tools/virt-*.pl +/valgrind.log.* diff --git a/appliance/Makefile.am b/appliance/Makefile.am index e2e8b96..99896be 100644 --- a/appliance/Makefile.am +++ b/appliance/Makefile.am @@ -42,13 +42,18 @@ make.sh: make.sh.in chmod +x $@-t mv $@-t $@ +PACKAGELIST_CPP_FLAGS = -D$(DISTRO)=1 +if VALGRIND_DAEMON +PACKAGELIST_CPP_FLAGS += -DVALGRIND_DAEMON=1 +endif + packagelist: packagelist.in - cpp -undef -D$(DISTRO)=1 < $< | \ + cpp -undef $(PACKAGELIST_CPP_FLAGS) < $< | \ grep -v '^[[:space:]]*$$' | grep -v '^#' > $@-t mv $@-t $@ excludelist: excludelist.in - cpp -...

...-quiet -o -H newc ) > $@-t + rm -rf tmp mv $@-t $@ supermin.d/init.img: init diff --git a/configure.ac b/configure.ac index 5caca32..3712d19 100644 --- a/configure.ac +++ b/configure.ac @@ -278,6 +278,26 @@ if test "x$enable_daemon" = "xyes"; then AC_DEFINE([VALGRIND_DAEMON],[1],[Define to 1 to run the daemon under valgrind]) AC_DEFINE_UNQUOTED([VALGRIND_LOG_PATH],["$(pwd)"],[Path to save valgrind log files]) fi + + dnl Which directory should we put the daemon in? NOTE: This + dnl is the "virtual" directory insi...

This patch series lets you run the daemon under valgrind. Many errors were found and fixed. With the complete series applied, valgrind doesn't show any errors.

...e syslinux tar udev util-linux -util-linux-ng #ifndef UBUNTU /* on Ubuntu contains a file in /lib64 which conflicts with libc6 that has * /lib64 as a symbolic link @@ -165,6 +160,14 @@ xfsprogs #endif zerofree +#ifndef SUSE +gdisk +kmod +procps-ng +scrub +util-linux-ng +#endif + #ifdef VALGRIND_DAEMON valgrind #endif

Currently we are unable to properly run guestfsd (the daemon) under valgrind. Attempts to run valgrind inside the appliance have not been successful (see patch 1/7). However we desperately need better valgrind coverage of the daemon, particularly because it is doing a lot of complex parsing of program output. This has been a problem for a long time. A better way to attack this problem is to

In v2: - Kernel command line parsing now moved to the appliance. - In the captive daemon test, the daemon cleanly shuts down on exit. - Add another btrfs test. Rich.

...on Ubuntu contains a file in /lib64 which conflicts with libc6 that has > * /lib64 as a symbolic link > @@ -165,6 +160,14 @@ xfsprogs > #endif > zerofree > > +#ifndef SUSE > +gdisk > +kmod > +procps-ng > +scrub > +util-linux-ng > +#endif > + > #ifdef VALGRIND_DAEMON > valgrind > #endif But supermin is supposed to ignore packages that don't exist in the distro. This is a bug in supermin or the zypp plugin for supermin. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests witho...

...g whitespace on one line. 'git show' should highlight it. > diff --git a/appliance/packagelist.in b/appliance/packagelist.in > index 76c7293..a4f814b 100644 > --- a/appliance/packagelist.in > +++ b/appliance/packagelist.in > @@ -255,5 +255,12 @@ zerofree > > ifelse(VALGRIND_DAEMON,1,valgrind) > > +dnl tools needed by virt-dib > +curl > +qemu-img > +debootstrap > +apt > +which What's the purpose of each of these new tools added to the appliance? Is qemu-img really run inside the appliance? In particular, is apt (which probably requires perl) only...

...; highlight it. Fixed, thanks. > > diff --git a/appliance/packagelist.in b/appliance/packagelist.in > > index 76c7293..a4f814b 100644 > > --- a/appliance/packagelist.in > > +++ b/appliance/packagelist.in > > @@ -255,5 +255,12 @@ zerofree > > > > ifelse(VALGRIND_DAEMON,1,valgrind) > > > > +dnl tools needed by virt-dib > > +curl > > +qemu-img > > +debootstrap > > +apt > > +which > > What's the purpose of each of these new tools added to the appliance? > Is qemu-img really run inside the appliance? At least...

...rt > po/POTFILES-ml # Try to stop people using 'make install' without 'DESTDIR'. diff --git a/appliance/packagelist.in b/appliance/packagelist.in index 76c7293..a4f814b 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -255,5 +255,12 @@ zerofree ifelse(VALGRIND_DAEMON,1,valgrind) +dnl tools needed by virt-dib +curl +qemu-img +debootstrap +apt +which + dnl Define this by doing: ./configure --with-extra-packages="..." EXTRA_PACKAGES diff --git a/configure.ac b/configure.ac index e0da1ad..9356566 100644 --- a/configure.ac +++ b/configure.ac @@ -1740,6...

v1 was here: https://www.redhat.com/archives/libguestfs/2013-August/msg00005.html This now works, to some extent. The main problem now is that devices are named /dev/ubd[a-] which of course confuses everything. I'm thinking it may be easier to add a udev rule to rename them. Rich.

This is a User-Mode Linux backend for libguestfs. You can select it by doing: export LIBGUESTFS_BACKEND=uml export LIBGUESTFS_QEMU=/path/to/vmlinux Note we're reusing the 'qemu' variable in the handle for convenience. QEmu is not involved when using the UML backend. This almost works. UML itself crashes when the daemon tries to connect to the serial port. I suspect it's

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

https://bugzilla.redhat.com/show_bug.cgi?id=836710 https://bugzilla.redhat.com/show_bug.cgi?id=836913 There are at least two related bugs going on: (1) Linux sync(2) system call doesn't send a write barrier to the disk, so in effect it doesn't force the hard disk to flush its cache. libguestfs used sync(2) to force changes to disk. We didn't expect that qemu was caching anything

...3,7 @@ SUBDIRS += \ mllib \ customize \ builder builder/website \ + dib \ resize \ sparsify \ sysprep \ diff --git a/appliance/packagelist.in b/appliance/packagelist.in index 76c7293..160d9e8 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -257,3 +257,8 @@ ifelse(VALGRIND_DAEMON,1,valgrind) dnl Define this by doing: ./configure --with-extra-packages="..." EXTRA_PACKAGES +curl +qemu-img +debootstrap +apt +which diff --git a/configure.ac b/configure.ac index 1552bff..8194bb6 100644 --- a/configure.ac +++ b/configure.ac @@ -1740,6 +1740,7 @@ AC_CONFIG_FILES([Mak...

...rt > po/POTFILES-ml # Try to stop people using 'make install' without 'DESTDIR'. diff --git a/appliance/packagelist.in b/appliance/packagelist.in index d218a37..a436b32 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -256,5 +256,17 @@ zerofree ifelse(VALGRIND_DAEMON,1,valgrind) +dnl tools needed by virt-dib +ifelse(REDHAT,1, + qemu-img + which +) +ifelse(DEBIAN,1, + qemu-utils +) +curl +dnl tools optionally used for elements +debootstrap + dnl Define this by doing: ./configure --with-extra-packages="..." EXTRA_PACKAGES diff --git a/configure.a...

...3,7 @@ SUBDIRS += \ mllib \ customize \ builder builder/website \ + dib \ resize \ sparsify \ sysprep \ diff --git a/appliance/packagelist.in b/appliance/packagelist.in index 76c7293..2f6878e 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -257,3 +257,7 @@ ifelse(VALGRIND_DAEMON,1,valgrind) dnl Define this by doing: ./configure --with-extra-packages="..." EXTRA_PACKAGES +curl +qemu-img +debootstrap +apt diff --git a/configure.ac b/configure.ac index d4137f6..1f6d21c 100644 --- a/configure.ac +++ b/configure.ac @@ -1703,6 +1703,8 @@ AC_CONFIG_FILES([builder/li...