search for: v2vnetcf

...ised by this patch (which doesn't say much of course, because I > know precious little about Windows). What I'm noticing is "run > pnputil.exe before pnp_wait.exe before everything else". > > We do queue a script earlier than those, at priority 2500, called > "v2vnetcf.ps1". See configure_network_interfaces -> > add_firstboot_powershell, and the reference to RHBZ 1788823. > > And that script is exactly what tends *not* to work, and we've been > unable to get to the bottom of that issue. (See also RH 2068361 and > 1963032.) > > S...

...he script; * Add another small patch removing separate log file from wait-pnp script. Discussion on v2: https://listman.redhat.com/archives/libguestfs/2023-March/031025.html v2 -> v3: * Prioritize firstboot script with ~prio:2000. That value is chosen to be higher than that of "v2vnetcf.ps1". Discussion on v1: https://listman.redhat.com/archives/libguestfs/2023-March/031001.html v1 -> v2: * Omit redirecting output to a separate log with "%~dpn0.log". Andrey Drobyshev (2): convert_windows: add firstboot script to install drivers with pnputil convert_wind...

...e logging. I'm surprised by this patch (which doesn't say much of course, because I know precious little about Windows). What I'm noticing is "run pnputil.exe before pnp_wait.exe before everything else". We do queue a script earlier than those, at priority 2500, called "v2vnetcf.ps1". See configure_network_interfaces -> add_firstboot_powershell, and the reference to RHBZ 1788823. And that script is exactly what tends *not* to work, and we've been unable to get to the bottom of that issue. (See also RH 2068361 and 1963032.) So... This patch could be orthogonal...

Essentially identical to v1 except that it now uses (overloads?) the --mac option to supply this data. Rich.

...network_interfaces net_driver = + (* If we were asked to force network interfaces to have particular + * static IP addresses then it is done here by installing a + * Powershell script which runs at boot. + *) + if force_interfaces <> [] then ( + let psh_filename = "v2vnetcf.ps1" in + let psh = ref [] in + let add = List.push_back psh in + + add "Set-PSDebug -Trace 1"; + add ""; + + (* If virtio-net was added to the registry, we must wait for + * it to be installed at runtime. + *) + if net_driver = Vir...

On Thu, Mar 09, 2023 at 03:47:10PM +0200, Andrey Drobyshev wrote: > On 3/8/23 22:52, Richard W.M. Jones wrote: > > On Wed, Mar 08, 2023 at 08:05:35PM +0200, Andrey Drobyshev wrote: > >> During conversion we copy the necessary drivers to the directory > >> "%systemroot%\Drivers\Virtio", adding it to the DevicePath registry > >> value. As documented in

...igure_network_interfaces net_driver = + (* If we were asked to force network interfaces to have particular + * static IP addresses then it is done here by installing a + * Powershell script which runs at boot. + *) + if static_ips <> [] then ( + let psh_filename = "v2vnetcf.ps1" in + let psh = ref [] in + let add = List.push_back psh in + + add "Set-PSDebug -Trace 1"; + add ""; + + (* If virtio-net was added to the registry, we must wait for + * it to be installed at runtime. + *) + if net_driver = Vir...

--- v2v/windows.ml | 24 ++++++++++++++++++++++++ v2v/windows.mli | 6 ++++++ 2 files changed, 30 insertions(+) diff --git a/v2v/windows.ml b/v2v/windows.ml index 23d589b00..dde64e677 100644 --- a/v2v/windows.ml +++ b/v2v/windows.ml @@ -19,6 +19,7 @@ open Printf open Common_gettext.Gettext +open Std_utils open Tools_utils open Utils @@ -45,3 +46,26 @@ and check_app { Guestfs.app2_name

Patch v2 was here: https://www.redhat.com/archives/libguestfs/2019-April/thread.html#00114 There's no change here except that I've rebased it against the latest master branch and retested. There was a comment by Pino (https://www.redhat.com/archives/libguestfs/2019-April/msg00117.html) which isn't incorporated into this patch. Rich.