search for: userremovedfromcsemap

...a problem in ReplaceAllUsesOf itself. It recurses down and eventually replaces the node under the iterator in this use loop: SDNode::use_iterator UI = From.getNode()->use_begin(), UE = From.getNode()->use_end(); while (UI != UE) { SDNode *User = *UI; bool UserRemovedFromCSEMaps = false; UI goes bad and we blow up after returning from a deeply recursed call. It's simply not safe to iterate over a set that may change. Unfortunately, any of the nodes under the iterators may change so I don't see an easy way to fix this....

...lf. It recurses > down and eventually replaces the node under the iterator in this use > loop: > > SDNode::use_iterator UI = From.getNode()->use_begin(), > UE = From.getNode()->use_end(); > while (UI != UE) { > SDNode *User = *UI; > bool UserRemovedFromCSEMaps = false; > > > UI goes bad and we blow up after returning from a deeply recursed call. > > It's simply not safe to iterate over a set that may change. Unfortunately, > any of the nodes under the iterators may change so I don't see an easy > way to fix this. The t...

On Feb 26, 2010, at 2:07 PM, David Greene wrote: > On Friday 26 February 2010 10:34:41 David Greene wrote: >> On Friday 26 February 2010 09:55:32 David Greene wrote: >>> In the continuing quest to try to track down problems we're seeing >>> in >>> SelectionDAG, I added the following assert >>> toSelectionDAG::ReplaceAllUsesOfValuesWith: >>

On Friday 26 February 2010 10:34:41 David Greene wrote: > On Friday 26 February 2010 09:55:32 David Greene wrote: > > In the continuing quest to try to track down problems we're seeing in > > SelectionDAG, I added the following assert > > toSelectionDAG::ReplaceAllUsesOfValuesWith: > > Here's a patch to add more of these deleted node asserts. They fire > tons