search for: user_label_prefix

Hi Chris, your commit 103140 broke PR397 for llvm-gcc (in LLVM 2.9) and dragonegg. In the PR, asm renaming creates two linkonce functions with the same asm name (in the IR they are @"\01lstat64" and "@lstat64". What used to happen is that they were both output to the assembler file, both with the name lstat64, exactly like GCC does. The assembler and linker are perfectly

...the target', names > definitely do need to be mangled for some targets even without this. > For example, elf systems can't handle symbols with spaces in them. Thanks, with this description I was able to find /* User label prefix in effect for this compilation. */ extern const char *user_label_prefix; from llvm-gcc's output.h. Is llvm_asm_prefix still a good name for the "\1" prefix?

...to support outputting multiple functions >> with the same name, as long as they have weak linkage? > > No, I don't. I think that an IR module should be required to be well defined and obey the rules. For GCC/clang (and any other compilers that support things like asm renaming and USER_LABEL_PREFIX), I think it is best for the frontend to not use the "\01" prefix in a case that conflicts with the normal USER_LABEL_PREFIX. For example, on an _'y system, if asm-renamed to "_foo", the IR name should be just @"foo", not "\01_foo". I think I agree. My...

...is reasonable to support outputting multiple functions > with the same name, as long as they have weak linkage? No, I don't. I think that an IR module should be required to be well defined and obey the rules. For GCC/clang (and any other compilers that support things like asm renaming and USER_LABEL_PREFIX), I think it is best for the frontend to not use the "\01" prefix in a case that conflicts with the normal USER_LABEL_PREFIX. For example, on an _'y system, if asm-renamed to "_foo", the IR name should be just @"foo", not "\01_foo". -Chris

On Nov 18, 2009, at 10:17 AM, Timo Juhani Lindfors wrote: > Hi, > > llvm, clang and llvm-gcc contain numerous references to 1, '\1', > '\01', '\001', "\01" and "\01foo". This makes it difficult for one to > find all occurences of this prefix character and lacks a central place > where the prefix could be documented. (See for example

Hi, llvm, clang and llvm-gcc contain numerous references to 1, '\1', '\01', '\001', "\01" and "\01foo". This makes it difficult for one to find all occurences of this prefix character and lacks a central place where the prefix could be documented. (See for example http://llvm.org/bugs/show_bug.cgi?id=5480 ) How about adding a #define for this prefix?