search for: use_dtx

Hi, I've attached a patch to fix use_dtx when building with DISABLE_FLOAT_API. Thanks, Felicia -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20160720/4bcbab8d/attachment.html> -------------- next part -------------- A non-text attachment was scrubbe...

...condition will be alway true except exceptional case. (analysis_info.valid || is_silence) But in a code, there is a NOT expression in front of above condition, so st->silk_mode.useDTX will be always disable Here is the code. #ifndef DISABLE_FLOAT_API st->silk_mode.useDTX = st->use_dtx && !(analysis_info.valid || is_silence); #else st->silk_mode.useDTX = st->use_dtx; #endif Is it a bug or are there any reason for this? In my opinion, the NOT expression should to be removed. I attached a fixed file. Please review. Thanks, InGyu Kang -------------- ne...

...int random_framesize=0, newsize=0, delayed_celt=0; @@ -336,15 +336,12 @@ int main(int argc, char *argv[]) /* defaults: */ use_vbr = 1; - bandwidth = OPUS_AUTO; max_payload_bytes = MAX_PACKET; complexity = 10; use_inbandfec = 0; forcechannels = OPUS_AUTO; use_dtx = 0; packet_loss_perc = 0; - max_frame_size = 2*48000; - curr_read=0; while( args < argc - 2 ) { /* process command line options */ -- 2.1.4

.../* DTX determined by Silk. */ + void *silk_enc = (char*)st+st->silk_enc_offset; + *value = ((silk_encoder*)silk_enc)->state_Fxx[0].sCmn.noSpeechCounter >= NB_SPEECH_FRAMES_BEFORE_DTX; + } +#ifndef DISABLE_FLOAT_API + else if (st->use_dtx) { + /* DTX determined by Opus. */ + *value = st->nb_no_activity_frames >= NB_SPEECH_FRAMES_BEFORE_DTX; + } +#endif + } + break; case CELT_GET_MODE_REQUEST: { -------------- next part -------------- An HTML attachment w...

...to produce a DTX frame. For example, in the case of > stereo the SILK DTX code considers both channels, but this code looks > only at state_Fxx[0]. Shouldn't the behavior match? > > - Mark > > > > > +#ifndef DISABLE_FLOAT_API > > + else if (st->use_dtx) { > > + /* DTX determined by Opus. */ > > + *value = st->nb_no_activity_frames >= > > NB_SPEECH_FRAMES_BEFORE_DTX; > > + } > > +#endif > > + } > > + break; > > > > case CELT_...

...behavior as the code that decides whether to produce a DTX frame. For example, in the case of stereo the SILK DTX code considers both channels, but this code looks only at state_Fxx[0]. Shouldn't the behavior match? - Mark > +#ifndef DISABLE_FLOAT_API > +            else if (st->use_dtx) { > +                /* DTX determined by Opus. */ > +                *value = st->nb_no_activity_frames >= > NB_SPEECH_FRAMES_BEFORE_DTX; > +            } > +#endif > +        } > +        break; >   >          case CELT_GET_MODE_REQUEST: >          { > &gt...