search for: use_celt_fir

Hi Jean-Marc, The original celt_fir() is a little bit messy. It has 2 branches chosen by #ifdef SMALL_FOOTPRINT. For floating-point, the 2 branches are identical (except the operation sequence of accumulating x[i] to sum, which is not a big deal). For fixed-point, the 2 branches are different. I separate them into 2 functions: the new celt_fir(), and celt_fir_permit_overflow() which is the

> > I believe the solution would be to always have either: > 1) USE_CELT_FIR=1 and use ovflw() macros in the xcorr code; or > 2) USE_CELT_FIR=0 and no ovflw() in the xcorr code > I prefer to create a function named silk_fir() with optimization to do the calculation when USE_CELT_FIR=0. xcorr_kernel() itself is great and provides many gains. The only issue is that ca...

...ich casts to unsigned to avoid the undefined behaviour and thus the ubsan warnings. In celt_fir() and the pitch correlation code it uses, we know there should not be signed overflows, so we would like to detect any problem when using ubsan. I believe the solution would be to always have either: 1) USE_CELT_FIR=1 and use ovflw() macros in the xcorr code; or 2) USE_CELT_FIR=0 and no ovflw() in the xcorr code We can then switch between the two cases at compile time. I think 2) is appropriate when we have --enable-assertions without --enable-check-asm, wheras 1) is appropriate the rest of the time. That way...

...644 --- a/silk/LPC_analysis_filter.c +++ b/silk/LPC_analysis_filter.c @@ -44,9 +44,8 @@ POSSIBILITY OF SUCH DAMAGE. current implementation silences by casting to unsigned. Enabling this should be safe in pretty much all cases, even though it is not technically C89-compliant. */ -#define USE_CELT_FIR 0 -void silk_LPC_analysis_filter( +void silk_LPC_analysis_filter_c( opus_int16 *out, /* O Output signal */ const opus_int16 *in, /* I Input signal...

Hi, Attached is a patch with arm neon optimizations for silk_warped_autocorrelation_FIX(). Please review. Thanks, Felicia -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20170131/9a912bb4/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: